New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 611973 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Material: Add 2dp elevation to the omnibox when scrolled to the top

Project Member Reported by mcwilliams@chromium.org, May 14 2016

Issue description

I have added 2dp to the fake omnibox when the experiment is enabled but feel the omnibox when scrolled to the top looks flat. Awaiting response from designers for action item

Related
https://bugs.chromium.org/p/chromium/issues/detail?id=609078
 

Comment 1 by nepper@chromium.org, May 15 2016

Cc: -bettes@chromium.org mcwilliams@chromium.org
Labels: zine-mr-mile-MVP M-52
Owner: bettes@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by bettes@chromium.org, May 16 2016

To continue the metaphor between fake omnibox and real omnibox, let's add the same 2dp elevation to the omnibox when scrolled to the top. 


Project Member

Comment 3 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Assigned)
The fakebox and the real omnibox now do have the same shadow, but the fakebox took the shadow from the real omnibox.
Thanks Bernhard. I guess that means that the shadow still needs to be changed?
I'm happy to change the shadow (on both fake and real omnibox) to anything you can provide to me as a nine-patch file :)
Talked to Bernhard offline. He's confirmed our shadow treatment with Alan (the textbox.9.png file), which is not consistent with a 2dp elevation. I defer to Alan and consider this complete.

Comment 8 by fi...@chromium.org, Jul 1 2016

Labels: zine-mr-MVP

Comment 9 by finkm@google.com, Jul 1 2016

Labels: -zine-mr-mvp
Labels: zine-mr-MVP

Sign in to add a comment