New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 611961 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 611905



Sign in to add a comment

//services/shell/public/interfaces/*.mojom needs a security review

Project Member Reported by dcheng@chromium.org, May 14 2016

Issue description

These interfaces don't appear to have gone through security review. Marking ReleaseBlock-Stable to be on the safe side for now.

 

Comment 1 by dcheng@chromium.org, May 14 2016

Blocking: 611905
Labels: Security_Severity-High Security_Impact-None
Labels: OS-All
[Bulk edit]

Release blockers need OS set.  Looks like all of these are applicable for OS-All, correct if required.
This issue is set as M52 Release block Stable. Is there anything which needs to to be taken care in M52? Please resolve ASAP.
Status: Assigned (was: Available)
Assigning to Daniel as per offline conversation.Work is in progress and ship with M52 Stable.

M52 Pre-stable promotion is planned during July 2-nd week, please plan accordingly.

Comment 6 Deleted

Labels: -Security_Impact-None Security_Impact-Stable
Bulk edit: swapping issues for mojo reviews back to Security_Impact-Stable. We're adding a sheriffbot rule to automatically remove release block labels from Security_Impact-None bugs, but in this case I think they make sense. These issues for audits/reviews tend to be a bit awkward to triage.
Project Member

Comment 8 by ClusterFuzz, Jun 24 2016

Labels: Missing_Owner-13
Project Member

Comment 9 by ClusterFuzz, Jun 25 2016

Labels: -Missing_Owner-13 Missing_Owner-14
Labels: -Missing_Owner-14
Owner: dcheng@chromium.org
*Actually* assigning to dcheng.
Components: Internals>Mojo
Project Member

Comment 12 by sheriffbot@chromium.org, Jun 26 2016

dcheng: Uh oh! This issue still open and hasn't been updated in the last 43 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 13 Deleted

** IMPORTANT change in M52 merge date due to first 2 weeks of July no release weeks **
M52 Stable is launching very soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged ASAP. All changes MUST be merged into the release branch by 5pm on July 1 to make into the desktop Stable final build cut. Thank you!

Labels: -ReleaseBlock-Stable
Cc: dcheng@chromium.org
Owner: kenrb@chromium.org
Project Member

Comment 17 by sheriffbot@chromium.org, Jul 10 2016

kenrb: Uh oh! This issue still open and hasn't been updated in the last 57 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Te-NeedsFurtherTriage
Project Member

Comment 19 by sheriffbot@chromium.org, Jul 13 2016

Labels: Deadline-Exceeded
We commit ourselves to a 60 day deadline for fixing for high severity vulnerabilities, and have exceeded it here. If you're unable to look into this soon, could you please find another owner or remove yourself so that this gets back into the security triage queue?

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Te-NeedsFurtherTriage TE-NeedsfurtherTriage
kenrb: any updates on this? Thanks!
Status: Started (was: Assigned)
Components: Security>Audit
Labels: Type-Bug
Removing from the security sheriff queue.

Comment 23 by kenrb@chromium.org, May 14 2018

Status: WontFix (was: Started)
I believe this code has been reasonably verified in the intervening 2 years, including some attention by Project Zero.

Sign in to add a comment