[Bulk edit]

Release blockers need OS set.  Looks like all of these are applicable for OS-All, correct if required.

This issue is set as M52 Release block Stable. Is there anything which needs to to be taken care in M52? Please resolve ASAP.

Assigning to Daniel as per offline conversation.Work is in progress and ship with M52 Stable.

M52 Pre-stable promotion is planned during July 2-nd week, please plan accordingly.

Bulk edit: swapping issues for mojo reviews back to Security_Impact-Stable. We're adding a sheriffbot rule to automatically remove release block labels from Security_Impact-None bugs, but in this case I think they make sense. These issues for audits/reviews tend to be a bit awkward to triage.

dcheng: Uh oh! This issue still open and hasn't been updated in the last 39 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

** IMPORTANT change in M52 merge date due to first 2 weeks of July no release weeks **
M52 Stable is launching very soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged ASAP. All changes MUST be merged into the release branch by 5pm on July 1 to make into the desktop Stable final build cut. Thank you!

rickyz: Uh oh! This issue still open and hasn't been updated in the last 53 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

I went through this code, and while I do not know where this service is currently exposed, the implementation of the interface looks OK. The one bit of weirdness is that you can can delete a snapshot while there is still an iterator alive for it.

I couldn't any place in leveldb that explicitly forbids this, but looking at the implementation, the iterator only grabs a sequence number from the snapshot, so the worst that can happen afaict is older records that would have otherwise been returned are lost during a compaction. It is not clear whether the safety of these operations is guaranteed for future versions of leveldb though.

I only looked at the implementation of the interfaces in leveldb.mojom - I assume the virtual filesystem code (which is presumably where access control to different dbs would happen) has been covered in separate reviews.

Security_Impact-None per #14

This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot