New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 611955 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Security

Blocking:
issue 611905



Sign in to add a comment

//components/filesystem/public/interfaces/*.mojom files need security review

Project Member Reported by dcheng@chromium.org, May 14 2016

Issue description

These interfaces don't appear to have gone through security review. Marking ReleaseBlock-Stable to be on the safe side for now.
 

Comment 1 by dcheng@chromium.org, May 14 2016

Summary: //components/filesystem/public/interfaces/*.mojom files need security review (was: filesystem/public/interfaces/*.mojom files need security review)
Labels: Security_Severity-High Security_Impact-None
Labels: OS-All
[Bulk edit]

Release blockers need OS set.  Looks like all of these are applicable for OS-All, correct if required.
This issue is set as M52 Release block Stable. Is there anything which needs to to be taken care in M52? Please resolve ASAP.
Owner: dcheng@chromium.org
Status: Assigned (was: Available)
Assigning to Daniel as per offline conversation.Work is in progress and ship with M52 Stable.

M52 Pre-stable promotion is planned during July 2-nd week, please plan accordingly.

Comment 6 Deleted

Labels: -Security_Impact-None Security_Impact-Stable
Bulk edit: swapping issues for mojo reviews back to Security_Impact-Stable. We're adding a sheriffbot rule to automatically remove release block labels from Security_Impact-None bugs, but in this case I think they make sense. These issues for audits/reviews tend to be a bit awkward to triage.
Project Member

Comment 8 by sheriffbot@chromium.org, Jun 22 2016

dcheng: Uh oh! This issue still open and hasn't been updated in the last 39 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: Internals>Mojo

Comment 10 Deleted

** IMPORTANT change in M52 merge date due to first 2 weeks of July no release weeks **
M52 Stable is launching very soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged ASAP. All changes MUST be merged into the release branch by 5pm on July 1 to make into the desktop Stable final build cut. Thank you!

Labels: -ReleaseBlock-Stable
Cc: dcheng@chromium.org
Owner: mea...@chromium.org
Project Member

Comment 14 by sheriffbot@chromium.org, Jul 6 2016

meacer: Uh oh! This issue still open and hasn't been updated in the last 53 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Te-NeedsFurtherTriage
Project Member

Comment 16 by sheriffbot@chromium.org, Jul 13 2016

Labels: Deadline-Exceeded
We commit ourselves to a 60 day deadline for fixing for high severity vulnerabilities, and have exceeded it here. If you're unable to look into this soon, could you please find another owner or remove yourself so that this gets back into the security triage queue?

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Te-NeedsFurtherTriage TE-NeedsfurtherTriage
meacer: any updates on this?
Project Member

Comment 18 by sheriffbot@chromium.org, Aug 11 2016

Labels: Merge-Request-53

Comment 19 by dimu@chromium.org, Aug 12 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Please merge your change by 5:00 PM PT today (latest by 5:00 PM PT Monday) so we can take it in for next week Beta release. Thank you.
Cc: gov...@chromium.org
Monorail seems to have eaten my previous update:

The interfaces LGTM. Though, there are some TODOs to clarify behavior with unsupported flags and such. It would nice to fix/document those properly.
I should also note that I didn't review the implementations.


govind: There isn't anything to merge here, should I simply set the merged label?
Labels: -Merge-Approved-53
Removing "Merge-Approved-53" label per comment #21. 
Thanks!
Labels: -Hotlist-Merge-Approved
Project Member

Comment 25 by sheriffbot@chromium.org, Oct 1 2016

Labels: Restrict-View-SecurityNotify
Project Member

Comment 26 by sheriffbot@chromium.org, Nov 15 2016

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment