New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 611939 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Moblab setup page could not save

Project Member Reported by ntang@google.com, May 14 2016

Issue description

I just tried the top of the tree. The moblab steup page save failed with the following error:
ValueError: too many values to unpack
Traceback (most recent call last):
  File "/usr/local/autotest/frontend/afe/json_rpc/serviceHandler.py", line 114, in dispatchRequest
    results['result'] = self.invokeServiceEndpoint(meth, args)
  File "/usr/local/autotest/frontend/afe/json_rpc/serviceHandler.py", line 154, in invokeServiceEndpoint
    return meth(*args)
  File "/usr/local/autotest/frontend/afe/rpc_handler.py", line 125, in new_fn
    return f(*args, **keyword_args)
  File "/usr/local/autotest/frontend/afe/site_rpc_interface.py", line 303, in verify
    return func(*args, **kwargs)
  File "/usr/local/autotest/frontend/afe/site_rpc_interface.py", line 405, in update_config_handler
    for key, value in config_value_list:
ValueError: too many values to unpack

To reproduce, just modify any value and try to save.
 

Comment 1 by ntang@google.com, May 14 2016

Owner: ntang@chromium.org
Seems it is caused by recently OOBE code change. I will fix it now. This will block M51

Comment 2 by krk@chromium.org, May 14 2016

Labels: ReleaseBlock-Stable M51

Comment 3 by ntang@google.com, May 16 2016

Labels: Merge-Request-51

Comment 4 by gov...@chromium.org, May 16 2016

Please specify OSs affected by this bug. Thank you.

Comment 5 by ntang@google.com, May 16 2016

Labels: OS-Windows

Comment 6 Deleted

Comment 7 by ntang@google.com, May 16 2016

Labels: -OS-Windows OS-Chrome
Only apply to chromeos on moblab device (guado-moblab)
Project Member

Comment 8 by bugdroid1@chromium.org, May 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e5653cf6ce7fa70458eb2e5ddf4bd784a0240983

commit e5653cf6ce7fa70458eb2e5ddf4bd784a0240983
Author: Michael Tang <ntang@google.com>
Date: Sat May 14 04:29:00 2016

Fixed the moblab setup save.

BUG= chromium:611939 
TEST=manual tested

Change-Id: If0f8d93463a1968f2d40e77d1990c61191c3bb43
Reviewed-on: https://chromium-review.googlesource.com/344638
Commit-Ready: Michael Tang <ntang@chromium.org>
Tested-by: Michael Tang <ntang@chromium.org>
Reviewed-by: Stephen Lin <stephenlin@google.com>
Reviewed-by: Michael Tang <ntang@chromium.org>

[modify] https://crrev.com/e5653cf6ce7fa70458eb2e5ddf4bd784a0240983/frontend/client/src/autotest/moblab/ConfigSettingsView.java

Labels: -Merge-Request-51 Merge-Approved-51
Labels: -M51 M-51

Comment 11 by ntang@google.com, May 16 2016

Status: Fixed (was: Untriaged)
Project Member

Comment 12 by bugdroid1@chromium.org, May 17 2016

Labels: merge-merged-release-R51-8172.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1745de6a1789fbca8851a6344a5209a49eea0c04

commit 1745de6a1789fbca8851a6344a5209a49eea0c04
Author: Michael Tang <ntang@google.com>
Date: Sat May 14 04:29:00 2016

Fixed the moblab setup save.

BUG= chromium:611939 
TEST=manual tested

Change-Id: If0f8d93463a1968f2d40e77d1990c61191c3bb43
Reviewed-on: https://chromium-review.googlesource.com/344638
Commit-Ready: Michael Tang <ntang@chromium.org>
Tested-by: Michael Tang <ntang@chromium.org>
Reviewed-by: Stephen Lin <stephenlin@google.com>
Reviewed-by: Michael Tang <ntang@chromium.org>
(cherry picked from commit e5653cf6ce7fa70458eb2e5ddf4bd784a0240983)
Reviewed-on: https://chromium-review.googlesource.com/344806
Reviewed-by: Krk Mohan <krk@google.com>
Commit-Queue: Michael Tang <ntang@chromium.org>
Trybot-Ready: Michael Tang <ntang@chromium.org>

[modify] https://crrev.com/1745de6a1789fbca8851a6344a5209a49eea0c04/frontend/client/src/autotest/moblab/ConfigSettingsView.java

Project Member

Comment 13 by sheriffbot@chromium.org, May 20 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 14 by ntang@google.com, May 20 2016

Labels: -Merge-Approved-51
Labels: VerifyIn-54

Comment 16 by ka...@chromium.org, Aug 31 2016

Labels: Bulk-Verified
Status: Verified (was: Fixed)

Sign in to add a comment