New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 611938 link

Starred by 5 users
Status: Started
Owner:
staphany@chromium.org
Cc:
█ ananta@chromium.org
jsb...@chromium.org
pwnall@chromium.org
esprehn@chromium.org
Components:
EstimatedDays: 30
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: Task

Blocked on:
issue 611909
issue 715632
Blocking:
issue 598069



Sign in to add a comment

Content Modularization Project: AppCache

Project Member Reported by jam@chromium.org, May 14 2016 
Tracking bug for the quota part of the Content Modularization Project.

Some task items:
-convert existing IPCs to mojo
-consume quota through its new mojo interface (see  bug 611909 )
-change how it hooks into network layer by implementing new mojo interfaces (to be spec’d, see  bug 611897 )
-move browser-side code from content/browser to components/appcache per intent to get rid of content
-separate from rest of browser code so that it can eventually run in the profile process (no reason for it to run unsandboxed)

Comment 1 by jam@chromium.org, May 16 2016

Cc: michaeln@chromium.org jsb...@chromium.org

Comment 2 by jam@chromium.org, May 16 2016

Blockedon: 611909

Comment 3 by jam@chromium.org, Apr 26 2017

Cc: ananta@chromium.org

Comment 4 by jam@chromium.org, Apr 26 2017

Blockedon: 715632

Comment 5 by jsb...@chromium.org, May 22 2017

Components: Blink>Storage>AppCache
Labels: OS-Chrome

Comment 6 by jsb...@chromium.org, May 22 2017

Labels: -Type-Bug Type-Feature

Comment 7 by jsb...@chromium.org, May 22 2017

Status: Available (was: Untriaged)

Comment 8 by slangley@chromium.org, Nov 6 2017

Components: Blink>Internals>Modularization

Comment 9 by laforge@google.com, Nov 7 2017

Components: Internals>Services
Labels: Type-Task
Appending component Internals>Services to S13N projects and changing the Type (for tracking sake) to Type=Task.

Comment 10 by lafo...@chromium.org, Nov 8 2017

Components: Internals>Services>Storage

Comment 11 by nverne@chromium.org, Nov 27 2017

EstimatedDays: 30
Owner: nverne@chromium.org

Comment 12 by nverne@chromium.org, Nov 27 2017

Status: Started (was: Available)
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a13f0052711005e9f8a829c31d8c9691d5abb5b

commit 8a13f0052711005e9f8a829c31d8c9691d5abb5b
Author: Nicholas Verne <nverne@chromium.org>
Date: Fri Dec 01 00:39:19 2017

Starts the mojoification of AppCache.

First, convert all enums and structs used by existing IPCs to mojo

Next CL will define the Host and Renderer interfaces.

Bug: 611938
Change-Id: I689b7399ad903197073ca15763d73d5bfff3207f
Reviewed-on: https://chromium-review.googlesource.com/790174
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520772}
[modify] https://crrev.com/8a13f0052711005e9f8a829c31d8c9691d5abb5b/content/browser/appcache/appcache_dispatcher_host.cc
[modify] https://crrev.com/8a13f0052711005e9f8a829c31d8c9691d5abb5b/content/browser/appcache/appcache_frontend_proxy.cc
[modify] https://crrev.com/8a13f0052711005e9f8a829c31d8c9691d5abb5b/content/browser/appcache/appcache_group_unittest.cc
[modify] https://crrev.com/8a13f0052711005e9f8a829c31d8c9691d5abb5b/content/browser/appcache/appcache_host.cc
[modify] https://crrev.com/8a13f0052711005e9f8a829c31d8c9691d5abb5b/content/browser/appcache/appcache_host_unittest.cc
[modify] https://crrev.com/8a13f0052711005e9f8a829c31d8c9691d5abb5b/content/browser/appcache/appcache_update_job.cc
[modify] https://crrev.com/8a13f0052711005e9f8a829c31d8c9691d5abb5b/content/browser/appcache/appcache_update_job_unittest.cc
[modify] https://crrev.com/8a13f0052711005e9f8a829c31d8c9691d5abb5b/content/common/BUILD.gn
[add] https://crrev.com/8a13f0052711005e9f8a829c31d8c9691d5abb5b/content/common/appcache.mojom
[modify] https://crrev.com/8a13f0052711005e9f8a829c31d8c9691d5abb5b/content/common/appcache_interfaces.cc
[modify] https://crrev.com/8a13f0052711005e9f8a829c31d8c9691d5abb5b/content/common/appcache_interfaces.h
[modify] https://crrev.com/8a13f0052711005e9f8a829c31d8c9691d5abb5b/content/common/appcache_messages.h
[modify] https://crrev.com/8a13f0052711005e9f8a829c31d8c9691d5abb5b/content/public/common/BUILD.gn
[modify] https://crrev.com/8a13f0052711005e9f8a829c31d8c9691d5abb5b/content/public/common/appcache_info.h
[add] https://crrev.com/8a13f0052711005e9f8a829c31d8c9691d5abb5b/content/public/common/appcache_info.mojom
[modify] https://crrev.com/8a13f0052711005e9f8a829c31d8c9691d5abb5b/content/renderer/appcache/appcache_backend_proxy.cc
[modify] https://crrev.com/8a13f0052711005e9f8a829c31d8c9691d5abb5b/content/renderer/appcache/appcache_frontend_impl.cc
[modify] https://crrev.com/8a13f0052711005e9f8a829c31d8c9691d5abb5b/content/renderer/appcache/web_application_cache_host_impl.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6fa91e3433f22449843ea9d4b63a9ce46a08eeb

commit b6fa91e3433f22449843ea9d4b63a9ce46a08eeb
Author: Nicholas Verne <nverne@chromium.org>
Date: Thu Dec 07 21:56:56 2017

Converting AppCacheHostMsg IPCs to mojo.

AppCacheDispatcherHost now implements mojom::AppCacheBackend, the interface
adapted from the old AppCacheHostMsg IPCs.

The follow-on CL implements the messages in the opposite direction. Until
that CL is submitted, AppCacheDispatcherHost needs to delegate Send() calls
to the provided IPC::Sender, and these calls need to thread hop from the
IO thread to the UI thread without leaking the IPC::Message if those tasks
fail to run.

Bug: 611938
Change-Id: I3a69783da5c3bcbe99b8a2c21f5f9c0a5c934e32
Reviewed-on: https://chromium-review.googlesource.com/798953
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522566}
[modify] https://crrev.com/b6fa91e3433f22449843ea9d4b63a9ce46a08eeb/content/browser/appcache/appcache_backend_impl.cc
[modify] https://crrev.com/b6fa91e3433f22449843ea9d4b63a9ce46a08eeb/content/browser/appcache/appcache_backend_impl.h
[modify] https://crrev.com/b6fa91e3433f22449843ea9d4b63a9ce46a08eeb/content/browser/appcache/appcache_dispatcher_host.cc
[modify] https://crrev.com/b6fa91e3433f22449843ea9d4b63a9ce46a08eeb/content/browser/appcache/appcache_dispatcher_host.h
[modify] https://crrev.com/b6fa91e3433f22449843ea9d4b63a9ce46a08eeb/content/browser/appcache/appcache_host.cc
[modify] https://crrev.com/b6fa91e3433f22449843ea9d4b63a9ce46a08eeb/content/browser/appcache/appcache_host.h
[modify] https://crrev.com/b6fa91e3433f22449843ea9d4b63a9ce46a08eeb/content/browser/appcache/appcache_host_unittest.cc
[modify] https://crrev.com/b6fa91e3433f22449843ea9d4b63a9ce46a08eeb/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/b6fa91e3433f22449843ea9d4b63a9ce46a08eeb/content/common/appcache.mojom
[modify] https://crrev.com/b6fa91e3433f22449843ea9d4b63a9ce46a08eeb/content/common/appcache_messages.h
[modify] https://crrev.com/b6fa91e3433f22449843ea9d4b63a9ce46a08eeb/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/b6fa91e3433f22449843ea9d4b63a9ce46a08eeb/content/renderer/appcache/appcache_backend_proxy.cc
[modify] https://crrev.com/b6fa91e3433f22449843ea9d4b63a9ce46a08eeb/content/renderer/appcache/appcache_backend_proxy.h
Project Member

Comment 15 by bugdroid1@chromium.org, Dec 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07e9c6450b5c4edf38c028e1abc54c45e39defb5

commit 07e9c6450b5c4edf38c028e1abc54c45e39defb5
Author: Nicholas Verne <nverne@chromium.org>
Date: Wed Dec 13 04:12:55 2017

Implements mojom::AppCacheFrontend for appcache messages sent from host to
the renderer.

As a result of this, several intermediate classes that passed MojoPipeHandle
over IPC now pass the URLLoaderFactoryPtr over mojo. Also,
AppCacheDispatcherHost no longer needs to be an IPC::Sender.

Further simplifications of the AppCache class hierarchy should now be possible,
but are out of scope for this CL.

Bug: 611938
Change-Id: I5c05f66fbbab0dc4a2afa1aa6979b2ba0ff4f1f4
Reviewed-on: https://chromium-review.googlesource.com/810345
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523682}
[modify] https://crrev.com/07e9c6450b5c4edf38c028e1abc54c45e39defb5/content/browser/appcache/appcache_dispatcher_host.cc
[modify] https://crrev.com/07e9c6450b5c4edf38c028e1abc54c45e39defb5/content/browser/appcache/appcache_dispatcher_host.h
[modify] https://crrev.com/07e9c6450b5c4edf38c028e1abc54c45e39defb5/content/browser/appcache/appcache_frontend_proxy.cc
[modify] https://crrev.com/07e9c6450b5c4edf38c028e1abc54c45e39defb5/content/browser/appcache/appcache_frontend_proxy.h
[modify] https://crrev.com/07e9c6450b5c4edf38c028e1abc54c45e39defb5/content/browser/appcache/appcache_group_unittest.cc
[modify] https://crrev.com/07e9c6450b5c4edf38c028e1abc54c45e39defb5/content/browser/appcache/appcache_host.cc
[modify] https://crrev.com/07e9c6450b5c4edf38c028e1abc54c45e39defb5/content/browser/appcache/appcache_host_unittest.cc
[modify] https://crrev.com/07e9c6450b5c4edf38c028e1abc54c45e39defb5/content/browser/appcache/appcache_navigation_handle_core.cc
[modify] https://crrev.com/07e9c6450b5c4edf38c028e1abc54c45e39defb5/content/browser/appcache/appcache_navigation_handle_core.h
[modify] https://crrev.com/07e9c6450b5c4edf38c028e1abc54c45e39defb5/content/browser/appcache/appcache_request_handler_unittest.cc
[modify] https://crrev.com/07e9c6450b5c4edf38c028e1abc54c45e39defb5/content/browser/appcache/appcache_storage_impl_unittest.cc
[modify] https://crrev.com/07e9c6450b5c4edf38c028e1abc54c45e39defb5/content/browser/appcache/appcache_unittest.cc
[modify] https://crrev.com/07e9c6450b5c4edf38c028e1abc54c45e39defb5/content/browser/appcache/appcache_update_job_unittest.cc
[modify] https://crrev.com/07e9c6450b5c4edf38c028e1abc54c45e39defb5/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/07e9c6450b5c4edf38c028e1abc54c45e39defb5/content/common/BUILD.gn
[modify] https://crrev.com/07e9c6450b5c4edf38c028e1abc54c45e39defb5/content/common/appcache.mojom
[modify] https://crrev.com/07e9c6450b5c4edf38c028e1abc54c45e39defb5/content/common/appcache_interfaces.h
[delete] https://crrev.com/b50bae8d0708d3fad311fcf58a8ad320d0164cdd/content/common/appcache_messages.h
[modify] https://crrev.com/07e9c6450b5c4edf38c028e1abc54c45e39defb5/content/common/content_message_generator.h
[modify] https://crrev.com/07e9c6450b5c4edf38c028e1abc54c45e39defb5/content/public/app/mojo/content_renderer_manifest.json
[modify] https://crrev.com/07e9c6450b5c4edf38c028e1abc54c45e39defb5/content/renderer/appcache/appcache_backend_proxy.cc
[modify] https://crrev.com/07e9c6450b5c4edf38c028e1abc54c45e39defb5/content/renderer/appcache/appcache_backend_proxy.h
[modify] https://crrev.com/07e9c6450b5c4edf38c028e1abc54c45e39defb5/content/renderer/appcache/appcache_dispatcher.cc
[modify] https://crrev.com/07e9c6450b5c4edf38c028e1abc54c45e39defb5/content/renderer/appcache/appcache_dispatcher.h
[modify] https://crrev.com/07e9c6450b5c4edf38c028e1abc54c45e39defb5/content/renderer/appcache/appcache_frontend_impl.cc
[modify] https://crrev.com/07e9c6450b5c4edf38c028e1abc54c45e39defb5/content/renderer/appcache/appcache_frontend_impl.h
[modify] https://crrev.com/07e9c6450b5c4edf38c028e1abc54c45e39defb5/content/renderer/appcache/web_application_cache_host_impl.h
[modify] https://crrev.com/07e9c6450b5c4edf38c028e1abc54c45e39defb5/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/07e9c6450b5c4edf38c028e1abc54c45e39defb5/content/renderer/renderer_webapplicationcachehost_impl.cc
[modify] https://crrev.com/07e9c6450b5c4edf38c028e1abc54c45e39defb5/content/renderer/renderer_webapplicationcachehost_impl.h

Comment 16 by nverne@chromium.org, Dec 13 2017

Owner: jsb...@chromium.org
At this point I'll hand back to AppCache owners.

It looks like AppCache{Frontend,Backend}Proxy, AppCacheDispatcher easily can be removed easily.
As kenrb@ observed, it should also be possible to remove appcache_interfaces.h

Comment 17 by jsb...@chromium.org, Jan 6 2018

Owner: ----
Status: Available (was: Started)
Removing my name just to make it clear I'm not actively working on this. Hopefully we'll get to it soon.

Comment 18 by pwnall@chromium.org, Dec 29

Cc: -michaeln@chromium.org pwnall@chromium.org
Labels: OS-Android OS-Fuchsia OS-Linux OS-Mac OS-Windows
Owner: staphany@chromium.org
Status: Started (was: Available)
staphany@ will attempt to tackle this as a way to get introduced to the architecture of a web platform feature.
Project Member

Comment 19 by bugdroid1@chromium.org, Dec 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f76c062efdc9efd9a58b3fabd3f72c04e14e15bc

commit f76c062efdc9efd9a58b3fabd3f72c04e14e15bc
Author: Victor Costan <pwnall@chromium.org>
Date: Sat Dec 29 08:59:16 2018

AppCache: Add myself to OWNERS for AppCache files in blink/public/.

Bug: 611938
Change-Id: Ic207e36949aaf8cbf04a34d4dd498613a6dcaaa8
Reviewed-on: https://chromium-review.googlesource.com/c/1392491
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619236}
[modify] https://crrev.com/f76c062efdc9efd9a58b3fabd3f72c04e14e15bc/third_party/blink/public/platform/OWNERS
Project Member

Comment 20 by bugdroid1@chromium.org, Dec 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb07d3f78faf36226dc63e6a31e6e866871ba7c9

commit bb07d3f78faf36226dc63e6a31e6e866871ba7c9
Author: Victor Costan <pwnall@chromium.org>
Date: Sun Dec 30 20:01:33 2018

AppCache: Add myself as an OWNER for AppCache files in content/common.

This will facilitate AppCache Onion Souping reviews.

Bug: 611938
Change-Id: Ifa8ca2899855584e1c400ada364618b259744bd5
Reviewed-on: https://chromium-review.googlesource.com/c/1392282
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619282}
[modify] https://crrev.com/bb07d3f78faf36226dc63e6a31e6e866871ba7c9/content/common/OWNERS
Project Member

Comment 21 by bugdroid1@chromium.org, Dec 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1db234fd115c81674f4bfdb119381fe922d091f8

commit 1db234fd115c81674f4bfdb119381fe922d091f8
Author: Victor Costan <pwnall@chromium.org>
Date: Sun Dec 30 20:05:33 2018

AppCache: Add myself to OWNERS for AppCache files in content/renderer.

Bug: 611938
Change-Id: I4c1d6a30937cb20ae92ca44996f8bff61d2776c9
Reviewed-on: https://chromium-review.googlesource.com/c/1392253
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619283}
[modify] https://crrev.com/1db234fd115c81674f4bfdb119381fe922d091f8/content/renderer/OWNERS
Project Member

Comment 22 by bugdroid1@chromium.org, Dec 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63031815340155a2e1d0a34470c307109926b1f3

commit 63031815340155a2e1d0a34470c307109926b1f3
Author: Victor Costan <pwnall@chromium.org>
Date: Sun Dec 30 22:47:05 2018

AppCache: Remove AppCacheBackend from appcache_interfaces.h.

The interface has a single implementation in content/renderer. This CL
removes the interface and updates the content/renderer code to refer
directly to the implementation class.

TBR=jsbell

Bug: 611938
Change-Id: I2777386c33662f973d5e6ec2bde3fe4091cd62ea
Reviewed-on: https://chromium-review.googlesource.com/c/1392285
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619285}
[modify] https://crrev.com/63031815340155a2e1d0a34470c307109926b1f3/content/common/appcache_interfaces.h
[modify] https://crrev.com/63031815340155a2e1d0a34470c307109926b1f3/content/renderer/appcache/appcache_backend_proxy.h
[modify] https://crrev.com/63031815340155a2e1d0a34470c307109926b1f3/content/renderer/appcache/web_application_cache_host_impl.cc
[modify] https://crrev.com/63031815340155a2e1d0a34470c307109926b1f3/content/renderer/appcache/web_application_cache_host_impl.h
[modify] https://crrev.com/63031815340155a2e1d0a34470c307109926b1f3/content/renderer/renderer_webapplicationcachehost_impl.cc
[modify] https://crrev.com/63031815340155a2e1d0a34470c307109926b1f3/content/renderer/renderer_webapplicationcachehost_impl.h
Project Member

Comment 23 by bugdroid1@chromium.org, Jan 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24d3b791b213980f68c3ef2cd27edacdd498d3dc

commit 24d3b791b213980f68c3ef2cd27edacdd498d3dc
Author: Staphany Park <staphany@chromium.org>
Date: Fri Jan 04 20:51:39 2019

AppCache: Remove AppCacheDispatcher from content/renderer.

AppCacheDispatcher just proxied into AppCacheFrontendImpl, so the 2
classes can be merged into 1 class that implements the
mojom::AppCacheFrontend interface. Removing this layer of indirection
contributes to onion-souping content/renderer/appcache.

Bug: 611938
Change-Id: I604c4e90c0503df9bc0a2d7f0ddcb2296b57e824
Reviewed-on: https://chromium-review.googlesource.com/c/1392497
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Staphany Park <staphany@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620059}
[modify] https://crrev.com/24d3b791b213980f68c3ef2cd27edacdd498d3dc/content/renderer/BUILD.gn
[delete] https://crrev.com/29f5f4ab91c4626283c9755d929d48ffe30a74a8/content/renderer/appcache/appcache_dispatcher.cc
[delete] https://crrev.com/29f5f4ab91c4626283c9755d929d48ffe30a74a8/content/renderer/appcache/appcache_dispatcher.h
[modify] https://crrev.com/24d3b791b213980f68c3ef2cd27edacdd498d3dc/content/renderer/appcache/appcache_frontend_impl.cc
[modify] https://crrev.com/24d3b791b213980f68c3ef2cd27edacdd498d3dc/content/renderer/appcache/appcache_frontend_impl.h
[modify] https://crrev.com/24d3b791b213980f68c3ef2cd27edacdd498d3dc/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/24d3b791b213980f68c3ef2cd27edacdd498d3dc/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/24d3b791b213980f68c3ef2cd27edacdd498d3dc/content/renderer/render_thread_impl.h
[modify] https://crrev.com/24d3b791b213980f68c3ef2cd27edacdd498d3dc/content/renderer/render_view_impl.cc
[modify] https://crrev.com/24d3b791b213980f68c3ef2cd27edacdd498d3dc/content/renderer/shared_worker/embedded_shared_worker_stub.cc
Project Member

Comment 24 by bugdroid1@chromium.org, Jan 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e8342ad0888491901d21b77e54d44c6a41ff079

commit 6e8342ad0888491901d21b77e54d44c6a41ff079
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Mon Jan 07 05:50:15 2019

AppCache: remove unused hooks for main resource

Also inline DocumentLoader::ProcessData, which
is now equivalent to CommitData.

Bug: 611938
Change-Id: If6e0949fb96b804e92b0769630e2202ac85e95ee
Reviewed-on: https://chromium-review.googlesource.com/c/1392506
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620256}
[modify] https://crrev.com/6e8342ad0888491901d21b77e54d44c6a41ff079/content/renderer/appcache/web_application_cache_host_impl.cc
[modify] https://crrev.com/6e8342ad0888491901d21b77e54d44c6a41ff079/content/renderer/appcache/web_application_cache_host_impl.h
[modify] https://crrev.com/6e8342ad0888491901d21b77e54d44c6a41ff079/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/6e8342ad0888491901d21b77e54d44c6a41ff079/third_party/blink/public/platform/web_application_cache_host.h
[modify] https://crrev.com/6e8342ad0888491901d21b77e54d44c6a41ff079/third_party/blink/renderer/core/loader/appcache/application_cache_host.cc
[modify] https://crrev.com/6e8342ad0888491901d21b77e54d44c6a41ff079/third_party/blink/renderer/core/loader/appcache/application_cache_host.h
[modify] https://crrev.com/6e8342ad0888491901d21b77e54d44c6a41ff079/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/6e8342ad0888491901d21b77e54d44c6a41ff079/third_party/blink/renderer/core/loader/document_loader.h
Project Member

Comment 25 by bugdroid1@chromium.org, Jan 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b57b9b71a3ea9379648195e03ba1aa7894f6f16

commit 4b57b9b71a3ea9379648195e03ba1aa7894f6f16
Author: Staphany Park <staphany@chromium.org>
Date: Mon Jan 07 06:22:34 2019

AppCache: Remove AppCacheBackendProxy from content/renderer.

Bug: 611938
Change-Id: I138a93e298c46c0ad4fa6952b3a829ffeb6b04fd
Reviewed-on: https://chromium-review.googlesource.com/c/1395569
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620262}
[modify] https://crrev.com/4b57b9b71a3ea9379648195e03ba1aa7894f6f16/content/renderer/BUILD.gn
[delete] https://crrev.com/d2f45c9d8224fa3f3ec3b81413b1468514beb862/content/renderer/appcache/appcache_backend_proxy.cc
[delete] https://crrev.com/d2f45c9d8224fa3f3ec3b81413b1468514beb862/content/renderer/appcache/appcache_backend_proxy.h
[modify] https://crrev.com/4b57b9b71a3ea9379648195e03ba1aa7894f6f16/content/renderer/appcache/appcache_frontend_impl.cc
[modify] https://crrev.com/4b57b9b71a3ea9379648195e03ba1aa7894f6f16/content/renderer/appcache/appcache_frontend_impl.h
[modify] https://crrev.com/4b57b9b71a3ea9379648195e03ba1aa7894f6f16/content/renderer/appcache/web_application_cache_host_impl.cc
[modify] https://crrev.com/4b57b9b71a3ea9379648195e03ba1aa7894f6f16/content/renderer/appcache/web_application_cache_host_impl.h
[modify] https://crrev.com/4b57b9b71a3ea9379648195e03ba1aa7894f6f16/content/renderer/renderer_webapplicationcachehost_impl.cc
[modify] https://crrev.com/4b57b9b71a3ea9379648195e03ba1aa7894f6f16/content/renderer/renderer_webapplicationcachehost_impl.h

Comment 26 by jsb...@chromium.org, Jan 7 

Thanks for picking this up, staphany@!

Comment 27 by pwnall@chromium.org, Jan 7

Components: -Internals>Services>Storage Internals>Storage
The Storage team monitors Internals>Storage. The Internals>Services>Storage label will be deprecated & removed.
Project Member

Comment 28 by bugdroid1@chromium.org, Jan 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e0954887d8522df1d543249416f3851f6e46121

commit 5e0954887d8522df1d543249416f3851f6e46121
Author: Staphany Park <staphany@chromium.org>
Date: Mon Jan 14 20:18:28 2019

AppCache: Move mojom files into blink.

These mojom files define enums that get duplicated across 1-2 layers.
Moving these enums directly into blink is a precursor to deleting the
duplicates.

Bug: 611938
Change-Id: I78fbc4b6d1b6d87c97a58c0ef1dc119536e76f33
Reviewed-on: https://chromium-review.googlesource.com/c/1405593
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Staphany Park <staphany@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622574}
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/chrome/browser/browsing_data/browsing_data_appcache_helper.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/chrome/browser/browsing_data/cookies_tree_model.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/chrome/browser/browsing_data/cookies_tree_model.h
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/chrome/browser/browsing_data/local_data_container.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/chrome/browser/browsing_data/local_data_container.h
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/chrome/browser/browsing_data/mock_browsing_data_appcache_helper.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/chrome/browser/ui/webui/cookies_tree_model_util.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache.h
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_backend_impl.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_backend_impl.h
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_dispatcher_host.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_dispatcher_host.h
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_entry.h
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_frontend_proxy.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_frontend_proxy.h
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_fuzzer.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_fuzzer.proto
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_group_unittest.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_host.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_host.h
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_host_unittest.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_interceptor.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_internals_ui.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_internals_ui.h
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_navigation_handle_core.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_navigation_handle_core.h
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_request_handler.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_request_handler_unittest.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_response.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_service_unittest.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_storage_impl.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_storage_impl_unittest.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_unittest.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_update_job.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_update_job.h
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_update_job_unittest.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_url_loader_job.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_url_request_job.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_url_request_job_unittest.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/appcache_working_set.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/chrome_appcache_service.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/chrome_appcache_service.h
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/mock_appcache_storage.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/mock_appcache_storage.h
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/appcache/mock_appcache_storage_unittest.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/common/BUILD.gn
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/common/appcache_interfaces.h
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/public/app/mojo/content_renderer_manifest.json
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/public/common/BUILD.gn
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/public/common/appcache_info.h
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/renderer/appcache/appcache_frontend_impl.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/renderer/appcache/appcache_frontend_impl.h
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/renderer/appcache/web_application_cache_host_impl.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/renderer/appcache/web_application_cache_host_impl.h
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/renderer/renderer_webapplicationcachehost_impl.cc
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/content/renderer/renderer_webapplicationcachehost_impl.h
[modify] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/third_party/blink/public/mojom/BUILD.gn
[add] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/third_party/blink/public/mojom/appcache/OWNERS
[rename] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/third_party/blink/public/mojom/appcache/appcache.mojom
[rename] https://crrev.com/5e0954887d8522df1d543249416f3851f6e46121/third_party/blink/public/mojom/appcache/appcache_info.mojom
Project Member

Comment 29 by bugdroid1@chromium.org, Jan 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/606d8ed19181f275a074bfab3f094620c603face

commit 606d8ed19181f275a074bfab3f094620c603face
Author: Staphany Park <staphany@chromium.org>
Date: Tue Jan 15 05:47:46 2019

AppCache: Delete duplicated enums in blink.

The AppCacheStatus, AppCachEventID, and AppCacheErrorReason enums
defined in mojo are duplicated across several layers within blink.
Replacing usage of those copies to use the mojo versions contributes to
Onion Souping AppCache.

Bug: 611938
Change-Id: I731bf90cc78209ce3858f4457105e8737e23461f
Reviewed-on: https://chromium-review.googlesource.com/c/1408219
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Staphany Park <staphany@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622753}
[modify] https://crrev.com/606d8ed19181f275a074bfab3f094620c603face/content/renderer/appcache/appcache_frontend_impl.cc
[modify] https://crrev.com/606d8ed19181f275a074bfab3f094620c603face/content/renderer/appcache/web_application_cache_host_impl.cc
[modify] https://crrev.com/606d8ed19181f275a074bfab3f094620c603face/content/renderer/appcache/web_application_cache_host_impl.h
[modify] https://crrev.com/606d8ed19181f275a074bfab3f094620c603face/third_party/blink/public/platform/web_application_cache_host.h
[modify] https://crrev.com/606d8ed19181f275a074bfab3f094620c603face/third_party/blink/public/platform/web_application_cache_host_client.h
[modify] https://crrev.com/606d8ed19181f275a074bfab3f094620c603face/third_party/blink/renderer/core/events/application_cache_error_event.cc
[modify] https://crrev.com/606d8ed19181f275a074bfab3f094620c603face/third_party/blink/renderer/core/events/application_cache_error_event.h
[modify] https://crrev.com/606d8ed19181f275a074bfab3f094620c603face/third_party/blink/renderer/core/inspector/inspector_application_cache_agent.cc
[modify] https://crrev.com/606d8ed19181f275a074bfab3f094620c603face/third_party/blink/renderer/core/loader/appcache/application_cache.cc
[modify] https://crrev.com/606d8ed19181f275a074bfab3f094620c603face/third_party/blink/renderer/core/loader/appcache/application_cache.h
[modify] https://crrev.com/606d8ed19181f275a074bfab3f094620c603face/third_party/blink/renderer/core/loader/appcache/application_cache_host.cc
[modify] https://crrev.com/606d8ed19181f275a074bfab3f094620c603face/third_party/blink/renderer/core/loader/appcache/application_cache_host.h
Project Member

Comment 30 by bugdroid, Today (13 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0750356830c58226fd66bf48439d30275bffe904

commit 0750356830c58226fd66bf48439d30275bffe904
Author: Victor Costan <pwnall@chromium.org>
Date: Wed Jan 23 17:21:40 2019

appcache: Move AppCacheNamespace from content/common to content/browser.

AppCacheNamespace is only used in AppCache's browser-side
implementation. Having it in content/common/appcache_interfaces.h is
misleading, as it suggests that the class is shared with the renderer.

Bug: 611938
Change-Id: Iffcb77f27408f133c97417663d48d244f2a672bd
Reviewed-on: https://chromium-review.googlesource.com/c/1429246
Auto-Submit: Victor Costan <pwnall@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625240}
Project Member

Comment 31 by bugdroid, Today (12 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1255f3c58bfae11962aed0aa9ead7874ae1250cb

commit 1255f3c58bfae11962aed0aa9ead7874ae1250cb
Author: Victor Costan <pwnall@chromium.org>
Date: Wed Jan 23 23:10:48 2019

appcache: Move AppCacheFrontend from content/common to content/browser.

AppCacheFrontend is only used in AppCache's browser-side
implementation. Having it in content/common/appcache_interfaces.h is
misleading, as it suggests that the class is shared with the renderer.

Bug: 611938
Change-Id: I68865d63ee38841d59b61866664716c0ec8c2c39
Reviewed-on: https://chromium-review.googlesource.com/c/1429247
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625399}
►

Sign in to add a comment