The Android bots are failing Maps.maps_002 |
|||||
Issue descriptionAll of the Android bots are failing the Maps.maps_002 test.
,
May 14 2016
Issue 610034 has been merged into this issue.
,
May 14 2016
,
May 27 2016
,
May 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c329cfaedf7a947ea84e31e90c9112f4d64c3e24 commit c329cfaedf7a947ea84e31e90c9112f4d64c3e24 Author: kbr <kbr@chromium.org> Date: Fri May 27 19:55:11 2016 Update Maps pixel test. Pick up a new binary from the Maps team, and update the test expectations for a differently-sized viewport. It looks like the sizing of the canvas in this test is slightly different on Android than on desktop platforms, despite the fact that a fixed device pixel ratio is sent to the Maps test itself. Work around this by adding a mechanism to cloud_storage_test_base's test expectations for device-specific scale factors. The machine names are already being passed down to the test on the bots, so this will allow the same expectations to apply on all devices. Tested locally on a Nexus 6 and 9. Removed the failure expectations for this test (which has now been renamed to Maps.maps_004) on Android. The test will probably fail on the Nexus 5 and 5X, but scale factors will be checked in for these devices in a follow-on CL. BUG= 611932 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2010363002 Cr-Commit-Position: refs/heads/master@{#396541} [modify] https://crrev.com/c329cfaedf7a947ea84e31e90c9112f4d64c3e24/content/test/gpu/gpu_tests/cloud_storage_test_base.py [modify] https://crrev.com/c329cfaedf7a947ea84e31e90c9112f4d64c3e24/content/test/gpu/gpu_tests/maps.py [modify] https://crrev.com/c329cfaedf7a947ea84e31e90c9112f4d64c3e24/content/test/gpu/gpu_tests/maps_expectations.py [modify] https://crrev.com/c329cfaedf7a947ea84e31e90c9112f4d64c3e24/content/test/gpu/page_sets/PRESUBMIT.py [modify] https://crrev.com/c329cfaedf7a947ea84e31e90c9112f4d64c3e24/content/test/gpu/page_sets/data/maps.json [add] https://crrev.com/c329cfaedf7a947ea84e31e90c9112f4d64c3e24/content/test/gpu/page_sets/data/maps_004.wpr.sha1 [add] https://crrev.com/c329cfaedf7a947ea84e31e90c9112f4d64c3e24/content/test/gpu/page_sets/data/maps_004_expectations.json [modify] https://crrev.com/c329cfaedf7a947ea84e31e90c9112f4d64c3e24/tools/perf/page_sets/data/maps.json [add] https://crrev.com/c329cfaedf7a947ea84e31e90c9112f4d64c3e24/tools/perf/page_sets/data/maps_004.wpr.sha1 [modify] https://crrev.com/c329cfaedf7a947ea84e31e90c9112f4d64c3e24/tools/perf/page_sets/maps.py
,
May 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c195d7f3e42d49026f18cc15423f60fa428d710 commit 8c195d7f3e42d49026f18cc15423f60fa428d710 Author: kbr <kbr@chromium.org> Date: Fri May 27 23:56:03 2016 Specify --test-machine-name to maps_pixel_test running on bots. Neglected to verify that this was specified for maps_pixel_test rather than pixel_test. This caused the new test to fail on all of the Android bots rather than only two of them as originally planned. BUG= 611932 TBR=zmo@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2021533003 Cr-Commit-Position: refs/heads/master@{#396604} [modify] https://crrev.com/8c195d7f3e42d49026f18cc15423f60fa428d710/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/8c195d7f3e42d49026f18cc15423f60fa428d710/content/test/gpu/gpu_tests/cloud_storage_test_base.py [modify] https://crrev.com/8c195d7f3e42d49026f18cc15423f60fa428d710/content/test/gpu/page_sets/data/maps_004_expectations.json [modify] https://crrev.com/8c195d7f3e42d49026f18cc15423f60fa428d710/testing/buildbot/chromium.gpu.fyi.json [modify] https://crrev.com/8c195d7f3e42d49026f18cc15423f60fa428d710/testing/buildbot/chromium.gpu.json
,
May 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c897a8be1a506b7870a02da59b76aa3dda9dd63 commit 7c897a8be1a506b7870a02da59b76aa3dda9dd63 Author: kbr <kbr@chromium.org> Date: Sat May 28 02:01:59 2016 Add scale factors for maps_pixel_test on Nexus 5 and 5X. BUG= 611932 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel TBR=zmo@chromium.org, cblume@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2024493002 Cr-Commit-Position: refs/heads/master@{#396624} [modify] https://crrev.com/7c897a8be1a506b7870a02da59b76aa3dda9dd63/content/test/gpu/page_sets/data/maps_004_expectations.json
,
Jun 1 2016
The revised test, Maps.maps_004, is running reliably green on all four of the Android bots on the chromium.gpu.fyi waterfall: https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Debug%20(Nexus%205) https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Debug%20(Nexus%205X) https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Debug%20(Nexus%206) https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Debug%20(Nexus%209) Closing as fixed.
,
Jun 3 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by cblume@chromium.org
, May 14 2016