New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 611930 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 610951
issue 610023



Sign in to add a comment

Android GPU bots failing several GpuProcess tests

Project Member Reported by cblume@chromium.org, May 14 2016

Issue description

The following tests are failing on all of the Android bots:

GpuProcess.no_gpu_process
GpuProcess.identify_active_gpu1
GpuProcess.identify_active_gpu2
GpuProcess.identify_active_gpu3
GpuProcess.identify_active_gpu4
GpuProcess.readback_webgl_gpu_process
GpuProcess.driver_bug_workarounds_upon_gl_renderer

Previously,  crbug.com/610023  and crbug.com/610951 were filed for the Nexus 9 and Nexus 5X, respectively. Those include the above tests plus GpuProcess.skip_gpu_process.
 
Cc: j.iso...@samsung.com
Hi is there any public url that shows the errors ?

Comment 2 by cblume@chromium.org, May 19 2016

The logs get deleted after a certain amount of time, I think.
You may be able to find them at https://chromium-build.appspot.com/p/chromium/console on old builds for the Android bots under the GPU FYI waterfall.

A better method (which will be up to date) is to look at the test expectations on https://code.google.com/p/chromium/codesearch#chromium/src/content/test/gpu/gpu_tests/gpu_process_expectations.py&sq=package:chromium

You can remove one of these tests and then build and run the test locally to see it happening.

$ ninja -C out/Debug content_shell_apk
$ ./content/test/gpu/run_gpu_test.py gpu_process -v --browser android-content-shell

You'll find other tests which are failing in other files in that directory.
Owner: j.iso...@samsung.com
Status: Assigned (was: Untriaged)
I could reproduce all failures so I sorted out the problems with this CL https://codereview.chromium.org/2227893005/
(except GpuProcess.skip_gpu_process failure that I could not reproduce on a nexus 4) 
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2c5030470e9cee3ae35dc849c680530c2acf06a

commit a2c5030470e9cee3ae35dc849c680530c2acf06a
Author: j.isorce <j.isorce@samsung.com>
Date: Wed Aug 10 07:42:49 2016

Fix a few gpu tests on Android

Make GpuProcess.driver_bug_workarounds_upon_gl_renderer work on Android.

For other tests it does not make sense to run them on Android because
there is either no entry in kSoftwareRenderingListJson to trigger
or no multi gpu configuration.

About GpuProcess.skip_gpu_process, I could not reproduce the failure on
Nexus 4.

BUG= 611930 

R=kbr@chromium.org

TEST=./content/test/gpu/run_gpu_test.py gpu_process --browser android-content-shell
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2227893005
Cr-Commit-Position: refs/heads/master@{#410998}

[modify] https://crrev.com/a2c5030470e9cee3ae35dc849c680530c2acf06a/content/test/gpu/gpu_tests/gpu_process_expectations.py
[modify] https://crrev.com/a2c5030470e9cee3ae35dc849c680530c2acf06a/content/test/gpu/page_sets/gpu_process_tests.py
[modify] https://crrev.com/a2c5030470e9cee3ae35dc849c680530c2acf06a/gpu/config/gpu_info_collector_android.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/270f29a49ca7deb830a554e5ffefb46619e4c4e6

commit 270f29a49ca7deb830a554e5ffefb46619e4c4e6
Author: j.isorce <j.isorce@samsung.com>
Date: Wed Aug 10 16:54:36 2016

Revert of Fix a few gpu tests on Android (patchset #1 id:1 of https://codereview.chromium.org/2227893005/ )

Reason for revert:
Failing tests on Android https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%28Nexus%209%29/builds/1242

Original issue's description:
> Fix a few gpu tests on Android
>
> Make GpuProcess.driver_bug_workarounds_upon_gl_renderer work on Android.
>
> For other tests it does not make sense to run them on Android because
> there is either no entry in kSoftwareRenderingListJson to trigger
> or no multi gpu configuration.
>
> About GpuProcess.skip_gpu_process, I could not reproduce the failure on
> Nexus 4.
>
> BUG= 611930 
>
> R=kbr@chromium.org
>
> TEST=./content/test/gpu/run_gpu_test.py gpu_process --browser android-content-shell
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/a2c5030470e9cee3ae35dc849c680530c2acf06a
> Cr-Commit-Position: refs/heads/master@{#410998}

TBR=kbr@chromium.org,zmo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 611930 

Review-Url: https://codereview.chromium.org/2230803003
Cr-Commit-Position: refs/heads/master@{#411057}

[modify] https://crrev.com/270f29a49ca7deb830a554e5ffefb46619e4c4e6/content/test/gpu/gpu_tests/gpu_process_expectations.py
[modify] https://crrev.com/270f29a49ca7deb830a554e5ffefb46619e4c4e6/content/test/gpu/page_sets/gpu_process_tests.py
[modify] https://crrev.com/270f29a49ca7deb830a554e5ffefb46619e4c4e6/gpu/config/gpu_info_collector_android.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b34180e4f1fb9d4813b1e88984d288bd50b05751

commit b34180e4f1fb9d4813b1e88984d288bd50b05751
Author: j.isorce <j.isorce@samsung.com>
Date: Thu Aug 11 01:19:27 2016

Fix a few gpu tests on Android

Make GpuProcess.driver_bug_workarounds_upon_gl_renderer and
GpuProcess.no_gpu_process work on Android.

For other tests it does not make sense to run them on Android because
there is either no entry in kSoftwareRenderingListJson to trigger
or no multi gpu configuration.

About GpuProcess.skip_gpu_process, I could not reproduce the failure on
Nexus 4.

BUG= 611930 

R=kbr@chromium.org

TEST=./content/test/gpu/run_gpu_test.py gpu_process --browser android-content-shell
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/a2c5030470e9cee3ae35dc849c680530c2acf06a
Review-Url: https://codereview.chromium.org/2227893005
Cr-Original-Commit-Position: refs/heads/master@{#410998}
Cr-Commit-Position: refs/heads/master@{#411213}

[modify] https://crrev.com/b34180e4f1fb9d4813b1e88984d288bd50b05751/content/test/gpu/gpu_tests/gpu_process_expectations.py
[modify] https://crrev.com/b34180e4f1fb9d4813b1e88984d288bd50b05751/content/test/gpu/page_sets/gpu_process_tests.py
[modify] https://crrev.com/b34180e4f1fb9d4813b1e88984d288bd50b05751/gpu/config/gpu_info_collector_android.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d97a0320369d81f384a5675cec1ea50fee228855

commit d97a0320369d81f384a5675cec1ea50fee228855
Author: j.isorce <j.isorce@samsung.com>
Date: Thu Aug 11 14:00:15 2016

Revert of Fix a few gpu tests on Android (patchset #3 id:40001 of https://codereview.chromium.org/2227893005/ )

Reason for revert:
Better than yesterday but still not 100% ok, still failing one bot https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%28Nexus%209%29

Original issue's description:
> Fix a few gpu tests on Android
>
> Make GpuProcess.driver_bug_workarounds_upon_gl_renderer and
> GpuProcess.no_gpu_process work on Android.
>
> For other tests it does not make sense to run them on Android because
> there is either no entry in kSoftwareRenderingListJson to trigger
> or no multi gpu configuration.
>
> About GpuProcess.skip_gpu_process, I could not reproduce the failure on
> Nexus 4.
>
> BUG= 611930 
>
> R=kbr@chromium.org
>
> TEST=./content/test/gpu/run_gpu_test.py gpu_process --browser android-content-shell
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/a2c5030470e9cee3ae35dc849c680530c2acf06a
> Committed: https://crrev.com/b34180e4f1fb9d4813b1e88984d288bd50b05751
> Cr-Original-Commit-Position: refs/heads/master@{#410998}
> Cr-Commit-Position: refs/heads/master@{#411213}

TBR=kbr@chromium.org,zmo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 611930 

Review-Url: https://codereview.chromium.org/2232033003
Cr-Commit-Position: refs/heads/master@{#411319}

[modify] https://crrev.com/d97a0320369d81f384a5675cec1ea50fee228855/content/test/gpu/gpu_tests/gpu_process_expectations.py
[modify] https://crrev.com/d97a0320369d81f384a5675cec1ea50fee228855/content/test/gpu/page_sets/gpu_process_tests.py
[modify] https://crrev.com/d97a0320369d81f384a5675cec1ea50fee228855/gpu/config/gpu_info_collector_android.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47305c8a2024ae45a2ab870a1bf41f01a26c8ae5

commit 47305c8a2024ae45a2ab870a1bf41f01a26c8ae5
Author: j.isorce <j.isorce@samsung.com>
Date: Wed Aug 17 14:35:01 2016

Fix a few gpu tests on Android

Make GpuProcess.driver_bug_workarounds_upon_gl_renderer and
GpuProcess.no_gpu_process work on Android.

For other tests it does not make sense to run them on Android because
there is either no entry in kSoftwareRenderingListJson to trigger
or no multi gpu configuration.

About GpuProcess.skip_gpu_process, I could not reproduce the failure on
Nexus 4.

BUG= 611930 

R=kbr@chromium.org

TEST=./content/test/gpu/run_gpu_test.py gpu_process --browser android-content-shell
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/a2c5030470e9cee3ae35dc849c680530c2acf06a
Committed: https://crrev.com/b34180e4f1fb9d4813b1e88984d288bd50b05751
Review-Url: https://codereview.chromium.org/2227893005
Cr-Original-Original-Commit-Position: refs/heads/master@{#410998}
Cr-Original-Commit-Position: refs/heads/master@{#411213}
Cr-Commit-Position: refs/heads/master@{#412522}

[modify] https://crrev.com/47305c8a2024ae45a2ab870a1bf41f01a26c8ae5/content/test/gpu/gpu_tests/gpu_process_expectations.py
[modify] https://crrev.com/47305c8a2024ae45a2ab870a1bf41f01a26c8ae5/content/test/gpu/page_sets/gpu_process_tests.py
[modify] https://crrev.com/47305c8a2024ae45a2ab870a1bf41f01a26c8ae5/gpu/config/gpu_info_collector_android.cc

Quick status, so I fixed those tests:

 
-    # Android
-    self.Fail('GpuProcess.no_gpu_process',
-              ['android'], bug= 611930 )
-    self.Fail('GpuProcess.identify_active_gpu1',
-              ['android'], bug= 611930 )
-    self.Fail('GpuProcess.identify_active_gpu2',
-              ['android'], bug= 611930 )
-    self.Fail('GpuProcess.identify_active_gpu3',
-              ['android'], bug= 611930 )
-    self.Fail('GpuProcess.identify_active_gpu4',
-              ['android'], bug= 611930 )
-    self.Fail('GpuProcess.readback_webgl_gpu_process',
-              ['android'], bug= 611930 )
-    self.Fail('GpuProcess.driver_bug_workarounds_upon_gl_renderer',
-              ['android'], bug= 611930 )
-

Remaining are:

    # Nexus 5X
    # Skip this test because expecting it to fail will still run it.
    self.Skip('GpuProcess.skip_gpu_process',
              ['android', ('qualcomm', 'Adreno (TM) 418')], bug=610951)

    # Nexus 9
    # Skip this test because expecting it to fail will still run it.
    self.Skip('GpuProcess.skip_gpu_process',
              ['android', 'nvidia'], bug= 610023 )

    # There are currently no blacklist entries disabling all GPU
    # functionality on Mac OS.
    self.Fail('GpuProcess.no_gpu_process', ['mac'], bug= 579255 )



Comment 11 by kbr@chromium.org, Aug 22 2016

Thanks Julien for working on this. If some of these are impractical to fix then feel free to leave the suppressions in there, leave a comment here, and close as fixed.

Project Member

Comment 12 by sheriffbot@chromium.org, Jan 24 2017

Labels: Hotlist-Recharge-BouncingOwner
Status: Untriaged (was: Assigned)
The assigned owner "j.isorce@samsung.com" is not able to receive e-mails, please re-triage.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: ----
Cc: zmo@chromium.org kainino@chromium.org
Status: Available (was: Untriaged)

Comment 15 by kbr@chromium.org, Feb 3 2017

Owner: j.iso...@samsung.com
Status: Fixed (was: Available)
This issue can be considered fixed. These particular tests can't run successfully on Android because it requires a GPU process.

Sign in to add a comment