New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 611924 link

Starred by 1 user
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: May 2016
Cc:
fmalita@chromium.org
jbroman@chromium.org
█ wkorman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

DisplayItemList::ShouldBeAnalyzedForSolidColor() returns true for a list containing 100k operations

Project Member Reported by wangxianzhu@chromium.org, May 14 2016 
When analyzing performance of third_party/WebKit/PerformanceTests/Paint/large-table-background-change-with-visible-collapsed-borders.html, I found that in each frame update (about 200ms), about 1/4 time is used to analyze solid color. This is because DisplayItemList::ApproximateOpCount() returns 0 for squashed display items.
Project Member

Comment 1 by bugdroid1@chromium.org, May 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a382d937939a96e45a2b7a5145f0edce3e0fecfc

commit a382d937939a96e45a2b7a5145f0edce3e0fecfc
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Mon May 16 18:03:30 2016

Correct DisplayItemList::ApproximateOpCount() for flattened picture

BUG= 611924 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/1981503003
Cr-Commit-Position: refs/heads/master@{#393862}

[modify] https://crrev.com/a382d937939a96e45a2b7a5145f0edce3e0fecfc/cc/playback/display_item_list.cc
[modify] https://crrev.com/a382d937939a96e45a2b7a5145f0edce3e0fecfc/cc/playback/display_item_list_unittest.cc
[modify] https://crrev.com/a382d937939a96e45a2b7a5145f0edce3e0fecfc/cc/playback/recording_source.cc

Comment 2 by wangxianzhu@chromium.org, May 16 2016

Status: Fixed (was: Started)
►

Sign in to add a comment