New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 611923 link

Starred by 5 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Not able to reset "never translate this lang"

Project Member Reported by chaotian@chromium.org, May 14 2016

Issue description

Version: Version after 52.0.2729.0
OS: Windows

Turn on the  "Translate 2016Q2 UI" first.
If user clicked never translate this lang, The bubble won't show up automatically anymore even if user click omni icon to translate this page again. It also won't always translate if user selected always do this.
 

Comment 1 by ftang@chromium.org, May 14 2016

could you write the bug in the following format?

What steps will reproduce the problem?
(1)
(2)
(3)

What is the expected output?

What do you see instead?

Version: Version after 52.0.2729.0
OS: Windows

What steps will reproduce the problem?
(1)Turn on the  "Translate 2016Q2 UI" first.
(2)Visit a page that triggers translate bubble
(3)Click "never translate this lang"
(4)Visit another page that is the same language as the previous one
(5)Click Translate omni icon to translate this page
(6)Visit another page that is the same language as the previous one

What is the expected output?
Translate bubble shows up

What do you see instead?
Translate bubble does not show up.
If modify (5) and check "always do this", Translate bubble also does not show up.

Comment 3 by ftang@chromium.org, May 17 2016

The reason is we never and are not planning to reset the 
translate_blocked_languages
nor
translate_site_blacklist
list.

I think we need to think careful about this. Because if we remove the language from translate_blocked_languages , should we also remove the site from translate_site_blacklist?

Is that what user intend to do?

I think what really need to be done is to improve 
chrome://settings/languages

to include some UI to manage both list.
Currently, user can go to 
chrome://translate-internals/ which is not User Friendly UI to remove the items on both lists.

Comment 4 by groby@chromium.org, May 19 2016

This is a behavior bug. The *only* reason to display the icon in the omnibox even when translation is disabled is that we want to give the user an option to reactivate translation that way. 

We should not remove from any lists, but we should offer translation. And when the user *does* hit translate, we should remove from the list with the narrowest scope.

Comment 5 by ftang@chromium.org, Jun 29 2016

Cc: juliecattiau@google.com zkoch@chromium.org pendar@google.com
This is a UI/UX issue. cc zkoch,juliecattiau@google.com,pendar@google.com 

Comment 6 by ftang@chromium.org, Jun 29 2016

Labels: -Pri-1 Pri-2
Lower to P2
Cc: yyushkina@chromium.org
Labels: Hotlist-Translate2016Q2UI
Cc: groby@chromium.org chaotian@chromium.org ftang@chromium.org
 Issue 610376  has been merged into this issue.
Labels: OS-Chrome
I think we should follow groby@'s sugegstion: show Omnibox icon ( issue 610376 ) for users who have clicked never translate this language or site, and then if/ when the user *does* hit translate, we should remove from the list with the narrowest scope.
Cc: ftang@google.com
Owner: yyushkina@chromium.org
Components: -UI>Browser>Translate UI>Browser>Language>Translate
Labels: -Hotlist-Translate2016Q2UI
Owner: ----
Status: Available (was: Assigned)
Owner: anthonyvd@chromium.org
Owner: nicolaso@chromium.org
Status: Assigned (was: Available)
Hey Nicolas, this is a companion bug to crbug.com/600874.

If a user who selected "Never translate site/language" then Translates on that site/source language using either the icon or right-click to translate, we should remove the source language from that Never list.

Edge case: If the user has the site AND the language in the Never lists, remove from the site list first.
Owner: anthonyvd@chromium.org
Reassigning to Anthony

Sign in to add a comment