New issue
Advanced search Search tips

Issue 611912 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Unload Dialog always "leaves" when pressing enter.

Project Member Reported by apaci...@chromium.org, May 13 2016

Issue description

Version: 52.0.2735.0 canary (64-bit)
OS: Mac OSX 10.11.4

What steps will reproduce the problem?
(1) Open a page where navigation would trigger the "Do you want to leave this site?" dialog. For example, Google Forms, and start filling out the form.
(2) Try to navigate away from the page. Dialog should show up. See below for details on behavior.

What is the expected output?
#1 If I press <enter>, I would stay on the current page.

#2 If I tab (highlight "Leave") then shift+tab (highlight "Stay"), then press <enter>, I would stay on the current page.

#3 If I tab (highlight "Leave"), then press <enter>, I would leave the page.

What do you see instead?
All three scenarios leaves the page.

If I manually click on "Stay", it works as intended.

---
+cc avi, who is the OWNER for src/components/app_modal

The dialog is this one: https://code.google.com/p/chromium/codesearch#chromium/src/components/app_modal/javascript_dialog_manager.cc&l=201

 
Screen Shot 2016-05-13 at 4.35.20 PM.png
42.7 KB View Download
Components: UI>Browser>TabContents
Labels: OS-Windows

Comment 3 by a...@chromium.org, May 14 2016

Labels: -OS-Windows
Status: WontFix (was: Untriaged)
spqchan@, are you sure this is OS-Windows? It's completely different code.

apacible@, you misunderstand how "Full Keyboard Access" works.

The escape/return keys always do cancel/OK in a dialog. In this particular dialog, whether or not you have "Full Keyboard Access" turned on, escape = stay, return = leave.

When you enable "Full Keyboard Access", you can highlight buttons with the tab key. But to activate the highlighted button, DO NOT PRESS RETURN. (Don't forget, return ALWAYS is the default, blue button.) RATHER, use the SPACEBAR to activate the highlighted button.

This is completely not how Windows works, so you are going to have to retrain your brain :(
Ahh okay. :( Time to retrain my fingers.

Thanks for the clarification!

Sign in to add a comment