Tracking bug: Improving user removal from Start screen - eng work |
||||||||
Issue descriptionThis is a tracking bug for the eng work required for issue 602747.
,
May 27 2016
If we intend to get this done for 53 it probably should NOT be P3. dzhioev@ can you take this on?
,
Jul 10 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 12 2016
dzhioev@ - when you get back, could you update on the state?
,
Jul 27 2016
,
Jul 27 2016
Hey warx@ Per offline discussion, could you take over this?
,
Jul 27 2016
yes, I can do that.
,
Jul 27 2016
,
Jul 28 2016
Hi omrilio@, which warning message should be displayed on removing confirmation? I propose "All files and local data associated with this user will be permanently deleted once this user is removed. To retrieve your data later, sign in as [user.email]." Please let me know your suggestions. Thanks.
,
Jul 28 2016
Thanks! That sounds good to me. Per offline discussion, this also fits well with the Supervised user's message. I have asked Lindsay to have a look, she is currently OOO and will be back next week. For now we can use this string as a placeholder, sounds good?
,
Jul 28 2016
,
Jul 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/636ea5a0427aa08d516eca5fa1171db36fb7e391 commit 636ea5a0427aa08d516eca5fa1171db36fb7e391 Author: warx <warx@chromium.org> Date: Fri Jul 29 16:02:18 2016 Add remove non-device-owner user removal confirmation Just like removing supervised user, there will be a removing warning UI for removing non-device-owner (since device owner doesn't show "Remove this person" entry). The removing warning message right now is just a placeholder. Will update it later once I hear it back from the discussion. BUG= 611904 TEST=device test Review-Url: https://codereview.chromium.org/2189163002 Cr-Commit-Position: refs/heads/master@{#408646} [modify] https://crrev.com/636ea5a0427aa08d516eca5fa1171db36fb7e391/chrome/app/generated_resources.grd [modify] https://crrev.com/636ea5a0427aa08d516eca5fa1171db36fb7e391/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc [modify] https://crrev.com/636ea5a0427aa08d516eca5fa1171db36fb7e391/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc [modify] https://crrev.com/636ea5a0427aa08d516eca5fa1171db36fb7e391/ui/login/account_picker/user_pod_row.css [modify] https://crrev.com/636ea5a0427aa08d516eca5fa1171db36fb7e391/ui/login/account_picker/user_pod_row.js [modify] https://crrev.com/636ea5a0427aa08d516eca5fa1171db36fb7e391/ui/login/account_picker/user_pod_template.html
,
Jul 29 2016
Above CL implements the function. The warning message now is just a placeholder.
,
Aug 10 2016
ping: have we decided on the warning message on this one?
,
Aug 18 2016
Yes, Lindsay reviewed. Please use: "All files and local data associated with this user will be permanently deleted once this user is removed. user.email@gmail.com can still sign in later." Thank you!
,
Aug 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21f9b1fc35bfaab1d900d8c5fde3beb2a8eebdd8 commit 21f9b1fc35bfaab1d900d8c5fde3beb2a8eebdd8 Author: warx <warx@chromium.org> Date: Fri Aug 19 16:16:33 2016 Update remove non-owner user warning message and fix the unwanted space Update the warning message using: "All files and local data associated with this user will be permanently deleted once this user is removed. user.email@gmail.com can still sign in later" Fix unwanted space on above warning message. BUG= 611904 BUG= 636711 TEST=desktop build test Review-Url: https://codereview.chromium.org/2258043002 Cr-Commit-Position: refs/heads/master@{#413160} [modify] https://crrev.com/21f9b1fc35bfaab1d900d8c5fde3beb2a8eebdd8/chrome/app/generated_resources.grd [modify] https://crrev.com/21f9b1fc35bfaab1d900d8c5fde3beb2a8eebdd8/ui/login/account_picker/user_pod_row.js
,
Aug 19 2016
,
Oct 21 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by omrilio@chromium.org
, May 24 2016