New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 611903 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 609205



Sign in to add a comment

Don't build property trees whenever opacity of a Layer changes

Project Member Reported by jaydasika@chromium.org, May 13 2016

Issue description

They should be build only when that Layer doesn't own an effect node, otherwise, updating property trees should be enough.
 
Cc: weiliangc@chromium.org

Comment 2 by ajuma@chromium.org, May 13 2016

They also need to be rebuilt if opacity changes from non-1 to 1 or vice-versa (since that affects render surface creation).
Cc: -jaydasika@chromium.org
Owner: jaydasika@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d6efe2e2ad947cce26006896b87d594a4885c80

commit 8d6efe2e2ad947cce26006896b87d594a4885c80
Author: jaydasika <jaydasika@chromium.org>
Date: Tue May 17 15:37:21 2016

cc : Rebuild property trees when opacity changes only if its required.

If the change in opacity is from a non-1 value to a non-1 value we need
not rebuild property trees as an effect node already exists and we only
need to update it.

BUG= 611903 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/1979413002
Cr-Commit-Position: refs/heads/master@{#394131}

[modify] https://crrev.com/8d6efe2e2ad947cce26006896b87d594a4885c80/cc/layers/layer.cc
[modify] https://crrev.com/8d6efe2e2ad947cce26006896b87d594a4885c80/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/8d6efe2e2ad947cce26006896b87d594a4885c80/cc/trees/layer_tree_host_common_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment