Incorrect opacity for scrollbar layer with property trees |
||||
Issue descriptionScrollbarLayerImplBase::PushPropertiesTo ensures that the active tree opacity is not overwritten at commit time. We don't have a corresponding logic in property trees to do the same which implies the property trees opacity will be overwritten. This special case exists because, for solid color scrollbars, the active tree fade animator fully controls the opacity policy and Blink shouldn't change it. This should be broken on ToT as we are using property trees.
,
May 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae9b7a05e087905774fb29807281fa771711ff3b commit ae9b7a05e087905774fb29807281fa771711ff3b Author: jaydasika <jaydasika@chromium.org> Date: Thu May 19 16:12:52 2016 cc : Track ids for which active opacity always wins on property trees And then use this for partial sync of property trees at the time of activation. PaintedScrollbarLayer and SolidColorScrollbarLayer currently need the active tree opacity to win at activation. BUG= 611899 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/1991523002 Cr-Commit-Position: refs/heads/master@{#394784} [modify] https://crrev.com/ae9b7a05e087905774fb29807281fa771711ff3b/cc/layers/layer.cc [modify] https://crrev.com/ae9b7a05e087905774fb29807281fa771711ff3b/cc/layers/layer.h [modify] https://crrev.com/ae9b7a05e087905774fb29807281fa771711ff3b/cc/layers/painted_scrollbar_layer.cc [modify] https://crrev.com/ae9b7a05e087905774fb29807281fa771711ff3b/cc/layers/painted_scrollbar_layer.h [modify] https://crrev.com/ae9b7a05e087905774fb29807281fa771711ff3b/cc/layers/scrollbar_layer_impl_base.cc [modify] https://crrev.com/ae9b7a05e087905774fb29807281fa771711ff3b/cc/layers/scrollbar_layer_impl_base.h [modify] https://crrev.com/ae9b7a05e087905774fb29807281fa771711ff3b/cc/layers/scrollbar_layer_unittest.cc [modify] https://crrev.com/ae9b7a05e087905774fb29807281fa771711ff3b/cc/layers/solid_color_scrollbar_layer.cc [modify] https://crrev.com/ae9b7a05e087905774fb29807281fa771711ff3b/cc/layers/solid_color_scrollbar_layer.h [modify] https://crrev.com/ae9b7a05e087905774fb29807281fa771711ff3b/cc/proto/property_tree.proto [modify] https://crrev.com/ae9b7a05e087905774fb29807281fa771711ff3b/cc/trees/layer_tree_host_impl.cc [modify] https://crrev.com/ae9b7a05e087905774fb29807281fa771711ff3b/cc/trees/layer_tree_host_impl_unittest.cc [modify] https://crrev.com/ae9b7a05e087905774fb29807281fa771711ff3b/cc/trees/property_tree.cc [modify] https://crrev.com/ae9b7a05e087905774fb29807281fa771711ff3b/cc/trees/property_tree.h [modify] https://crrev.com/ae9b7a05e087905774fb29807281fa771711ff3b/cc/trees/property_tree_builder.cc
,
May 19 2016
I hope you are actually going to run this one to completion, or actively hand it off.
,
May 19 2016
petermayo@: could you explain in more detail what you think is incomplete about the change in #2 and where you think this should go from here?
,
May 19 2016
[+cc petermayo@], see my question above.
,
May 19 2016
The part where the bug status is available and owned by jaydasika@, not assigned or fixed.
,
May 19 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by jaydasika@chromium.org
, May 16 2016