New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 611876 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Ignore in-lined files

Project Member Reported by st...@chromium.org, May 13 2016

Issue description

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/adaf864ffb6be7ae85c71c1cd4adbd3ec677a0e2

commit adaf864ffb6be7ae85c71c1cd4adbd3ec677a0e2
Author: katesonia <katesonia@chromium.org>
Date: Tue May 17 18:42:05 2016

[Findit] Filter inline function path frames

Change GetCrashStack() function of stacktrace to computed property crash_stack, using signature to determine the crash stack, and filter frames before signature while computing main stack. Remove the FilterFramesBeforeSignature function in callstack_filters.

Add FilterInlineFunctionFrames to filter those inline function frames, because for these frames, the file paths are not the oringinal file paths.

BUG= 611876 

Review-Url: https://codereview.chromium.org/1980203002

[modify] https://crrev.com/adaf864ffb6be7ae85c71c1cd4adbd3ec677a0e2/appengine/findit/crash/callstack_filters.py
[modify] https://crrev.com/adaf864ffb6be7ae85c71c1cd4adbd3ec677a0e2/appengine/findit/crash/findit_for_crash.py
[modify] https://crrev.com/adaf864ffb6be7ae85c71c1cd4adbd3ec677a0e2/appengine/findit/crash/fracas_parser.py
[modify] https://crrev.com/adaf864ffb6be7ae85c71c1cd4adbd3ec677a0e2/appengine/findit/crash/stacktrace.py
[modify] https://crrev.com/adaf864ffb6be7ae85c71c1cd4adbd3ec677a0e2/appengine/findit/crash/test/callstack_filters_test.py
[modify] https://crrev.com/adaf864ffb6be7ae85c71c1cd4adbd3ec677a0e2/appengine/findit/crash/test/fracas_parser_test.py
[modify] https://crrev.com/adaf864ffb6be7ae85c71c1cd4adbd3ec677a0e2/appengine/findit/crash/test/stacktrace_test.py

Comment 4 by st...@chromium.org, May 27 2016

Status: Fixed (was: Started)

Comment 5 by st...@chromium.org, May 27 2016

marked as fixed.

Sign in to add a comment