remoting host is mostly missing in mac/gn |
||||||||||||||||
Issue descriptionFiling so we don't forget about it. https://code.google.com/p/chromium/codesearch#chromium/src/remoting/host/BUILD.gn&l=71 if (is_mac) { # TODO(GYP) Mac build of remoting host.
,
May 13 2016
,
May 13 2016
,
May 13 2016
,
May 18 2016
rsesek@, this one's all you :)
,
May 18 2016
,
May 31 2016
Issue 615492 has been merged into this issue.
,
May 31 2016
Oops, I thought you had filed one but I couldn't find it Friday.
,
May 31 2016
,
Jun 1 2016
,
Jun 8 2016
Ping .. any update on this? This is now blocking us from flipping the Mac build over to GN by default, and we can't wait too long if we're going to hit M53. On other platforms, we've disabled remoting where needed rather than being blocked. Is that okay to do here as well?
,
Jun 8 2016
,
Jun 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e55f21958be24503dd0390d93e999c0a23f724c5 commit e55f21958be24503dd0390d93e999c0a23f724c5 Author: nicholss <nicholss@chromium.org> Date: Tue Jun 14 17:12:55 2016 Adding mac support for Remoting host GN builds. BUG= 611859 R=sergeyu@chromium.org Review-Url: https://codereview.chromium.org/2034513002 Cr-Commit-Position: refs/heads/master@{#399731} [modify] https://crrev.com/e55f21958be24503dd0390d93e999c0a23f724c5/remoting/BUILD.gn [modify] https://crrev.com/e55f21958be24503dd0390d93e999c0a23f724c5/remoting/host/BUILD.gn [modify] https://crrev.com/e55f21958be24503dd0390d93e999c0a23f724c5/remoting/host/constants_mac.cc [add] https://crrev.com/e55f21958be24503dd0390d93e999c0a23f724c5/remoting/host/version.h.in [modify] https://crrev.com/e55f21958be24503dd0390d93e999c0a23f724c5/remoting/remoting_enable.gni [modify] https://crrev.com/e55f21958be24503dd0390d93e999c0a23f724c5/remoting/remoting_version.gni
,
Jun 14 2016
,
Jun 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9fe48917bcb24d199b3e008566057f59856f1ac4 commit 9fe48917bcb24d199b3e008566057f59856f1ac4 Author: hcarmona <hcarmona@chromium.org> Date: Tue Jun 14 17:53:56 2016 Revert of Adding mac support for Remoting host GN builds. (patchset #6 id:100001 of https://codereview.chromium.org/2034513002/ ) Reason for revert: Suspecting this CL for compile failure in Mac GN: https://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20%28dbg%29/builds/34015 Undefined symbols for architecture x86_64: "_GetApplicationEventTarget", referenced from: remoting::(anonymous namespace)::SessionWatcher::InstallEventHandler() in libhost.a(curtain_mode_mac.o) "_InstallEventHandler", referenced from: remoting::(anonymous namespace)::SessionWatcher::InstallEventHandler() in libhost.a(curtain_mode_mac.o) "_RemoveEventHandler", referenced from: remoting::(anonymous namespace)::SessionWatcher::RemoveEventHandler() in libhost.a(curtain_mode_mac.o) ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) Original issue's description: > Adding mac support for Remoting host GN builds. > > BUG= 611859 > > R=sergeyu@chromium.org > > Committed: https://crrev.com/e55f21958be24503dd0390d93e999c0a23f724c5 > Cr-Commit-Position: refs/heads/master@{#399731} TBR=sergeyu@chromium.org,nicholss@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 611859 Review-Url: https://codereview.chromium.org/2068633003 Cr-Commit-Position: refs/heads/master@{#399742} [modify] https://crrev.com/9fe48917bcb24d199b3e008566057f59856f1ac4/remoting/BUILD.gn [modify] https://crrev.com/9fe48917bcb24d199b3e008566057f59856f1ac4/remoting/host/BUILD.gn [modify] https://crrev.com/9fe48917bcb24d199b3e008566057f59856f1ac4/remoting/host/constants_mac.cc [delete] https://crrev.com/a033e0202b133bb5892e2e28ca37bf052afad816/remoting/host/version.h.in [modify] https://crrev.com/9fe48917bcb24d199b3e008566057f59856f1ac4/remoting/remoting_enable.gni [modify] https://crrev.com/9fe48917bcb24d199b3e008566057f59856f1ac4/remoting/remoting_version.gni
,
Jun 14 2016
,
Jun 14 2016
I patched in the CL locally. It succeeds for a non-component build, but fails for a component build. The difference is that the ninja file isn't including the Carbon framework in the component build. Not sure if this is a bug in the way you've set up the GN file, or in component build. Paging rsesek.
,
Jun 14 2016
Yes, for the host remoting target, a |libs += [ "Carbon.framework" ]| is necessary (maybe with = instead of += depending on the scope).
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e55f21958be24503dd0390d93e999c0a23f724c5 commit e55f21958be24503dd0390d93e999c0a23f724c5 Author: nicholss <nicholss@chromium.org> Date: Tue Jun 14 17:12:55 2016 Adding mac support for Remoting host GN builds. BUG= 611859 R=sergeyu@chromium.org Review-Url: https://codereview.chromium.org/2034513002 Cr-Commit-Position: refs/heads/master@{#399731} [modify] https://crrev.com/e55f21958be24503dd0390d93e999c0a23f724c5/remoting/BUILD.gn [modify] https://crrev.com/e55f21958be24503dd0390d93e999c0a23f724c5/remoting/host/BUILD.gn [modify] https://crrev.com/e55f21958be24503dd0390d93e999c0a23f724c5/remoting/host/constants_mac.cc [add] https://crrev.com/e55f21958be24503dd0390d93e999c0a23f724c5/remoting/host/version.h.in [modify] https://crrev.com/e55f21958be24503dd0390d93e999c0a23f724c5/remoting/remoting_enable.gni [modify] https://crrev.com/e55f21958be24503dd0390d93e999c0a23f724c5/remoting/remoting_version.gni
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9fe48917bcb24d199b3e008566057f59856f1ac4 commit 9fe48917bcb24d199b3e008566057f59856f1ac4 Author: hcarmona <hcarmona@chromium.org> Date: Tue Jun 14 17:53:56 2016 Revert of Adding mac support for Remoting host GN builds. (patchset #6 id:100001 of https://codereview.chromium.org/2034513002/ ) Reason for revert: Suspecting this CL for compile failure in Mac GN: https://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20%28dbg%29/builds/34015 Undefined symbols for architecture x86_64: "_GetApplicationEventTarget", referenced from: remoting::(anonymous namespace)::SessionWatcher::InstallEventHandler() in libhost.a(curtain_mode_mac.o) "_InstallEventHandler", referenced from: remoting::(anonymous namespace)::SessionWatcher::InstallEventHandler() in libhost.a(curtain_mode_mac.o) "_RemoveEventHandler", referenced from: remoting::(anonymous namespace)::SessionWatcher::RemoveEventHandler() in libhost.a(curtain_mode_mac.o) ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) Original issue's description: > Adding mac support for Remoting host GN builds. > > BUG= 611859 > > R=sergeyu@chromium.org > > Committed: https://crrev.com/e55f21958be24503dd0390d93e999c0a23f724c5 > Cr-Commit-Position: refs/heads/master@{#399731} TBR=sergeyu@chromium.org,nicholss@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 611859 Review-Url: https://codereview.chromium.org/2068633003 Cr-Commit-Position: refs/heads/master@{#399742} [modify] https://crrev.com/9fe48917bcb24d199b3e008566057f59856f1ac4/remoting/BUILD.gn [modify] https://crrev.com/9fe48917bcb24d199b3e008566057f59856f1ac4/remoting/host/BUILD.gn [modify] https://crrev.com/9fe48917bcb24d199b3e008566057f59856f1ac4/remoting/host/constants_mac.cc [delete] https://crrev.com/a033e0202b133bb5892e2e28ca37bf052afad816/remoting/host/version.h.in [modify] https://crrev.com/9fe48917bcb24d199b3e008566057f59856f1ac4/remoting/remoting_enable.gni [modify] https://crrev.com/9fe48917bcb24d199b3e008566057f59856f1ac4/remoting/remoting_version.gni
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6fb262ca88b0a3bc10ba7deb8a03e1d3acbf355 commit e6fb262ca88b0a3bc10ba7deb8a03e1d3acbf355 Author: nicholss <nicholss@chromium.org> Date: Wed Jun 15 18:11:06 2016 Adding mac support for Remoting host GN builds. BUG= 611859 R=sergeyu@chromium.org Committed: https://crrev.com/e55f21958be24503dd0390d93e999c0a23f724c5 Review-Url: https://codereview.chromium.org/2034513002 Cr-Original-Commit-Position: refs/heads/master@{#399731} Cr-Commit-Position: refs/heads/master@{#399957} [modify] https://crrev.com/e6fb262ca88b0a3bc10ba7deb8a03e1d3acbf355/remoting/BUILD.gn [modify] https://crrev.com/e6fb262ca88b0a3bc10ba7deb8a03e1d3acbf355/remoting/host/BUILD.gn [modify] https://crrev.com/e6fb262ca88b0a3bc10ba7deb8a03e1d3acbf355/remoting/host/constants_mac.cc [add] https://crrev.com/e6fb262ca88b0a3bc10ba7deb8a03e1d3acbf355/remoting/host/version.h.in [modify] https://crrev.com/e6fb262ca88b0a3bc10ba7deb8a03e1d3acbf355/remoting/remoting_enable.gni [modify] https://crrev.com/e6fb262ca88b0a3bc10ba7deb8a03e1d3acbf355/remoting/remoting_version.gni
,
Jun 20 2016
I believe this is now fixed.
,
Jul 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d281f458a9cb73ee335f3d0afda1d998d4db59c8 commit d281f458a9cb73ee335f3d0afda1d998d4db59c8 Author: rsesek <rsesek@chromium.org> Date: Fri Jul 15 20:55:09 2016 [Mac/GN] Add missing files to some //remoting targets. BUG= 611859 R=sergeyu@chromium.org Review-Url: https://codereview.chromium.org/2153883002 Cr-Commit-Position: refs/heads/master@{#405855} [modify] https://crrev.com/d281f458a9cb73ee335f3d0afda1d998d4db59c8/remoting/host/BUILD.gn [modify] https://crrev.com/d281f458a9cb73ee335f3d0afda1d998d4db59c8/remoting/host/it2me/BUILD.gn |
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by dpranke@chromium.org
, May 13 2016Cc: zijiehe@chromium.org