New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 611849 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 611319
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

kasko / installer build flakiness (windows)

Project Member Reported by est...@chromium.org, May 13 2016

Issue description

seems some dependency is messed up for the generated file kasko_features.h:

[2525/33262] CXX obj\chrome\installer\setup\setup_lib.installer_crash_reporting.obj
FAILED: obj/chrome/installer/setup/setup_lib.installer_crash_reporting.obj 
ninja -t msvc -e environment.x86 -- C:\b\build\slave\cache\cipd\goma/gomacc "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\chrome\installer\setup\setup_lib.installer_crash_reporting.obj.rsp /c ..\..\chrome\installer\setup\installer_crash_reporting.cc /Foobj\chrome\installer\setup\setup_lib.installer_crash_reporting.obj /Fdobj\chrome\setup_lib.cc.pdb 
c:\b\build\slave\win\build\src\components\crash\content\app\crashpad.h(15): fatal error C1083: Cannot open include file: 'third_party/kasko/kasko_features.h': No such file or directory

https://build.chromium.org/p/chromium/builders/Win/builds/43370
 
Cc: ananta@chromium.org
chrome elf change maybe?

Comment 2 by est...@chromium.org, May 14 2016

Mergedinto: 611319
Status: Duplicate (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, May 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a81d8c56784867ada51a97a9dbac4ffd0200eb74

commit a81d8c56784867ada51a97a9dbac4ffd0200eb74
Author: estade <estade@chromium.org>
Date: Mon May 16 19:11:52 2016

Mark kasko as a hard dependency since it depends on kasko_features which generates a header file.

BUG= 611849 

Review-Url: https://codereview.chromium.org/1976113003
Cr-Commit-Position: refs/heads/master@{#393891}

[modify] https://crrev.com/a81d8c56784867ada51a97a9dbac4ffd0200eb74/third_party/kasko/kasko.gyp

Sign in to add a comment