New issue
Advanced search Search tips

Issue 611838 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 477150



Sign in to add a comment

Regression - geolocation-on-secure-origin-in-insecure-origin.html fails with --site-per-process

Project Member Reported by lukasza@chromium.org, May 13 2016

Issue description

Repro steps:
$ ninja -C out/gn ... blink_tests
$ third_party/WebKit/Tools/Scripts/run-webkit-tests -t gn -v --additional-drt-flag=--site-per-process http/tests/security/powerfulFeatureRestrictions/geolocation-on-secure-origin-in-insecure-origin.html

Expected: the test passes

Actual: the test times out
 
Owner: sa...@chromium.org
sammc@, could you please take a look?

I've verified that this has regressed because of https://codereview.chromium.org/1948033003
Project Member

Comment 3 by bugdroid1@chromium.org, May 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c074488f38fda053dc3458d66ae0c1e9350e93fc

commit c074488f38fda053dc3458d66ae0c1e9350e93fc
Author: lukasza <lukasza@chromium.org>
Date: Fri May 13 20:38:03 2016

Test expectation for geolocation-on-secure-origin-in-insecure-origin.html

BUG= 611838 
TBR=sammc@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/1978953002
Cr-Commit-Position: refs/heads/master@{#393620}

[modify] https://crrev.com/c074488f38fda053dc3458d66ae0c1e9350e93fc/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process

Comment 4 by joh...@chromium.org, May 23 2016

Cc: mvanouwe...@chromium.org
Status: Assigned (was: Untriaged)

Comment 5 by nasko@chromium.org, Dec 7 2016

sammc@, can you look into fixing this issue or reassign to someone to look at it more actively? Out-of-process iframes is starting to ship to stable, so it will be great to start fixing these outstanding issues.
Cc: -mvanouwe...@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff

commit 7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff
Author: sammc <sammc@chromium.org>
Date: Mon Jan 30 00:53:51 2017

Change allowed bindings to be per RenderFrame instead of per RenderView.

Previously, extra JS bindings were granted on a per-RenderView basis.
One of the binding types is access to mojo JS bindings for layout tests.
To allow access to these bindings in subframes, RenderFrame was changed
to inherit whatever bindings were allowed at a process-wide level.
Since all RenderViews are granted these bindings in layout tests, this
was sufficient as long as the frame checks for allowed bindings after
a RenderView has received the IPC granting it bindings for the test or
is a main frame, since main frames are notified by the RenderView when
bindings are granted. With site isolation, there is one layout test
where a RenderFrame checks for bindings before any RenderView receives
the binding-granting IPC, and as a result it cannot access the mojo
bindings necessary to run that test.

This CL fixes this problem by moving management of these bindings to be
per-RenderFrame. To maintain the existing behavior, subframes are
granted the same bindings as their parent frames. The difference is that
now the browser is responsible, so it no longer relies on subframes
being created in a renderer where some global state has already been
set.

BUG= 611838 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2566583002
Cr-Commit-Position: refs/heads/master@{#446950}

[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/chrome/browser/memory_details.cc
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/chrome/browser/sessions/session_restore_browsertest.cc
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/chrome/browser/ui/browser_navigator_browsertest.cc
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/chrome/browser/ui/webui/mojo_web_ui_controller.cc
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/chrome/renderer/chrome_render_view_observer.cc
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/components/dom_distiller/content/browser/dom_distiller_viewer_source.cc
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/content/browser/frame_host/interstitial_page_impl.cc
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/content/browser/frame_host/navigation_controller_impl_browsertest.cc
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/content/browser/frame_host/navigation_controller_impl_unittest.cc
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/content/browser/frame_host/render_frame_host_manager_browsertest.cc
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/content/browser/frame_host/render_frame_host_manager_unittest.cc
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/content/browser/renderer_host/render_view_host_impl.h
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/content/browser/renderer_host/render_view_host_unittest.cc
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/content/browser/security_exploit_browsertest.cc
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/content/browser/web_contents/web_contents_impl_unittest.cc
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/content/common/frame.mojom
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/content/public/browser/render_frame_host.h
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/content/public/browser/render_view_host.h
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/content/public/renderer/render_frame.h
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/content/public/renderer/render_view.h
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/content/renderer/render_frame_impl.h
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/content/renderer/render_process_impl.cc
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/content/renderer/render_view_impl.cc
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/content/renderer/render_view_impl.h
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/content/renderer/web_ui_extension.cc
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/content/shell/browser/layout_test/blink_test_controller.cc
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/headless/lib/browser/headless_web_contents_impl.cc
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
[modify] https://crrev.com/7f6c6a0b64b8d4df8cb476d88bc582109c0d6bff/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-execution-contexts-events.html

Comment 8 by sa...@chromium.org, Feb 1 2017

Status: Fixed (was: Assigned)
Components: Blink>Geolocation
Components: -Blink>Location

Sign in to add a comment