New issue
Advanced search Search tips

Issue 611823 link

Starred by 1 user
Status: Fixed
Owner:
senorblanco@chromium.org
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 606672



Sign in to add a comment

cc: eliminate Skia restore() blit from composited filters path

Project Member Reported by senorblanco@chromium.org, May 13 2016 
Currently, cc calls out to skia for composited filters by creating an
SkSurface, calling drawImage() on it, and then drawing the filtered
result. Internally, this causes Skia to blit the filtered texture to the 
SkSurface (in restore()), which is then drawn by cc. By having Skia return 
the filtered texture directly, we should be able to eliminate this blit.

Comment 1 by senorblanco@chromium.org, May 13 2016

Blocking: 606672
Project Member

Comment 2 by bugdroid1@chromium.org, May 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60471d41ca8bf96b3a487c086ceefe2aca7d126a

commit 60471d41ca8bf96b3a487c086ceefe2aca7d126a
Author: senorblanco <senorblanco@chromium.org>
Date: Fri May 13 22:04:20 2016

cc: correctly fix edge-AA for filtered render surfaces.

Moving the destination bounds computation above the edge-AA computations
allows us to give correct positions for the edge-AA edges on filtered
quads. This is a change which will be necessary for an upcoming
optimization.

This required adding a matrix param to FilterOperation[s].MapRect().
Since this function is called with device-space rects, so it should also
be passed a matrix to transform the filter parameters into device space.

BUG= 611823 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/1980613003
Cr-Commit-Position: refs/heads/master@{#393657}

[modify] https://crrev.com/60471d41ca8bf96b3a487c086ceefe2aca7d126a/cc/output/filter_operation.cc
[modify] https://crrev.com/60471d41ca8bf96b3a487c086ceefe2aca7d126a/cc/output/filter_operation.h
[modify] https://crrev.com/60471d41ca8bf96b3a487c086ceefe2aca7d126a/cc/output/filter_operations.cc
[modify] https://crrev.com/60471d41ca8bf96b3a487c086ceefe2aca7d126a/cc/output/filter_operations.h
[modify] https://crrev.com/60471d41ca8bf96b3a487c086ceefe2aca7d126a/cc/output/filter_operations_unittest.cc
[modify] https://crrev.com/60471d41ca8bf96b3a487c086ceefe2aca7d126a/cc/output/gl_renderer.cc
[modify] https://crrev.com/60471d41ca8bf96b3a487c086ceefe2aca7d126a/cc/test/data/rotated_drop_shadow_filter_gl.png
Project Member

Comment 3 by bugdroid1@chromium.org, May 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3416360b06dda7afdcca0ea0b75bf088beeee12

commit a3416360b06dda7afdcca0ea0b75bf088beeee12
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Sat May 21 21:05:47 2016

Auto-rebaseline for r395263

https://chromium.googlesource.com/chromium/src/+/5e8ab54bd

BUG= 611823 
TBR=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/2000953002 .

Cr-Commit-Position: refs/heads/master@{#395264}

[modify] https://crrev.com/a3416360b06dda7afdcca0ea0b75bf088beeee12/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/a3416360b06dda7afdcca0ea0b75bf088beeee12/third_party/WebKit/LayoutTests/compositing/overflow/nested-render-surfaces-with-rotation-expected.png
[add] https://crrev.com/a3416360b06dda7afdcca0ea0b75bf088beeee12/third_party/WebKit/LayoutTests/platform/android/compositing/reflections/animation-inside-reflection-expected.png
[copy] https://crrev.com/a3416360b06dda7afdcca0ea0b75bf088beeee12/third_party/WebKit/LayoutTests/platform/android/virtual/prefer_compositing_to_lcd_text/compositing/overflow/nested-render-surfaces-with-intervening-clip-expected.png
[modify] https://crrev.com/a3416360b06dda7afdcca0ea0b75bf088beeee12/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/animation-inside-reflection-expected.png
[modify] https://crrev.com/a3416360b06dda7afdcca0ea0b75bf088beeee12/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-colorspace-hw-expected.png
[modify] https://crrev.com/a3416360b06dda7afdcca0ea0b75bf088beeee12/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-hidpi-hw-expected.png
[modify] https://crrev.com/a3416360b06dda7afdcca0ea0b75bf088beeee12/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-hw-expected.png
[modify] https://crrev.com/a3416360b06dda7afdcca0ea0b75bf088beeee12/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-ordering-hw-expected.png
[modify] https://crrev.com/a3416360b06dda7afdcca0ea0b75bf088beeee12/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-subregion-hw-expected.png
[modify] https://crrev.com/a3416360b06dda7afdcca0ea0b75bf088beeee12/third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-zoom-hw-expected.png
[modify] https://crrev.com/a3416360b06dda7afdcca0ea0b75bf088beeee12/third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/animation-inside-reflection-expected.png
[modify] https://crrev.com/a3416360b06dda7afdcca0ea0b75bf088beeee12/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-colorspace-hw-expected.png
[modify] https://crrev.com/a3416360b06dda7afdcca0ea0b75bf088beeee12/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-hidpi-hw-expected.png
[modify] https://crrev.com/a3416360b06dda7afdcca0ea0b75bf088beeee12/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-hw-expected.png
[modify] https://crrev.com/a3416360b06dda7afdcca0ea0b75bf088beeee12/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-ordering-hw-expected.png
[modify] https://crrev.com/a3416360b06dda7afdcca0ea0b75bf088beeee12/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-subregion-hw-expected.png
[modify] https://crrev.com/a3416360b06dda7afdcca0ea0b75bf088beeee12/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-zoom-hw-expected.png
[delete] https://crrev.com/5e8ab54bd2b0ab10a85b943a10dc9ebea051bada/third_party/WebKit/LayoutTests/platform/mac/virtual/prefer_compositing_to_lcd_text/compositing/overflow/nested-render-surfaces-with-intervening-clip-expected.png
[modify] https://crrev.com/a3416360b06dda7afdcca0ea0b75bf088beeee12/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/animation-inside-reflection-expected.png
[modify] https://crrev.com/a3416360b06dda7afdcca0ea0b75bf088beeee12/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-reference-colorspace-hw-expected.png
[modify] https://crrev.com/a3416360b06dda7afdcca0ea0b75bf088beeee12/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-reference-hidpi-hw-expected.png
[modify] https://crrev.com/a3416360b06dda7afdcca0ea0b75bf088beeee12/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-reference-hw-expected.png
[modify] https://crrev.com/a3416360b06dda7afdcca0ea0b75bf088beeee12/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-reference-ordering-hw-expected.png
[modify] https://crrev.com/a3416360b06dda7afdcca0ea0b75bf088beeee12/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-reference-subregion-hw-expected.png
[modify] https://crrev.com/a3416360b06dda7afdcca0ea0b75bf088beeee12/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-reference-zoom-hw-expected.png
[rename] https://crrev.com/a3416360b06dda7afdcca0ea0b75bf088beeee12/third_party/WebKit/LayoutTests/platform/win7/virtual/prefer_compositing_to_lcd_text/compositing/overflow/nested-render-surfaces-with-intervening-clip-expected.png
[add] https://crrev.com/a3416360b06dda7afdcca0ea0b75bf088beeee12/third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/nested-render-surfaces-with-intervening-clip-expected.png

Comment 4 by senorblanco@chromium.org, May 22 2016

Components: Blink>CSS>Filters
Status: Fixed (was: Assigned)
Forgot to BUG= the main one which fixes this, https://codereview.chromium.org/1959033002/, now landed.

Comment 5 by suzyh@chromium.org, Apr 5 2017

Components: -Blink>CSS>Filters Blink>Compositing>Filters
►

Sign in to add a comment