SequencedWorkerPool should use TaskAnnotator and TRACE_TASK_EXECUTION |
|||||
Issue descriptionWe should use TRACE_TASK_EXECUTION+TaskAnnotator like MessageLoop does to avoid code duplication. Rather than using the TRACE_EVENT_WITH_FLOW2 macro directly, MessageLoop and others use TaskAnnotator https://code.google.com/p/chromium/codesearch#chromium/src/base/message_loop/message_loop.cc&l=484 TaskAnnotator also handles the StopWatch+TallyRunOnNamedThreadIfTracking that is done at lines 830-835 of sequenced_worker_pool.cc. More context can be found at discussion in CL: https://codereview.chromium.org/1929913002/#msg11
,
Oct 18 2016
,
Oct 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af4072ecf86c2c8ff7ec217e4830e2c2e5964cf7 commit af4072ecf86c2c8ff7ec217e4830e2c2e5964cf7 Author: fdoray <fdoray@chromium.org> Date: Sun Oct 23 13:37:07 2016 Use TRACE_TASK_EXECUTION in SequencedWorkerPool. With this CL, SequencedWorkerPool generates an event in the "toplevel" category when it runs a task. This is the same behavior as MessageLoop, TaskScheduler and WorkerPool. BUG= 611818 Review-Url: https://chromiumcodereview.appspot.com/2429863002 Cr-Commit-Position: refs/heads/master@{#426994} [modify] https://crrev.com/af4072ecf86c2c8ff7ec217e4830e2c2e5964cf7/base/threading/sequenced_worker_pool.cc
,
Oct 24 2016
,
Oct 25 2016
,
Oct 25 2016
SequencedWorkerPool now generates the same tracing events as MessageLoops and TaskScheduler by using the TRACE_TASK_EXECUTION macro. It doesn't use TaskAnnotator because that would have required to make SequencedTask a child of PendingTask. We don't want to refactor code that will soon be deprecated.
,
Nov 7 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by fdoray@chromium.org
, Sep 26 2016