Issue 611816 link

Starred by 4 users

Issue metadata

Status:	Verified
Owner:	█ xiaoyinh@chromium.org Last visit > 30 days ago
Closed:	Jun 2016
Components:	UI>Shell
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Feature
M-53

Blocking:
issue 581384

Implement EOL UI

Project Member Reported by abodenha@chromium.org, May 13 2016

Issue description

Various devices are reaching the end of their promised support. See https://support.google.com/chrome/a/answer/6220366?hl=en

Cr-48 is already past its official EOL date, but we've continued pushing updates to those machines for the last several months.

We need a system for communicating clearly and proactively with users if their devices are going to stop receiving updates.

This issue tracks implementation of the communication mechanisms required to do that.

More info: goto/croseol and goto/croseol-ui (Google only)

Comment 1 by abodenha@chromium.org, May 13 2016

Blocking: 581384

Comment 2 by abodenha@chromium.org, May 13 2016

Owner: xiaoyinh@chromium.org

Comment 3 by xiaoyinh@chromium.org, May 23 2016

Status: Started (was: Assigned)

Comment 4 by xiaoyinh@chromium.org, Jun 9 2016

First CL in code review:

Expose the update engine function GetEolStatus to dbus client
https://chromium-review.googlesource.com/#/c/350874/

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/2f7d2849ad7d9fb8f82a19cedb1b972fda6be98c

commit 2f7d2849ad7d9fb8f82a19cedb1b972fda6be98c
Author: Xiaoyin Hu <xiaoyinh@chromium.org>
Date: Wed Jun 08 20:11:17 2016

Expose the update engine function GetEolStatus to dbus client

Chrome side will use this method to check the end of life status of
the device and show notifications corresponding to each status.

BUG= chromium:611816 
TEST=chrome compile

Change-Id: I237caaaebe60c9ddc72d111a545a612f8d7e676a
Reviewed-on: https://chromium-review.googlesource.com/350874
Commit-Ready: Xiaoyin Hu <xiaoyinh@chromium.org>
Tested-by: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/2f7d2849ad7d9fb8f82a19cedb1b972fda6be98c/dbus/update_engine/dbus-constants.h

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/751212be52eee0d9a9c75160ec7894a139924500

commit 751212be52eee0d9a9c75160ec7894a139924500
Author: xiaoyinh <xiaoyinh@chromium.org>
Date: Thu Jun 16 18:04:56 2016

Roll src/third_party/cros_system_api/ 534baa06a..2f7d2849a (3 commits).

2f7d2849a expose the DBus method GetEolStatus for DBus clients

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/534baa06a105..2f7d2849ad7d

$ git log 534baa06a..2f7d2849a --date=short --no-merges --format='%ad %ae %s'
2016-06-08 xiaoyinh Expose the update engine function GetEolStatus to dbus client
2016-05-27 jcliang dbus: power_manager: Add TABLET_MODE_{ON|OFF} protobuf definitions
2016-05-26 puthik dbus: bluetooth: Add GATT option string to match blueZ API change

BUG= 611816 

Review-Url: https://codereview.chromium.org/2055993002
Cr-Commit-Position: refs/heads/master@{#400201}

[modify] https://crrev.com/751212be52eee0d9a9c75160ec7894a139924500/DEPS

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec

commit f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec
Author: xiaoyinh <xiaoyinh@chromium.org>
Date: Sat Jun 18 04:50:23 2016

Implementation of Device End of Life Notification

When device is in EndOfLife status
1. In "About chrome OS" page, grey out update button and show EndofLife Strings
2. When User logs in, show EndofLife Notifications until dismissed.

BUG= 611816 
TEST=Manual and browsertest
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2060623002
Cr-Commit-Position: refs/heads/master@{#400578}

[modify] https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec/chrome/browser/about_flags.cc
[add] https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec/chrome/browser/chromeos/eol_notification.cc
[add] https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec/chrome/browser/chromeos/eol_notification.h
[modify] https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec/chrome/browser/chromeos/login/session/user_session_manager.h
[modify] https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec/chrome/browser/resources/help/help_content.html
[modify] https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec/chrome/browser/resources/help/help_page.js
[modify] https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec/chrome/browser/ui/webui/help/help_browsertest.js
[modify] https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec/chrome/browser/ui/webui/help/help_handler.cc
[modify] https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec/chrome/browser/ui/webui/help/help_handler.h
[modify] https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec/chrome/browser/ui/webui/help/version_updater.h
[modify] https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec/chrome/browser/ui/webui/help/version_updater_chromeos.cc
[modify] https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec/chrome/browser/ui/webui/help/version_updater_chromeos.h
[modify] https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec/chrome/chrome_browser_chromeos.gypi
[modify] https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec/chrome/common/pref_names.cc
[modify] https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec/chrome/common/pref_names.h
[modify] https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec/chrome/common/url_constants.cc
[modify] https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec/chrome/common/url_constants.h
[modify] https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec/chromeos/chromeos_switches.cc
[modify] https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec/chromeos/chromeos_switches.h
[modify] https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec/chromeos/dbus/fake_update_engine_client.cc
[modify] https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec/chromeos/dbus/fake_update_engine_client.h
[modify] https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec/chromeos/dbus/update_engine_client.cc
[modify] https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec/chromeos/dbus/update_engine_client.h
[modify] https://crrev.com/f39e3ddb63d7de2bfad1c9a2dda8a14653ee6bec/tools/metrics/histograms/histograms.xml

Comment 8 by xiaoyinh@chromium.org, Jun 27 2016

Add EOL notification icon in SVG format.

EOL_notification_100.svg
2.3 KB Download

EOL_notification_200.svg
2.3 KB Download

Comment 9 by addison@chromium.org, Jun 30 2016

UI review approved Strings can be found here:
https://drive.google.com/open?id=0B36J1AuBzU4RWVY4eTM5QWEwZWM

Sarah, any more work needed on this bug?  If not, can we close?

Comment 10 by xiaoyinh@chromium.org, Jun 30 2016

One more CL which is incorporating comments from UI review will come soon. Thanks!

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa17d834373d7501a033b7b56b0d7531363fc8e1

commit aa17d834373d7501a033b7b56b0d7531363fc8e1
Author: xiaoyinh <xiaoyinh@chromium.org>
Date: Thu Jun 30 22:56:02 2016

Follow up CL for EOL notification.
Incorporate comments in Dbus code and add Eol icon

BUG= 611816 
TEST=manual and browsertest
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2081873002
Cr-Commit-Position: refs/heads/master@{#403319}

[modify] https://crrev.com/aa17d834373d7501a033b7b56b0d7531363fc8e1/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/aa17d834373d7501a033b7b56b0d7531363fc8e1/chrome/browser/about_flags.cc
[modify] https://crrev.com/aa17d834373d7501a033b7b56b0d7531363fc8e1/chrome/browser/chromeos/eol_notification.cc
[modify] https://crrev.com/aa17d834373d7501a033b7b56b0d7531363fc8e1/chrome/browser/chromeos/eol_notification.h
[modify] https://crrev.com/aa17d834373d7501a033b7b56b0d7531363fc8e1/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/aa17d834373d7501a033b7b56b0d7531363fc8e1/chrome/browser/resources/help/help_content.css
[modify] https://crrev.com/aa17d834373d7501a033b7b56b0d7531363fc8e1/chrome/browser/resources/help/help_content.html
[modify] https://crrev.com/aa17d834373d7501a033b7b56b0d7531363fc8e1/chrome/browser/resources/help/help_page.js
[modify] https://crrev.com/aa17d834373d7501a033b7b56b0d7531363fc8e1/chrome/browser/ui/webui/help/help_browsertest.js
[modify] https://crrev.com/aa17d834373d7501a033b7b56b0d7531363fc8e1/chrome/browser/ui/webui/help/help_handler.cc
[modify] https://crrev.com/aa17d834373d7501a033b7b56b0d7531363fc8e1/chrome/browser/ui/webui/help/help_handler.h
[modify] https://crrev.com/aa17d834373d7501a033b7b56b0d7531363fc8e1/chrome/browser/ui/webui/help/version_updater.h
[modify] https://crrev.com/aa17d834373d7501a033b7b56b0d7531363fc8e1/chrome/browser/ui/webui/help/version_updater_chromeos.cc
[modify] https://crrev.com/aa17d834373d7501a033b7b56b0d7531363fc8e1/chromeos/chromeos_switches.cc
[modify] https://crrev.com/aa17d834373d7501a033b7b56b0d7531363fc8e1/chromeos/chromeos_switches.h
[modify] https://crrev.com/aa17d834373d7501a033b7b56b0d7531363fc8e1/chromeos/dbus/fake_update_engine_client.cc
[modify] https://crrev.com/aa17d834373d7501a033b7b56b0d7531363fc8e1/chromeos/dbus/update_engine_client.cc
[modify] https://crrev.com/aa17d834373d7501a033b7b56b0d7531363fc8e1/chromeos/dbus/update_engine_client.h
[modify] https://crrev.com/aa17d834373d7501a033b7b56b0d7531363fc8e1/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/aa17d834373d7501a033b7b56b0d7531363fc8e1/ui/gfx/BUILD.gn
[add] https://crrev.com/aa17d834373d7501a033b7b56b0d7531363fc8e1/ui/gfx/vector_icons/eol.icon
[add] https://crrev.com/aa17d834373d7501a033b7b56b0d7531363fc8e1/ui/gfx/vector_icons/info_outline.icon
[add] https://crrev.com/aa17d834373d7501a033b7b56b0d7531363fc8e1/ui/gfx/vector_icons/notifications_off.icon
[add] https://crrev.com/aa17d834373d7501a033b7b56b0d7531363fc8e1/ui/webui/resources/images/eol.svg

Comment 12 by xiaoyinh@chromium.org, Jun 30 2016

Status: Fixed (was: Started)

Comment 13 by dhadd...@chromium.org, Oct 18 2016

Status: Verified (was: Fixed)

►

Issue 611816 link

Issue metadata

Implement EOL UI

Issue description

Comment 1 by abodenha@chromium.org, May 13 2016

Comment 1 Deleted

Comment 2 by abodenha@chromium.org, May 13 2016

Comment 2 Deleted

Comment 3 by xiaoyinh@chromium.org, May 23 2016

Comment 3 Deleted

Comment 4 by xiaoyinh@chromium.org, Jun 9 2016

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Jun 9 2016

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Jun 16 2016

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Jun 18 2016

Comment 7 Deleted

Comment 8 by xiaoyinh@chromium.org, Jun 27 2016

Comment 8 Deleted

Comment 9 by addison@chromium.org, Jun 30 2016

Comment 9 Deleted

Comment 10 by xiaoyinh@chromium.org, Jun 30 2016

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Jun 30 2016

Comment 11 Deleted

Comment 12 by xiaoyinh@chromium.org, Jun 30 2016

Comment 12 Deleted

Comment 13 by dhadd...@chromium.org, Oct 18 2016

Comment 13 Deleted

Sign in to add a comment