New issue
Advanced search Search tips

Issue 611799 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: devtools.screenshot under emulation distort the results

Project Member Reported by paulir...@chromium.org, May 13 2016

Issue description

See attachment. 
- On the left is our device mode, viewing the site
- on the right, is a frame from disabled-by-default-devtools.screenshot while page is under  Emulation.setDeviceMetricsOverride

Looking over at https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/devtools/devtools_frame_trace_recorder.cc&q=%22devtools.screenshot%22&sq=package:chromium&type=cs&l=78

We are setting the size of the image to scrollable_viewport_size, but this doesn't account for any active emulation, and instead looks at overall desktop window size. dgozman identified that a separate property (which?) should have our correct viewport size.

caseq, can you look at this? 
 
Screen Shot 2016-05-13 at 10.45.37 AM.png
96.3 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, May 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0026aed1b09b9d4d06da3ddc402e995bf57bfad8

commit 0026aed1b09b9d4d06da3ddc402e995bf57bfad8
Author: caseq <caseq@chromium.org>
Date: Sat May 14 00:46:43 2016

DevTools: fix screenshot size when emulated viewport is smaller than root view

BUG= 611799 

Review-Url: https://codereview.chromium.org/1980673003
Cr-Commit-Position: refs/heads/master@{#393709}

[modify] https://crrev.com/0026aed1b09b9d4d06da3ddc402e995bf57bfad8/content/browser/devtools/devtools_frame_trace_recorder.cc

Status: Fixed (was: Assigned)
verified. thanks for the quick action. super awesome.

Sign in to add a comment