can't build 'all' in gn/mac builds because gn doesn't escape spaces when writing the 'all' phony in the toplevel ninja. |
||||||
Issue descriptionI figured I'd build all targets and then compare the list of tests in each gyp and gn binaries. I failed thusly: thakis-macpro:src thakis$ time ninja -C out/gn/ -k 0 ninja: Entering directory `out/gn/' ninja: error: 'obj/chrome/chrome_framework_shared_library/Chromium', needed by 'all', missing and no known rule to make it
,
May 13 2016
Oh, looks like gn doesn't escape spaces when writing the 'all' alias. From out/gn/build.ninja:
obj/chrome/chrome_framework_shared_library/Chromium Framework.TOC $
Note the unescaped space.
,
May 13 2016
Adding a bunch of $ in front of spaces in out/gn/build.ninja makes the build start. Tweaking title to include cause.
,
May 13 2016
Can you try and see if the latest (tip-of-tree) GN fixes this? warning: it'll break other things until https://codereview.chromium.org/1981443002/ lands. I'm not near a mac w/ a full build at the moment or I'd try it ...
,
May 13 2016
,
May 13 2016
I think my recent patch should have added the necessary escaping.
,
May 13 2016
Yes, this works with out/gn/gn. So only needs a gn roll. Thanks for the fix!
,
May 13 2016
,
May 14 2016
I will close this when the roll lands (and sticks).
,
Jun 8 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by thakis@chromium.org
, May 13 2016