[Media Router Action] Update action icons to handle (non-)retina |
||||||||||||||||||
Issue descriptionWith top Chrome going Material, we should handle retina/non-retina displays. At 100%, switch between 16x16 vs. 19x19 icon based on type of display. 1. Set #top-chrome-md to "Material". 2. Enable #media-router. 3. Download Cast extension. 4. Observe the icon in the extensions toolbar is blurry in non-retina, sharp in retina display.
,
May 13 2016
s/type of display/top-chrome-md option
,
May 18 2016
I've filed a request for the new icons.
,
Jul 28 2016
estade@ removed our icons in favor of vectors, so we no longer need new icons. We just need to scale action icons properly based on (non-)retina. https://codereview.chromium.org/2143863004/
,
Aug 23 2016
From offline conversation - we should see if updating the vectors to 16x16 would scale them properly. Trying to rescale the vectors may cause some distortion. Messaged bettes@ for new SVGs.
,
Aug 29 2016
bettes@ - per email thread - could we get new SVGs for cast? Thanks!
,
Sep 19 2016
Not sure what the status is here. Feel free to re-open this if necessary
,
Sep 23 2016
bettes - could we get 16x16 SVGs for all four Media Router icons? They're currently 19x19 and it'll look better if we don't try scaling them programmatically. There's also an email thread if easier to follow up there. Thanks!
,
Oct 6 2016
Is there an update on this? Is there a tool that can do this scaling automatically?
,
Oct 6 2016
Currently waiting for new SVGs. We could specify 16 (for dimension) on the CreateVectorIcon() call, but estade@ recommended against doing this since icons of this size would "need some hand-tweaking to make sure strokes and so forth land on exact pixel boundaries."
,
Oct 7 2016
SVGs with color guide attached https://drive.google.com/open?id=0BxMIIGI80eU-cG0wYUlYaXNKV3M
,
Oct 10 2016
Thanks bettes! Replacing the existing 19x19 icons for the new 16x16 SVGs (to .icon files) fixes this issue, and appears to scale upwards properly on other platforms so far (mac retina, non-retina, linux). I will have to spend some more time looking at all the cases before just swapping them out. If this works as is, it'll be great to avoid having duplicate .icon files. Attached are before/after screenshots on non-retina.
,
Oct 12 2016
I have the SVGs skiafied (mix of estade@'s tool and manual tweaks/drawing). The new .icon files have been tested against linux, windows, and osx (retina/non-retina). estade@ is the vector icons OWNER and currently OOO, but the fix is out for review.
,
Oct 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98acaca15019db2fae365cd186660ff8b9276ae0 commit 98acaca15019db2fae365cd186660ff8b9276ae0 Author: apacible <apacible@chromium.org> Date: Fri Oct 14 16:32:53 2016 [Media Router] Update toolbar icons to handle non-retina displays. This change updates the .icon dimensions from 19 to 16. This fixes an issue on non-retina displays where the icon is automatically scaled down, which makes the icons appear blurry. When the dimension is 16, the size auto-scales up for retina displays without blurring the image. The new icons were produced by a designer, and skiafied using estade@'s skiafy tool. Some manual tweaking done to the error icon. BUG= 611793 TEST=manual testing on osx (retina, non-retina), linux, windows for all four icons Review-Url: https://codereview.chromium.org/2412243002 Cr-Commit-Position: refs/heads/master@{#425350} [modify] https://crrev.com/98acaca15019db2fae365cd186660ff8b9276ae0/ui/gfx/vector_icons/media_router_active.icon [modify] https://crrev.com/98acaca15019db2fae365cd186660ff8b9276ae0/ui/gfx/vector_icons/media_router_error.icon [modify] https://crrev.com/98acaca15019db2fae365cd186660ff8b9276ae0/ui/gfx/vector_icons/media_router_idle.icon [modify] https://crrev.com/98acaca15019db2fae365cd186660ff8b9276ae0/ui/gfx/vector_icons/media_router_warning.icon
,
Oct 21 2016
Rechecked this issue for chrome version 56.0.2897.0 on Windows 10, MAC (Retina & Non retina) 10.11.6, Ubuntu 14.04. Icons do not look blurry. Attached are screen shots for the same. Note: Do not have a cast device hence cannot check the color guide as displayed in comment# 11. Could some one please check and confirm if this is sufficient, so that we can add TE-Verified labels. Thanks.!
,
Nov 17 2016
Manually tested active, warning, error cases on linux and osx (retina and non-retina). The fixed error icon is also reflected in canary in 56.
,
Nov 22 2016
|
||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||
Comment 1 by apaci...@chromium.org
, May 13 2016