New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 611747 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
calamity@chromium.org
twelling...@chromium.org
dbeam@chromium.org
█ tsergeant@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

BrowsingHistoryHandlerTest.MergeDuplicateResults flaky on Android

Project Member Reported by vasi...@chromium.org, May 13 2016 
Bot Android GN. Example https://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/34265

I  138.618s run_tests_on_device(0309f99208e4e26d)  [ RUN      ] BrowsingHistoryHandlerTest.MergeDuplicateResults
I  138.618s run_tests_on_device(0309f99208e4e26d)  ../../chrome/browser/ui/webui/browsing_history_handler_unittest.cc:68: Failure
I  138.618s run_tests_on_device(0309f99208e4e26d)  Value of: results.size()
I  138.619s run_tests_on_device(0309f99208e4e26d)    Actual: 3
I  138.619s run_tests_on_device(0309f99208e4e26d)  Expected: 2U
I  138.619s run_tests_on_device(0309f99208e4e26d)  Which is: 2
I  138.619s run_tests_on_device(0309f99208e4e26d)  [  FAILED  ] BrowsingHistoryHandlerTest.MergeDuplicateResults (0 ms)
Project Member

Comment 1 by bugdroid1@chromium.org, May 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b566ded991b42267ed6281fe4b761c48143168a6

commit b566ded991b42267ed6281fe4b761c48143168a6
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Fri May 13 15:24:37 2016

Disable flaky BrowsingHistoryHandlerTest.MergeDuplicateResults on Android.

BUG=611747
TBR=dbeam@chromium.org

Review URL: https://codereview.chromium.org/1976173002 .

Cr-Commit-Position: refs/heads/master@{#393528}

[modify] https://crrev.com/b566ded991b42267ed6281fe4b761c48143168a6/chrome/browser/ui/webui/browsing_history_handler_unittest.cc

Comment 2 by vasi...@chromium.org, May 13 2016

Owner: dbeam@chromium.org
Assigning to dbeam@chromium.org as the last reviewer of the relevant files.

Comment 3 by rsgav...@chromium.org, Jan 25 2017

Status: Assigned (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/899bc281768913fa13729754b9725d1feadd3c9c

commit 899bc281768913fa13729754b9725d1feadd3c9c
Author: dominickn <dominickn@chromium.org>
Date: Wed Feb 22 08:08:30 2017

Speculatively deflake BrowsingHistoryHandler::MergeDuplicateResults on Android.

This CL removes global time variables in browsing history tests, one of
which is unused. These variables were tripping a NOTREACHED() in the
implementation of base::Time::LocalMidnight() on Android, where the time
was being computed as null.

This speculatively deflakes the test on Android.

BUG=611747
TBR=dbeam@chromium.org

Review-Url: https://codereview.chromium.org/2704283002
Cr-Commit-Position: refs/heads/master@{#451919}

[modify] https://crrev.com/899bc281768913fa13729754b9725d1feadd3c9c/chrome/browser/history/browsing_history_service_unittest.cc
[modify] https://crrev.com/899bc281768913fa13729754b9725d1feadd3c9c/chrome/browser/ui/webui/browsing_history_handler_unittest.cc

Comment 5 by dbeam@chromium.org, May 4 2017

Cc: -xiy...@chromium.org -pam@chromium.org -bauerb@chromium.org -dpa...@chromium.org -michae...@chromium.org tsergeant@chromium.org calamity@chromium.org twelling...@chromium.org
Owner: ----
Status: Available (was: Assigned)

Comment 6 by dpranke@chromium.org, Jan 24 2018

Components: Tests>Disabled

Comment 7 by dpranke@chromium.org, Jan 24 2018

Labels: Test-Disabled
►

Sign in to add a comment