Address issues with page load metrics data loss due to logging in OnComplete |
|||||||
Issue descriptionAddress issues with page load metrics data loss due to logging in OnComplete
,
May 13 2016
,
May 13 2016
,
May 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a521d48e39c57ee5cb42326e9e50bd76dbb4bb2 commit 9a521d48e39c57ee5cb42326e9e50bd76dbb4bb2 Author: bmcquade <bmcquade@chromium.org> Date: Fri May 13 19:15:54 2016 Improved and generalized page load metric immediate event logging. Our current page load metric logging approach has been to log at the very end of the page lifecycle, in the PageLoadMetricsObserver OnComplete callback. This keeps metric logging logic simple, but has some costs. In particular, it means that metrics may be logged long after events were actually observed on a page load, which leads to metrics landing in the 'wrong' UMA record, and on Android we see >10% loss in logging and 7% skew in the mean, likely due to Android killing the browser process after backgrounding, leading to our code failing to log metrics for some pages. This patch introduces a class that makes it easy for us to log metrics immediately. In a follow up change, this class will be used to log additional metrics. BUG= 611740 Review-Url: https://codereview.chromium.org/1975963003 Cr-Commit-Position: refs/heads/master@{#393599} [modify] https://crrev.com/9a521d48e39c57ee5cb42326e9e50bd76dbb4bb2/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc [modify] https://crrev.com/9a521d48e39c57ee5cb42326e9e50bd76dbb4bb2/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h [modify] https://crrev.com/9a521d48e39c57ee5cb42326e9e50bd76dbb4bb2/components/page_load_metrics/browser/metrics_web_contents_observer.cc [modify] https://crrev.com/9a521d48e39c57ee5cb42326e9e50bd76dbb4bb2/components/page_load_metrics/browser/page_load_metrics_observer.h
,
May 17 2016
,
May 17 2016
,
May 17 2016
,
May 19 2016
The plan here is to change metrics to use immediate logging, and since the logging behavior has changed, rename these metrics. We will split metrics in the PageLoad.Timing2 category into 3 new sub-categories: PageLoad.PaintTiming, PageLoad.DocumentTiming, and PageLoad.ParseTiming.
,
May 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d930e1d05ae91d37b3ca5fb3fce4f0d3b13e208b commit d930e1d05ae91d37b3ca5fb3fce4f0d3b13e208b Author: bmcquade <bmcquade@chromium.org> Date: Fri May 20 16:11:09 2016 Update Timing2 to PaintTiming in comments. BUG= 611740 Review-Url: https://codereview.chromium.org/1993953003 Cr-Commit-Position: refs/heads/master@{#395084} [modify] https://crrev.com/d930e1d05ae91d37b3ca5fb3fce4f0d3b13e208b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc [modify] https://crrev.com/d930e1d05ae91d37b3ca5fb3fce4f0d3b13e208b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h [modify] https://crrev.com/d930e1d05ae91d37b3ca5fb3fce4f0d3b13e208b/tools/metrics/rappor/rappor.xml
,
Jul 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea728cb128c672e9cb9c99c16c00206575584d0a commit ea728cb128c672e9cb9c99c16c00206575584d0a Author: bmcquade <bmcquade@chromium.org> Date: Wed Jul 20 12:55:46 2016 Remove non-immediate core page load metrics This change removes the PageLoad.Timing2.* metrics, as they have been replaced with PageLoad.(Paint|Document|Parse)Timing.* equivalents. Additionally, histograms that use dom loading are removed, as it has been pointed out that dom loading is not well spec'd and has been marked as deprecated (https://github.com/w3c/navigation-timing/issues/13). This change does not obsolete these histograms in histograms.xml, as some experiments continue to depend on them and removing them from histograms.xml makes them inaccessible in the Finch dashboard. We'll remove these histograms from histograms.xml in a follow up change in a few releases, when everyone has migrated to the new metrics. A few PageLoad.Timing2.* metrics are not removed in this change. Those metrics will eventually need to be migrated to new names, but for the time being they do not have new equivalents, so we have not migrated them yet. BUG= 611740 Review-Url: https://codereview.chromium.org/2156093002 Cr-Commit-Position: refs/heads/master@{#406530} [modify] https://crrev.com/ea728cb128c672e9cb9c99c16c00206575584d0a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc [modify] https://crrev.com/ea728cb128c672e9cb9c99c16c00206575584d0a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h [modify] https://crrev.com/ea728cb128c672e9cb9c99c16c00206575584d0a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/ea728cb128c672e9cb9c99c16c00206575584d0a/tools/metrics/histograms/histograms.xml
,
Jul 28 2016
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bmcquade@chromium.org
, May 13 2016