New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 611687 link

Starred by 6 users
Status: Fixed
Owner:
noel@chromium.org
Closed: Sep 2017
Cc:
█ lushnikov@chromium.org
█ samli@chromium.org
█ tkonch...@chromium.org
█ ashej...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Feature
M62

Blocking:
issue 76362
issue 621538



Sign in to add a comment

feature request: support #RRGGBBAA and #RGBA colors in DevTools

Reported by l446240525@gmail.com, May 13 2016 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2734.0 Safari/537.36

Steps to reproduce the problem:
https://chromium.googlesource.com/chromium/src/+/bd42b3e0e1e52b1cbfe630ac7a4c230779111682

What is the expected behavior?

What went wrong?
Color fomats changing by Shift+Click should support #RRGGBBAA and #RGBA colors.

Did this work before? No 

Chrome version: 52.0.2734.0  Channel: n/a
OS Version: OS X 10.10.4
Flash Version: Shockwave Flash 22.0 r0
Color fomats changing.mp4
244 KB Download

Comment 1 Deleted

Comment 2 by ashej...@chromium.org, May 13 2016

Cc: ashej...@chromium.org
Labels: -Type-Bug Type-Feature
Status: Untriaged (was: Unconfirmed)
Marking the above request as Feature request and Untriaged.

Dev team will take a call on the above issue.

Thank you!

Comment 3 by samli@chromium.org, May 16 2016

Cc: noel@chromium.org

Comment 4 by dgozman@chromium.org, May 16 2016

Cc: lushnikov@chromium.org
@noel: would you like to follow up with DevTools changes here?

Comment 5 by noel@chromium.org, May 17 2016 

Nope sorry, as discussed with samli@ last Thurs / Friday, I have no time for this and asked if a dev tools person could help out. Possible?

Comment 6 by noel@chromium.org, May 17 2016

Cc: samli@chromium.org

Comment 7 by dgozman@chromium.org, May 19 2016

Cc: -samli@chromium.org
Owner: samli@chromium.org
Status: Assigned (was: Untriaged)
Looks like Sam has volunteered.

Comment 8 by samli@chromium.org, May 19 2016 

Can someone review it? Branch is tomorrow, otherwise we'd have to merge it to be in line with Blink support.

Comment 9 by noel@chromium.org, May 19 2016

Blocking: 76362
Project Member

Comment 10 by bugdroid1@chromium.org, May 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97c7757e7ae143f63e5d7281d1a9837338b12562

commit 97c7757e7ae143f63e5d7281d1a9837338b12562
Author: samli <samli@chromium.org>
Date: Wed May 25 04:25:44 2016

Devtools Color: Basic support for #RRGGBBAA and #RGBA

BUG= 611687 

Review-Url: https://codereview.chromium.org/1986053004
Cr-Commit-Position: refs/heads/master@{#395801}

[modify] https://crrev.com/97c7757e7ae143f63e5d7281d1a9837338b12562/third_party/WebKit/LayoutTests/inspector/components/color-expected.txt
[modify] https://crrev.com/97c7757e7ae143f63e5d7281d1a9837338b12562/third_party/WebKit/LayoutTests/inspector/components/color.html
[modify] https://crrev.com/97c7757e7ae143f63e5d7281d1a9837338b12562/third_party/WebKit/LayoutTests/inspector/elements/styles-3/spectrum-expected.txt
[modify] https://crrev.com/97c7757e7ae143f63e5d7281d1a9837338b12562/third_party/WebKit/LayoutTests/inspector/elements/styles-3/spectrum.html
[modify] https://crrev.com/97c7757e7ae143f63e5d7281d1a9837338b12562/third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-invalid-color-values-expected.txt
[modify] https://crrev.com/97c7757e7ae143f63e5d7281d1a9837338b12562/third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-invalid-color-values.html
[modify] https://crrev.com/97c7757e7ae143f63e5d7281d1a9837338b12562/third_party/WebKit/Source/devtools/front_end/common/Color.js
[modify] https://crrev.com/97c7757e7ae143f63e5d7281d1a9837338b12562/third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js
[modify] https://crrev.com/97c7757e7ae143f63e5d7281d1a9837338b12562/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
[modify] https://crrev.com/97c7757e7ae143f63e5d7281d1a9837338b12562/third_party/WebKit/Source/devtools/front_end/ui/ColorSwatch.js

Comment 11 by samli@chromium.org, May 25 2016

Labels: Merge-Request-52
Status: Fixed (was: Assigned)
Requesting merge to 52 to ensure Devtools support is in line with Blink support.

Comment 12 by tin...@google.com, May 26 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 13 by bugdroid1@chromium.org, May 26 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e65a18d32821324739e0511ae6b46b3514942387

commit e65a18d32821324739e0511ae6b46b3514942387
Author: Sam Li <samli@google.com>
Date: Thu May 26 03:55:14 2016

Devtools Color: Basic support for #RRGGBBAA and #RGBA

BUG= 611687 

Review-Url: https://codereview.chromium.org/1986053004
Cr-Commit-Position: refs/heads/master@{#395801}
(cherry picked from commit 97c7757e7ae143f63e5d7281d1a9837338b12562)

Review URL: https://codereview.chromium.org/2013003002 .

Cr-Commit-Position: refs/branch-heads/2743@{#72}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/e65a18d32821324739e0511ae6b46b3514942387/third_party/WebKit/LayoutTests/inspector/components/color-expected.txt
[modify] https://crrev.com/e65a18d32821324739e0511ae6b46b3514942387/third_party/WebKit/LayoutTests/inspector/components/color.html
[modify] https://crrev.com/e65a18d32821324739e0511ae6b46b3514942387/third_party/WebKit/LayoutTests/inspector/elements/styles-3/spectrum-expected.txt
[modify] https://crrev.com/e65a18d32821324739e0511ae6b46b3514942387/third_party/WebKit/LayoutTests/inspector/elements/styles-3/spectrum.html
[modify] https://crrev.com/e65a18d32821324739e0511ae6b46b3514942387/third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-invalid-color-values-expected.txt
[modify] https://crrev.com/e65a18d32821324739e0511ae6b46b3514942387/third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-invalid-color-values.html
[modify] https://crrev.com/e65a18d32821324739e0511ae6b46b3514942387/third_party/WebKit/Source/devtools/front_end/common/Color.js
[modify] https://crrev.com/e65a18d32821324739e0511ae6b46b3514942387/third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js
[modify] https://crrev.com/e65a18d32821324739e0511ae6b46b3514942387/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
[modify] https://crrev.com/e65a18d32821324739e0511ae6b46b3514942387/third_party/WebKit/Source/devtools/front_end/ui/ColorSwatch.js

Comment 14 by tkonch...@chromium.org, May 31 2016

Cc: tkonch...@chromium.org
Labels: Needs-Feedback
Tested the same on mac 10.11 chrome version 52.0.2743.19 - observed only rgb colors changing on clicking shift+click before and after the fix.

Please find the screencast

samli@, Could you please confirm on the expected behavior.
611687.mov
14.4 MB Download

Comment 15 by jonathan.garbee@chromium.org, May 31 2016 

LGTM in 53.0.2754.0. Even working well with the color palette.

Comment 16 by rbyers@chromium.org, Jun 20 2016

Blocking: 621538
Project Member

Comment 17 by bugdroid1@chromium.org, Jul 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c404fce6e03e11f64b4e136f3aa533f33ddaecad

commit c404fce6e03e11f64b4e136f3aa533f33ddaecad
Author: luoe <luoe@chromium.org>
Date: Wed Jul 27 16:48:39 2016

Revert of Devtools Color: Basic support for #RRGGBBAA and #RGBA (patchset #4 id:80001 of https://codereview.chromium.org/1986053004/ )

Reason for revert:
[DevTools] Entering a HEX value into color picker and changing opacity results in an 8-digit HEX, currently seen as invalid.

This should reland once 8-digit hex (#rrggbbaa) is a fully supported value for colors (once #76362 lands).

Original issue's description:
> Devtools Color: Basic support for #RRGGBBAA and #RGBA
>
> BUG= 611687 
>
> Committed: https://crrev.com/97c7757e7ae143f63e5d7281d1a9837338b12562
> Cr-Commit-Position: refs/heads/master@{#395801}

TBR=dgozman@chromium.org,lushnikov@chromium.org,noel@chromium.org,pfeldman@chromium.org,samli@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=630808

Review-Url: https://codereview.chromium.org/2186773002
Cr-Commit-Position: refs/heads/master@{#408153}

[modify] https://crrev.com/c404fce6e03e11f64b4e136f3aa533f33ddaecad/third_party/WebKit/LayoutTests/inspector/components/color-expected.txt
[modify] https://crrev.com/c404fce6e03e11f64b4e136f3aa533f33ddaecad/third_party/WebKit/LayoutTests/inspector/components/color.html
[modify] https://crrev.com/c404fce6e03e11f64b4e136f3aa533f33ddaecad/third_party/WebKit/LayoutTests/inspector/elements/styles-3/spectrum-expected.txt
[modify] https://crrev.com/c404fce6e03e11f64b4e136f3aa533f33ddaecad/third_party/WebKit/LayoutTests/inspector/elements/styles-3/spectrum.html
[modify] https://crrev.com/c404fce6e03e11f64b4e136f3aa533f33ddaecad/third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-invalid-color-values-expected.txt
[modify] https://crrev.com/c404fce6e03e11f64b4e136f3aa533f33ddaecad/third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-invalid-color-values.html
[modify] https://crrev.com/c404fce6e03e11f64b4e136f3aa533f33ddaecad/third_party/WebKit/Source/devtools/front_end/common/Color.js
[modify] https://crrev.com/c404fce6e03e11f64b4e136f3aa533f33ddaecad/third_party/WebKit/Source/devtools/front_end/components/Spectrum.js
[modify] https://crrev.com/c404fce6e03e11f64b4e136f3aa533f33ddaecad/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
[modify] https://crrev.com/c404fce6e03e11f64b4e136f3aa533f33ddaecad/third_party/WebKit/Source/devtools/front_end/ui/ColorSwatch.js

Comment 18 by noel@chromium.org, Jul 12 2017

Cc: -noel@chromium.org samli@chromium.org
Labels: OS-Linux OS-Windows
Owner: noel@chromium.org
Status: Assigned (was: Fixed)

Comment 19 by noel@chromium.org, Jul 13 2017 

lushnikov@ I've upload a patch [1] to recover this work, possible for you to re-review please?  

[1] https://chromium-review.googlesource.com/c/567841
Project Member

Comment 20 by bugdroid1@chromium.org, Jul 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b57665fd1db6ae64c4809f2c66eba1538f7e21d

commit 5b57665fd1db6ae64c4809f2c66eba1538f7e21d
Author: Noel Gordon <noel@chromium.org>
Date: Thu Jul 27 00:35:22 2017

Devtools: Support 8 (#RRGGBBAA) and 4 (#RGBA) value hex colors

Recover the patch (reverted on  issue 621538 ) to add support for CSS
8 and 4 hex color [1]. Re-work that patch into devtools current and
update inspector layout tests.

[1] https://codereview.chromium.org/1986053004

Bug:  76362 ,  611687 
Change-Id: I8adbd9c67f5960481759ec097817196e874355ef
Reviewed-on: https://chromium-review.googlesource.com/567841
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489813}
[modify] https://crrev.com/5b57665fd1db6ae64c4809f2c66eba1538f7e21d/third_party/WebKit/LayoutTests/inspector/components/color-expected.txt
[modify] https://crrev.com/5b57665fd1db6ae64c4809f2c66eba1538f7e21d/third_party/WebKit/LayoutTests/inspector/components/color.html
[modify] https://crrev.com/5b57665fd1db6ae64c4809f2c66eba1538f7e21d/third_party/WebKit/LayoutTests/inspector/elements/styles-3/spectrum-expected.txt
[modify] https://crrev.com/5b57665fd1db6ae64c4809f2c66eba1538f7e21d/third_party/WebKit/LayoutTests/inspector/elements/styles-3/spectrum.html
[modify] https://crrev.com/5b57665fd1db6ae64c4809f2c66eba1538f7e21d/third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-invalid-color-values-expected.txt
[modify] https://crrev.com/5b57665fd1db6ae64c4809f2c66eba1538f7e21d/third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-invalid-color-values.html
[modify] https://crrev.com/5b57665fd1db6ae64c4809f2c66eba1538f7e21d/third_party/WebKit/Source/devtools/front_end/color_picker/Spectrum.js
[modify] https://crrev.com/5b57665fd1db6ae64c4809f2c66eba1538f7e21d/third_party/WebKit/Source/devtools/front_end/common/Color.js
[modify] https://crrev.com/5b57665fd1db6ae64c4809f2c66eba1538f7e21d/third_party/WebKit/Source/devtools/front_end/inline_editor/ColorSwatch.js

Comment 21 by dgozman@chromium.org, Sep 21 2017 

Should we mark this as fixed?

Comment 22 by noel@chromium.org, Sep 21 2017

Status: Fixed (was: Assigned)
Yes, M62 -> it's on beta channel right now, so it's been active for 12 weeks with no complaints so far.

Comment 23 by noel@chromium.org, Sep 21 2017

Labels: M62
►

Sign in to add a comment