New issue
Advanced search Search tips

Issue 611661 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 581524



Sign in to add a comment

Rename OwnPtr::clear() to reset()

Project Member Reported by yutak@chromium.org, May 13 2016

Issue description

Sub-step of  bug 581524 .
 

Comment 1 by yutak@chromium.org, May 24 2016

I think "all members" in the title should be just "clear()", since the name of
the other member function leakPtr() is unique enough and its usage is somewhat
rare.

Comment 2 by yutak@chromium.org, May 24 2016

Status: Started (was: Assigned)
Summary: Rename OwnPtr::clear() to reset() (was: Rename all members of OwnPtr to match std::unique_ptr)
Renaming the title.

We at least need to rename clear() since that name is used in other places and
the simple grep-and-replace method would not work.
Project Member

Comment 3 by bugdroid1@chromium.org, May 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e538ecb8f6819b5b39ec8146b9ae566f519a939

commit 9e538ecb8f6819b5b39ec8146b9ae566f519a939
Author: yutak <yutak@chromium.org>
Date: Tue May 24 13:27:58 2016

OwnPtr: Add reset() as an alias of clear().

We are planning to rename OwnPtr::clear() to reset(), as a part of
OwnPtr -> std::unique_ptr migration.

This patch adds a new member function reset() that is an alias of
clear() in order to facilitate the rename process. Eventually reset()
will take over clear().

BUG= 611661 

Review-Url: https://codereview.chromium.org/2004383002
Cr-Commit-Position: refs/heads/master@{#395586}

[modify] https://crrev.com/9e538ecb8f6819b5b39ec8146b9ae566f519a939/third_party/WebKit/Source/wtf/OwnPtr.h

Project Member

Comment 5 by bugdroid1@chromium.org, May 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c9532ef259fc4961a7c9e4220ec88ef3f1dea95

commit 7c9532ef259fc4961a7c9e4220ec88ef3f1dea95
Author: yutak <yutak@chromium.org>
Date: Wed May 25 08:38:11 2016

Rename OwnPtr::clear() to reset() in web/.

OwnPtr::clear() will soon get renamed to reset() as a part of
OwnPtr-to-std::unique_ptr migration.

BUG= 611661 

Review-Url: https://codereview.chromium.org/2014493002
Cr-Commit-Position: refs/heads/master@{#395834}

[modify] https://crrev.com/7c9532ef259fc4961a7c9e4220ec88ef3f1dea95/third_party/WebKit/Source/web/AssociatedURLLoader.cpp
[modify] https://crrev.com/7c9532ef259fc4961a7c9e4220ec88ef3f1dea95/third_party/WebKit/Source/web/DevToolsEmulator.cpp
[modify] https://crrev.com/7c9532ef259fc4961a7c9e4220ec88ef3f1dea95/third_party/WebKit/Source/web/ExternalPopupMenu.cpp
[modify] https://crrev.com/7c9532ef259fc4961a7c9e4220ec88ef3f1dea95/third_party/WebKit/Source/web/InspectorOverlay.cpp
[modify] https://crrev.com/7c9532ef259fc4961a7c9e4220ec88ef3f1dea95/third_party/WebKit/Source/web/LinkHighlightImpl.cpp
[modify] https://crrev.com/7c9532ef259fc4961a7c9e4220ec88ef3f1dea95/third_party/WebKit/Source/web/WebDataSourceImpl.cpp
[modify] https://crrev.com/7c9532ef259fc4961a7c9e4220ec88ef3f1dea95/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/7c9532ef259fc4961a7c9e4220ec88ef3f1dea95/third_party/WebKit/Source/web/tests/SpinLockTest.cpp
[modify] https://crrev.com/7c9532ef259fc4961a7c9e4220ec88ef3f1dea95/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[modify] https://crrev.com/7c9532ef259fc4961a7c9e4220ec88ef3f1dea95/third_party/WebKit/Source/web/tests/WebHelperPluginTest.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, May 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27d5d23aba040d384b0e9bc524144e59a6cd0403

commit 27d5d23aba040d384b0e9bc524144e59a6cd0403
Author: yutak <yutak@chromium.org>
Date: Wed May 25 09:38:28 2016

Rename OwnPtr::clear() to reset() in wtf/.

OwnPtr::clear() will soon get renamed to reset() as a part of
OwnPtr-to-std::unique_ptr migration.

BUG= 611661 

Review-Url: https://codereview.chromium.org/2011813002
Cr-Commit-Position: refs/heads/master@{#395842}

[modify] https://crrev.com/27d5d23aba040d384b0e9bc524144e59a6cd0403/third_party/WebKit/Source/wtf/DequeTest.cpp
[modify] https://crrev.com/27d5d23aba040d384b0e9bc524144e59a6cd0403/third_party/WebKit/Source/wtf/HashMapTest.cpp
[modify] https://crrev.com/27d5d23aba040d384b0e9bc524144e59a6cd0403/third_party/WebKit/Source/wtf/VectorTest.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, May 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93dc52fb86054e3a8cddc66092d8415cab5d0317

commit 93dc52fb86054e3a8cddc66092d8415cab5d0317
Author: yutak <yutak@chromium.org>
Date: Wed May 25 09:39:49 2016

Rename OwnPtr::clear() to reset() in platform/.

OwnPtr::clear() will soon get renamed to reset() as a part of
OwnPtr-to-std::unique_ptr migration.

BUG= 611661 

Review-Url: https://codereview.chromium.org/2011783002
Cr-Commit-Position: refs/heads/master@{#395843}

[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/WebThreadSupportingGC.cpp
[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/animation/CompositorFilterKeyframe.cpp
[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/animation/CompositorTransformKeyframe.cpp
[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/audio/AudioChannel.h
[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/audio/HRTFDatabaseLoader.cpp
[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/audio/ReverbConvolver.cpp
[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/geometry/TransformState.cpp
[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/graphics/BitmapImage.cpp
[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp
[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp
[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp
[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp
[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp
[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp
[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp
[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoder.cpp
[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp
[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp
[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.h
[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.cpp
[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoder.cpp
[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/mediastream/MediaStreamComponent.cpp
[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.cpp
[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp
[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp
[modify] https://crrev.com/93dc52fb86054e3a8cddc66092d8415cab5d0317/third_party/WebKit/Source/platform/weborigin/KURL.cpp

Project Member

Comment 8 by bugdroid1@chromium.org, May 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d938c84f9c810959c909ace645a3ad0e5c01952

commit 2d938c84f9c810959c909ace645a3ad0e5c01952
Author: yutak <yutak@chromium.org>
Date: Wed May 25 09:54:00 2016

Rename OwnPtr::clear() to reset() in core/.

OwnPtr::clear() will soon get renamed to reset() as a part of
OwnPtr-to-std::unique_ptr migration.

BUG= 611661 

Review-Url: https://codereview.chromium.org/2014483003
Cr-Commit-Position: refs/heads/master@{#395848}

[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/animation/Animation.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/animation/InterpolationValue.h
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/animation/InvalidatableInterpolation.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/css/MediaQueryEvaluatorTest.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/css/SelectorFilter.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/css/parser/CSSParserSelector.h
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/dom/ExecutionContext.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/fetch/FontResource.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/html/canvas/CanvasFontCache.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/html/parser/TextResourceDecoder.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/layout/ClipPathOperation.h
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/layout/LayoutBox.h
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/layout/LayoutIFrame.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/layout/LayoutMultiColumnSpannerPlaceholder.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/layout/LayoutReplaced.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/layout/LayoutView.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.h
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.h
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/page/ContextMenuController.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/paint/PaintLayer.cpp
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/paint/PaintLayer.h
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/paint/PaintLayerStackingNode.h
[modify] https://crrev.com/2d938c84f9c810959c909ace645a3ad0e5c01952/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

Project Member

Comment 9 by bugdroid1@chromium.org, May 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97c04786a05650b8a010b21eaa9bf1830b119900

commit 97c04786a05650b8a010b21eaa9bf1830b119900
Author: yutak <yutak@chromium.org>
Date: Wed May 25 17:12:22 2016

Rename OwnPtr::clear() to reset() in modules/.

OwnPtr::clear() will soon get renamed to reset() as a part of
OwnPtr-to-std::unique_ptr migration.

BUG= 611661 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2007983006
Cr-Commit-Position: refs/heads/master@{#395916}

[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/csspaint/PaintWorkletTest.cpp
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/fetch/CrossThreadHolder.h
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/fetch/FetchDataLoader.cpp
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/indexeddb/IDBCursor.cpp
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/indexeddb/IDBCursor.h
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/mediasource/MediaSource.cpp
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/mediastream/RTCDTMFSender.cpp
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/mediastream/RTCDataChannel.cpp
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/webdatabase/SQLTransactionBackend.cpp
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/webmidi/MIDIAccess.cpp
[modify] https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp

Project Member

Comment 10 by bugdroid1@chromium.org, May 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6845561457d7391db78d2a025de9aa02bb5f7f33

commit 6845561457d7391db78d2a025de9aa02bb5f7f33
Author: yutak <yutak@chromium.org>
Date: Fri May 27 07:31:53 2016

Rename OwnPtr::clear() to reset().

The function is renamed to prepare for OwnPtr-to-std::unique_ptr
migration.

BUG= 611661 

Review-Url: https://codereview.chromium.org/2012203002
Cr-Commit-Position: refs/heads/master@{#396418}

[modify] https://crrev.com/6845561457d7391db78d2a025de9aa02bb5f7f33/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
[modify] https://crrev.com/6845561457d7391db78d2a025de9aa02bb5f7f33/third_party/WebKit/Source/wtf/OwnPtr.h

Comment 11 by yutak@chromium.org, May 30 2016

Status: Fixed (was: Started)

Comment 12 by tkent@chromium.org, Jun 23 2016

Components: -Blink>WTF Blink>Internals>WTF
Renaming Blink>WTF to Blink>Internals>WTF.

Comment 13 by tkent@chromium.org, Jun 23 2016

Components: -Blink>Architecture Blink>Internals
Renaming Blink>Architecture to Blink>Internals

Sign in to add a comment