New issue
Advanced search Search tips

Issue 611660 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 581524



Sign in to add a comment

Remove OwnPtr::release()

Project Member Reported by yutak@chromium.org, May 13 2016

Issue description

Replace it with std::move(). It can be confused with
std::unique_ptr<T>::release() (which is semantically equivalent to
OwnPtr<T>::leakPtr()).
 
Project Member

Comment 2 by bugdroid1@chromium.org, May 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40d965d63504a9446ec8d67b4663d7f18e066e0b

commit 40d965d63504a9446ec8d67b4663d7f18e066e0b
Author: yutak <yutak@chromium.org>
Date: Mon May 16 07:47:01 2016

Remove OwnPtr::release() calls in core/ (part 1).

OwnPtr::release() calls can be (1) replaced with std::move(), or
(2) removed entirely (in certain "return" statements).

BUG= 611660 

Review-Url: https://codereview.chromium.org/1977763002
Cr-Commit-Position: refs/heads/master@{#393804}

[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/Animation.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/BasicShapeInterpolationFunctions.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/CSSBorderImageLengthBoxInterpolationType.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/CSSFilterListInterpolationType.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/CSSFontSizeInterpolationType.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/CSSImageSliceInterpolationType.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/CSSMotionRotationInterpolationType.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/InterpolableValue.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/InterpolableValueTest.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/InterpolationType.h
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/InterpolationValue.h
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/InvalidatableInterpolation.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/ListInterpolationFunctions.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/ListInterpolationFunctions.h
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/PairwiseInterpolationValue.h
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/PathInterpolationFunctions.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/SVGIntegerOptionalIntegerInterpolationType.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/SVGLengthInterpolationType.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/SVGLengthListInterpolationType.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/SVGNumberListInterpolationType.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/SVGNumberOptionalNumberInterpolationType.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/SVGPathSegInterpolationFunctions.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/SVGPointListInterpolationType.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/SVGRectInterpolationType.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/ShadowInterpolationFunctions.cpp
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/TypedInterpolationValue.h
[modify] https://crrev.com/40d965d63504a9446ec8d67b4663d7f18e066e0b/third_party/WebKit/Source/core/animation/animatable/AnimatablePath.cpp

Project Member

Comment 3 by bugdroid1@chromium.org, May 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/231b0e9da999b2a8bea57ebb8874296104bcd0be

commit 231b0e9da999b2a8bea57ebb8874296104bcd0be
Author: yutak <yutak@chromium.org>
Date: Mon May 16 07:47:49 2016

Remove OwnPtr::release() calls in core/ (part 4).

OwnPtr::release() calls can be (1) replaced with std::move(), or
(2) removed entirely (in certain "return" statements).

BUG= 611660 

Review-Url: https://codereview.chromium.org/1980893002
Cr-Commit-Position: refs/heads/master@{#393805}

[modify] https://crrev.com/231b0e9da999b2a8bea57ebb8874296104bcd0be/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
[modify] https://crrev.com/231b0e9da999b2a8bea57ebb8874296104bcd0be/third_party/WebKit/Source/core/loader/DocumentWriter.cpp
[modify] https://crrev.com/231b0e9da999b2a8bea57ebb8874296104bcd0be/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/231b0e9da999b2a8bea57ebb8874296104bcd0be/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/231b0e9da999b2a8bea57ebb8874296104bcd0be/third_party/WebKit/Source/core/loader/TextResourceDecoderBuilder.cpp
[modify] https://crrev.com/231b0e9da999b2a8bea57ebb8874296104bcd0be/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp
[modify] https://crrev.com/231b0e9da999b2a8bea57ebb8874296104bcd0be/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/231b0e9da999b2a8bea57ebb8874296104bcd0be/third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp
[modify] https://crrev.com/231b0e9da999b2a8bea57ebb8874296104bcd0be/third_party/WebKit/Source/core/page/scrolling/ScrollStateTest.cpp
[modify] https://crrev.com/231b0e9da999b2a8bea57ebb8874296104bcd0be/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
[modify] https://crrev.com/231b0e9da999b2a8bea57ebb8874296104bcd0be/third_party/WebKit/Source/core/paint/FilterPainter.cpp
[modify] https://crrev.com/231b0e9da999b2a8bea57ebb8874296104bcd0be/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
[modify] https://crrev.com/231b0e9da999b2a8bea57ebb8874296104bcd0be/third_party/WebKit/Source/core/style/ContentData.h
[modify] https://crrev.com/231b0e9da999b2a8bea57ebb8874296104bcd0be/third_party/WebKit/Source/core/style/CounterDirectives.cpp
[modify] https://crrev.com/231b0e9da999b2a8bea57ebb8874296104bcd0be/third_party/WebKit/Source/core/style/ShadowList.cpp
[modify] https://crrev.com/231b0e9da999b2a8bea57ebb8874296104bcd0be/third_party/WebKit/Source/core/svg/SVGPath.cpp
[modify] https://crrev.com/231b0e9da999b2a8bea57ebb8874296104bcd0be/third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.cpp
[modify] https://crrev.com/231b0e9da999b2a8bea57ebb8874296104bcd0be/third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp
[modify] https://crrev.com/231b0e9da999b2a8bea57ebb8874296104bcd0be/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp
[modify] https://crrev.com/231b0e9da999b2a8bea57ebb8874296104bcd0be/third_party/WebKit/Source/core/workers/SharedWorker.cpp
[modify] https://crrev.com/231b0e9da999b2a8bea57ebb8874296104bcd0be/third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.cpp
[modify] https://crrev.com/231b0e9da999b2a8bea57ebb8874296104bcd0be/third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp
[modify] https://crrev.com/231b0e9da999b2a8bea57ebb8874296104bcd0be/third_party/WebKit/Source/core/workers/WorkerScriptLoader.h
[modify] https://crrev.com/231b0e9da999b2a8bea57ebb8874296104bcd0be/third_party/WebKit/Source/core/workers/WorkerThread.cpp
[modify] https://crrev.com/231b0e9da999b2a8bea57ebb8874296104bcd0be/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
[modify] https://crrev.com/231b0e9da999b2a8bea57ebb8874296104bcd0be/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, May 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02fe34d8ada84b71beff44331fe7b971b0390ccc

commit 02fe34d8ada84b71beff44331fe7b971b0390ccc
Author: yutak <yutak@chromium.org>
Date: Mon May 16 07:48:38 2016

Remove OwnPtr::release() calls in modules/ (part 3).

OwnPtr::release() calls can be (1) replaced with std::move(), or
(2) removed entirely (in certain "return" statements).

BUG= 611660 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/1979953002
Cr-Commit-Position: refs/heads/master@{#393806}

[modify] https://crrev.com/02fe34d8ada84b71beff44331fe7b971b0390ccc/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp
[modify] https://crrev.com/02fe34d8ada84b71beff44331fe7b971b0390ccc/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp
[modify] https://crrev.com/02fe34d8ada84b71beff44331fe7b971b0390ccc/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp
[modify] https://crrev.com/02fe34d8ada84b71beff44331fe7b971b0390ccc/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp
[modify] https://crrev.com/02fe34d8ada84b71beff44331fe7b971b0390ccc/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp
[modify] https://crrev.com/02fe34d8ada84b71beff44331fe7b971b0390ccc/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h
[modify] https://crrev.com/02fe34d8ada84b71beff44331fe7b971b0390ccc/third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.cpp
[modify] https://crrev.com/02fe34d8ada84b71beff44331fe7b971b0390ccc/third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp
[modify] https://crrev.com/02fe34d8ada84b71beff44331fe7b971b0390ccc/third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp
[modify] https://crrev.com/02fe34d8ada84b71beff44331fe7b971b0390ccc/third_party/WebKit/Source/modules/webaudio/PeriodicWave.cpp
[modify] https://crrev.com/02fe34d8ada84b71beff44331fe7b971b0390ccc/third_party/WebKit/Source/modules/webdatabase/Database.cpp
[modify] https://crrev.com/02fe34d8ada84b71beff44331fe7b971b0390ccc/third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp
[modify] https://crrev.com/02fe34d8ada84b71beff44331fe7b971b0390ccc/third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseResource.cpp
[modify] https://crrev.com/02fe34d8ada84b71beff44331fe7b971b0390ccc/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp
[modify] https://crrev.com/02fe34d8ada84b71beff44331fe7b971b0390ccc/third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.cpp
[modify] https://crrev.com/02fe34d8ada84b71beff44331fe7b971b0390ccc/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/02fe34d8ada84b71beff44331fe7b971b0390ccc/third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp
[modify] https://crrev.com/02fe34d8ada84b71beff44331fe7b971b0390ccc/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp
[modify] https://crrev.com/02fe34d8ada84b71beff44331fe7b971b0390ccc/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp
[modify] https://crrev.com/02fe34d8ada84b71beff44331fe7b971b0390ccc/third_party/WebKit/Source/modules/websockets/InspectorWebSocketEvents.cpp
[modify] https://crrev.com/02fe34d8ada84b71beff44331fe7b971b0390ccc/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, May 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ad8f55720c66f440646d139b0fdeb78e2d6296b

commit 3ad8f55720c66f440646d139b0fdeb78e2d6296b
Author: yutak <yutak@chromium.org>
Date: Mon May 16 07:49:32 2016

Remove OwnPtr::release() calls in modules/ (part 1).

OwnPtr::release() calls can be (1) replaced with std::move(), or
(2) removed entirely (in certain "return" statements).

BUG= 611660 

Review-Url: https://codereview.chromium.org/1983783002
Cr-Commit-Position: refs/heads/master@{#393807}

[modify] https://crrev.com/3ad8f55720c66f440646d139b0fdeb78e2d6296b/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
[modify] https://crrev.com/3ad8f55720c66f440646d139b0fdeb78e2d6296b/third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp
[modify] https://crrev.com/3ad8f55720c66f440646d139b0fdeb78e2d6296b/third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp
[modify] https://crrev.com/3ad8f55720c66f440646d139b0fdeb78e2d6296b/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp
[modify] https://crrev.com/3ad8f55720c66f440646d139b0fdeb78e2d6296b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp
[modify] https://crrev.com/3ad8f55720c66f440646d139b0fdeb78e2d6296b/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerGlobalScope.cpp
[modify] https://crrev.com/3ad8f55720c66f440646d139b0fdeb78e2d6296b/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp
[modify] https://crrev.com/3ad8f55720c66f440646d139b0fdeb78e2d6296b/third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp
[modify] https://crrev.com/3ad8f55720c66f440646d139b0fdeb78e2d6296b/third_party/WebKit/Source/modules/fetch/Body.cpp
[modify] https://crrev.com/3ad8f55720c66f440646d139b0fdeb78e2d6296b/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp
[modify] https://crrev.com/3ad8f55720c66f440646d139b0fdeb78e2d6296b/third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp
[modify] https://crrev.com/3ad8f55720c66f440646d139b0fdeb78e2d6296b/third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandle.h
[modify] https://crrev.com/3ad8f55720c66f440646d139b0fdeb78e2d6296b/third_party/WebKit/Source/modules/fetch/CompositeDataConsumerHandleTest.cpp
[modify] https://crrev.com/3ad8f55720c66f440646d139b0fdeb78e2d6296b/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp
[modify] https://crrev.com/3ad8f55720c66f440646d139b0fdeb78e2d6296b/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h
[modify] https://crrev.com/3ad8f55720c66f440646d139b0fdeb78e2d6296b/third_party/WebKit/Source/modules/fetch/DataConsumerTee.cpp
[modify] https://crrev.com/3ad8f55720c66f440646d139b0fdeb78e2d6296b/third_party/WebKit/Source/modules/fetch/DataConsumerTeeTest.cpp
[modify] https://crrev.com/3ad8f55720c66f440646d139b0fdeb78e2d6296b/third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandleTest.cpp
[modify] https://crrev.com/3ad8f55720c66f440646d139b0fdeb78e2d6296b/third_party/WebKit/Source/modules/fetch/FetchDataLoader.cpp
[modify] https://crrev.com/3ad8f55720c66f440646d139b0fdeb78e2d6296b/third_party/WebKit/Source/modules/fetch/FetchDataLoaderTest.cpp
[modify] https://crrev.com/3ad8f55720c66f440646d139b0fdeb78e2d6296b/third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandle.cpp
[modify] https://crrev.com/3ad8f55720c66f440646d139b0fdeb78e2d6296b/third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp
[modify] https://crrev.com/3ad8f55720c66f440646d139b0fdeb78e2d6296b/third_party/WebKit/Source/modules/fetch/FetchRequestData.cpp
[modify] https://crrev.com/3ad8f55720c66f440646d139b0fdeb78e2d6296b/third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp
[modify] https://crrev.com/3ad8f55720c66f440646d139b0fdeb78e2d6296b/third_party/WebKit/Source/modules/fetch/Request.cpp
[modify] https://crrev.com/3ad8f55720c66f440646d139b0fdeb78e2d6296b/third_party/WebKit/Source/modules/fetch/Response.cpp
[modify] https://crrev.com/3ad8f55720c66f440646d139b0fdeb78e2d6296b/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, May 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/995cd784dac8a41053410ca3fae7f7b57cd4ebad

commit 995cd784dac8a41053410ca3fae7f7b57cd4ebad
Author: yutak <yutak@chromium.org>
Date: Mon May 16 07:50:26 2016

Remove OwnPtr::release() calls in core/ (part 2).

OwnPtr::release() calls can be (1) replaced with std::move(), or
(2) removed entirely (in certain "return" statements).

BUG= 611660 

Review-Url: https://codereview.chromium.org/1983753002
Cr-Commit-Position: refs/heads/master@{#393808}

[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/css/CSSPathValue.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/css/cssom/MatrixTransformComponent.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/css/parser/CSSParserSelector.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/css/parser/CSSParserSelector.h
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/css/resolver/StyleResolverStats.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/dom/DecodedDataDocumentParser.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/dom/MessagePort.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/events/MessageEvent.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/fileapi/Blob.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/fileapi/File.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/frame/DOMWindow.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/html/forms/FormController.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/html/forms/InputType.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/html/parser/HTMLToken.h
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/html/parser/ResourcePreloader.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp
[modify] https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad/third_party/WebKit/Source/core/input/EventHandler.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eee484351c4a0e22227b45f62b2c19a6fdcd582b

commit eee484351c4a0e22227b45f62b2c19a6fdcd582b
Author: yutak <yutak@chromium.org>
Date: Tue May 17 04:54:27 2016

Remove OwnPtr::release() calls in modules/ (part 2).

OwnPtr::release() calls can be (1) replaced with std::move(), or
(2) removed entirely (in certain "return" statements).

BUG= 611660 

Review-Url: https://codereview.chromium.org/1978173002
Cr-Commit-Position: refs/heads/master@{#394053}

[modify] https://crrev.com/eee484351c4a0e22227b45f62b2c19a6fdcd582b/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp
[modify] https://crrev.com/eee484351c4a0e22227b45f62b2c19a6fdcd582b/third_party/WebKit/Source/modules/filesystem/DOMFileSystemBase.cpp
[modify] https://crrev.com/eee484351c4a0e22227b45f62b2c19a6fdcd582b/third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.cpp
[modify] https://crrev.com/eee484351c4a0e22227b45f62b2c19a6fdcd582b/third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp
[modify] https://crrev.com/eee484351c4a0e22227b45f62b2c19a6fdcd582b/third_party/WebKit/Source/modules/filesystem/WorkerGlobalScopeFileSystem.cpp
[modify] https://crrev.com/eee484351c4a0e22227b45f62b2c19a6fdcd582b/third_party/WebKit/Source/modules/indexeddb/IDBRequestTest.cpp
[modify] https://crrev.com/eee484351c4a0e22227b45f62b2c19a6fdcd582b/third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp
[modify] https://crrev.com/eee484351c4a0e22227b45f62b2c19a6fdcd582b/third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp
[modify] https://crrev.com/eee484351c4a0e22227b45f62b2c19a6fdcd582b/third_party/WebKit/Source/modules/mediacapturefromelement/HTMLCanvasElementCapture.cpp
[modify] https://crrev.com/eee484351c4a0e22227b45f62b2c19a6fdcd582b/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp
[modify] https://crrev.com/eee484351c4a0e22227b45f62b2c19a6fdcd582b/third_party/WebKit/Source/modules/mediasession/MediaSession.cpp
[modify] https://crrev.com/eee484351c4a0e22227b45f62b2c19a6fdcd582b/third_party/WebKit/Source/modules/mediasource/MediaSource.cpp
[modify] https://crrev.com/eee484351c4a0e22227b45f62b2c19a6fdcd582b/third_party/WebKit/Source/modules/mediastream/RTCDTMFSender.cpp
[modify] https://crrev.com/eee484351c4a0e22227b45f62b2c19a6fdcd582b/third_party/WebKit/Source/modules/mediastream/RTCDataChannel.cpp
[modify] https://crrev.com/eee484351c4a0e22227b45f62b2c19a6fdcd582b/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp
[modify] https://crrev.com/eee484351c4a0e22227b45f62b2c19a6fdcd582b/third_party/WebKit/Source/modules/permissions/Permissions.cpp
[modify] https://crrev.com/eee484351c4a0e22227b45f62b2c19a6fdcd582b/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
[modify] https://crrev.com/eee484351c4a0e22227b45f62b2c19a6fdcd582b/third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp
[modify] https://crrev.com/eee484351c4a0e22227b45f62b2c19a6fdcd582b/third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp

Project Member

Comment 8 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20cd5a39df58894c38a6581bd40ae3bfa0d37c8c

commit 20cd5a39df58894c38a6581bd40ae3bfa0d37c8c
Author: yutak <yutak@chromium.org>
Date: Tue May 17 05:18:02 2016

Remove OwnPtr::release() calls in platform/ (part 2).

OwnPtr::release() calls can be (1) replaced with std::move(), or
(2) removed entirely (in certain "return" statements).

BUG= 611660 

Review-Url: https://codereview.chromium.org/1983793002
Cr-Commit-Position: refs/heads/master@{#394058}

[modify] https://crrev.com/20cd5a39df58894c38a6581bd40ae3bfa0d37c8c/third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoderTest.cpp
[modify] https://crrev.com/20cd5a39df58894c38a6581bd40ae3bfa0d37c8c/third_party/WebKit/Source/platform/image-encoders/JPEGImageEncoder.cpp
[modify] https://crrev.com/20cd5a39df58894c38a6581bd40ae3bfa0d37c8c/third_party/WebKit/Source/platform/network/HTTPHeaderMap.cpp
[modify] https://crrev.com/20cd5a39df58894c38a6581bd40ae3bfa0d37c8c/third_party/WebKit/Source/platform/network/ResourceRequest.cpp
[modify] https://crrev.com/20cd5a39df58894c38a6581bd40ae3bfa0d37c8c/third_party/WebKit/Source/platform/network/ResourceResponse.cpp
[modify] https://crrev.com/20cd5a39df58894c38a6581bd40ae3bfa0d37c8c/third_party/WebKit/Source/platform/network/ResourceTimingInfo.cpp
[modify] https://crrev.com/20cd5a39df58894c38a6581bd40ae3bfa0d37c8c/third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.cpp
[modify] https://crrev.com/20cd5a39df58894c38a6581bd40ae3bfa0d37c8c/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp
[modify] https://crrev.com/20cd5a39df58894c38a6581bd40ae3bfa0d37c8c/third_party/WebKit/Source/platform/testing/TestPaintArtifact.cpp
[modify] https://crrev.com/20cd5a39df58894c38a6581bd40ae3bfa0d37c8c/third_party/WebKit/Source/platform/text/LocaleICU.cpp
[modify] https://crrev.com/20cd5a39df58894c38a6581bd40ae3bfa0d37c8c/third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp

Project Member

Comment 9 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86942e7ae38c7f37635ce1ea62e38420a8014f0b

commit 86942e7ae38c7f37635ce1ea62e38420a8014f0b
Author: yutak <yutak@chromium.org>
Date: Tue May 17 05:22:21 2016

Remove OwnPtr::release() calls in platform/ (part 1).

OwnPtr::release() calls can be (1) replaced with std::move(), or
(2) removed entirely (in certain "return" statements).

BUG= 611660 

Review-Url: https://codereview.chromium.org/1981823002
Cr-Commit-Position: refs/heads/master@{#394060}

[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/TracedValueTest.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/audio/FFTFrame.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/audio/HRTFDatabase.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/audio/HRTFElevation.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/audio/HRTFKernel.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/audio/Reverb.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/audio/ReverbConvolver.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/exported/WebFileSystemCallbacks.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/geometry/FloatPolygonTest.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/graphics/CompositorMutatorClient.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/graphics/CompositorMutatorClientTest.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/graphics/ContiguousContainer.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/graphics/ImageDecodingStore.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/graphics/ImageDecodingStoreTest.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/graphics/gpu/Extensions3DUtil.cpp
[modify] https://crrev.com/86942e7ae38c7f37635ce1ea62e38420a8014f0b/third_party/WebKit/Source/platform/graphics/test/MockImageDecoder.h

Project Member

Comment 10 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76456ed6161751fd3ec1d5c8cbc752487cf12395

commit 76456ed6161751fd3ec1d5c8cbc752487cf12395
Author: yutak <yutak@chromium.org>
Date: Tue May 17 08:06:57 2016

Remove OwnPtr::release() calls in web/ & wtf/.

OwnPtr::release() calls can be (1) replaced with std::move(), or
(2) removed entirely (in certain "return" statements).

BUG= 611660 

Review-Url: https://codereview.chromium.org/1984593002
Cr-Commit-Position: refs/heads/master@{#394080}

[modify] https://crrev.com/76456ed6161751fd3ec1d5c8cbc752487cf12395/third_party/WebKit/Source/web/InspectorOverlay.cpp
[modify] https://crrev.com/76456ed6161751fd3ec1d5c8cbc752487cf12395/third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp
[modify] https://crrev.com/76456ed6161751fd3ec1d5c8cbc752487cf12395/third_party/WebKit/Source/web/WebBlob.cpp
[modify] https://crrev.com/76456ed6161751fd3ec1d5c8cbc752487cf12395/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/76456ed6161751fd3ec1d5c8cbc752487cf12395/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp
[modify] https://crrev.com/76456ed6161751fd3ec1d5c8cbc752487cf12395/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
[modify] https://crrev.com/76456ed6161751fd3ec1d5c8cbc752487cf12395/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/76456ed6161751fd3ec1d5c8cbc752487cf12395/third_party/WebKit/Source/wtf/DequeTest.cpp
[modify] https://crrev.com/76456ed6161751fd3ec1d5c8cbc752487cf12395/third_party/WebKit/Source/wtf/VectorTest.cpp
[modify] https://crrev.com/76456ed6161751fd3ec1d5c8cbc752487cf12395/third_party/WebKit/Source/wtf/text/TextPosition.cpp

Project Member

Comment 11 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1634f537b3825aab0669a58612b73b8c3ae30198

commit 1634f537b3825aab0669a58612b73b8c3ae30198
Author: yutak <yutak@chromium.org>
Date: Tue May 17 08:15:56 2016

Remove OwnPtr::release() calls in core/ (part 3).

OwnPtr::release() calls can be (1) replaced with std::move(), or
(2) removed entirely (in certain "return" statements).

BUG= 611660 

Review-Url: https://codereview.chromium.org/1979183002
Cr-Commit-Position: refs/heads/master@{#394081}

[modify] https://crrev.com/1634f537b3825aab0669a58612b73b8c3ae30198/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
[modify] https://crrev.com/1634f537b3825aab0669a58612b73b8c3ae30198/third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.cpp
[modify] https://crrev.com/1634f537b3825aab0669a58612b73b8c3ae30198/third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h
[modify] https://crrev.com/1634f537b3825aab0669a58612b73b8c3ae30198/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
[modify] https://crrev.com/1634f537b3825aab0669a58612b73b8c3ae30198/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp
[modify] https://crrev.com/1634f537b3825aab0669a58612b73b8c3ae30198/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/1634f537b3825aab0669a58612b73b8c3ae30198/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
[modify] https://crrev.com/1634f537b3825aab0669a58612b73b8c3ae30198/third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp
[modify] https://crrev.com/1634f537b3825aab0669a58612b73b8c3ae30198/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp
[modify] https://crrev.com/1634f537b3825aab0669a58612b73b8c3ae30198/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
[modify] https://crrev.com/1634f537b3825aab0669a58612b73b8c3ae30198/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp
[modify] https://crrev.com/1634f537b3825aab0669a58612b73b8c3ae30198/third_party/WebKit/Source/core/inspector/InspectorSession.cpp
[modify] https://crrev.com/1634f537b3825aab0669a58612b73b8c3ae30198/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp
[modify] https://crrev.com/1634f537b3825aab0669a58612b73b8c3ae30198/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
[modify] https://crrev.com/1634f537b3825aab0669a58612b73b8c3ae30198/third_party/WebKit/Source/core/inspector/LayoutEditor.cpp
[modify] https://crrev.com/1634f537b3825aab0669a58612b73b8c3ae30198/third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp
[modify] https://crrev.com/1634f537b3825aab0669a58612b73b8c3ae30198/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
[modify] https://crrev.com/1634f537b3825aab0669a58612b73b8c3ae30198/third_party/WebKit/Source/core/layout/FloatingObjects.cpp
[modify] https://crrev.com/1634f537b3825aab0669a58612b73b8c3ae30198/third_party/WebKit/Source/core/layout/LayoutAnalyzer.cpp
[modify] https://crrev.com/1634f537b3825aab0669a58612b73b8c3ae30198/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
[modify] https://crrev.com/1634f537b3825aab0669a58612b73b8c3ae30198/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
[modify] https://crrev.com/1634f537b3825aab0669a58612b73b8c3ae30198/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/1634f537b3825aab0669a58612b73b8c3ae30198/third_party/WebKit/Source/core/layout/TracedLayoutObject.cpp
[modify] https://crrev.com/1634f537b3825aab0669a58612b73b8c3ae30198/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/1634f537b3825aab0669a58612b73b8c3ae30198/third_party/WebKit/Source/core/layout/shapes/RasterShape.cpp
[modify] https://crrev.com/1634f537b3825aab0669a58612b73b8c3ae30198/third_party/WebKit/Source/core/layout/shapes/Shape.cpp
[modify] https://crrev.com/1634f537b3825aab0669a58612b73b8c3ae30198/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp
[modify] https://crrev.com/1634f537b3825aab0669a58612b73b8c3ae30198/third_party/WebKit/Source/core/layout/svg/SVGResources.cpp
[modify] https://crrev.com/1634f537b3825aab0669a58612b73b8c3ae30198/third_party/WebKit/Source/core/layout/svg/SVGResourcesCache.cpp

Project Member

Comment 12 by bugdroid1@chromium.org, May 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e140a0d3266c78fb085395cf63eb75778fc4413d

commit e140a0d3266c78fb085395cf63eb75778fc4413d
Author: yutak <yutak@chromium.org>
Date: Wed May 18 06:16:38 2016

Remove OwnPtr::release() calls in platform/ (part inspector).

OwnPtr::release() calls can be (1) replaced with std::move(), or
(2) removed entirely (in certain "return" statements).

BUG= 611660 

Review-Url: https://codereview.chromium.org/1979963002
Cr-Commit-Position: refs/heads/master@{#394341}

[modify] https://crrev.com/e140a0d3266c78fb085395cf63eb75778fc4413d/third_party/WebKit/Source/platform/inspector_protocol/Array.h
[modify] https://crrev.com/e140a0d3266c78fb085395cf63eb75778fc4413d/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py
[modify] https://crrev.com/e140a0d3266c78fb085395cf63eb75778fc4413d/third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_cpp.template
[modify] https://crrev.com/e140a0d3266c78fb085395cf63eb75778fc4413d/third_party/WebKit/Source/platform/inspector_protocol/Frontend_cpp.template
[modify] https://crrev.com/e140a0d3266c78fb085395cf63eb75778fc4413d/third_party/WebKit/Source/platform/inspector_protocol/Parser.cpp
[modify] https://crrev.com/e140a0d3266c78fb085395cf63eb75778fc4413d/third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template
[modify] https://crrev.com/e140a0d3266c78fb085395cf63eb75778fc4413d/third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template
[modify] https://crrev.com/e140a0d3266c78fb085395cf63eb75778fc4413d/third_party/WebKit/Source/platform/inspector_protocol/Values.cpp
[modify] https://crrev.com/e140a0d3266c78fb085395cf63eb75778fc4413d/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp
[modify] https://crrev.com/e140a0d3266c78fb085395cf63eb75778fc4413d/third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp
[modify] https://crrev.com/e140a0d3266c78fb085395cf63eb75778fc4413d/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp
[modify] https://crrev.com/e140a0d3266c78fb085395cf63eb75778fc4413d/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
[modify] https://crrev.com/e140a0d3266c78fb085395cf63eb75778fc4413d/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp
[modify] https://crrev.com/e140a0d3266c78fb085395cf63eb75778fc4413d/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp
[modify] https://crrev.com/e140a0d3266c78fb085395cf63eb75778fc4413d/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp
[modify] https://crrev.com/e140a0d3266c78fb085395cf63eb75778fc4413d/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
[modify] https://crrev.com/e140a0d3266c78fb085395cf63eb75778fc4413d/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp
[modify] https://crrev.com/e140a0d3266c78fb085395cf63eb75778fc4413d/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp

Project Member

Comment 13 by bugdroid1@chromium.org, May 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0030f9c2a1dec3f165d6a23aff64292fec2067f1

commit 0030f9c2a1dec3f165d6a23aff64292fec2067f1
Author: yutak <yutak@chromium.org>
Date: Thu May 19 09:15:16 2016

Remove OwnPtr::release().

Having OwnPtr::release() can be confusing when we convert OwnPtrs to
std::unique_ptrs, because std::unique_ptr also has release() member
function with a different meaning.

Existing uses of OwnPtr::release() are already mostly removed; this
patch takes care of release() calls from recent changes, and actually
removes the method.

BUG= 611660 

Review-Url: https://codereview.chromium.org/1987203002
Cr-Commit-Position: refs/heads/master@{#394722}

[modify] https://crrev.com/0030f9c2a1dec3f165d6a23aff64292fec2067f1/third_party/WebKit/Source/build/scripts/templates/MakeQualifiedNames.cpp.tmpl
[modify] https://crrev.com/0030f9c2a1dec3f165d6a23aff64292fec2067f1/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
[modify] https://crrev.com/0030f9c2a1dec3f165d6a23aff64292fec2067f1/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp
[modify] https://crrev.com/0030f9c2a1dec3f165d6a23aff64292fec2067f1/third_party/WebKit/Source/platform/fonts/mac/FontCacheMac.mm
[modify] https://crrev.com/0030f9c2a1dec3f165d6a23aff64292fec2067f1/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp
[modify] https://crrev.com/0030f9c2a1dec3f165d6a23aff64292fec2067f1/third_party/WebKit/Source/wtf/OwnPtr.h

Comment 14 by yutak@chromium.org, May 24 2016

Status: Fixed (was: Started)

Comment 15 by tkent@chromium.org, Jun 23 2016

Components: -Blink>WTF Blink>Internals>WTF
Renaming Blink>WTF to Blink>Internals>WTF.

Comment 16 by tkent@chromium.org, Jun 23 2016

Components: -Blink>Architecture Blink>Internals
Renaming Blink>Architecture to Blink>Internals

Sign in to add a comment