New issue
Advanced search Search tips

Issue 611640 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Compat



Sign in to add a comment

Move worker's close() to the derived interfaces from the base WorkerGlobalScope

Project Member Reported by nhiroki@chromium.org, May 13 2016

Issue description

close() was originally defined in WorkerGlobalScope, but it was moved to the derived interfaces (ie. DedicatedWorkerGlobalScope and SharedWorkerGlobalScope) by the recent spec change:
https://github.com/whatwg/html/pull/1119

In Blink, we need to...

1. move close() from WorkerGlobalScope.idl to the derived interfaces.
2. remove close() from ServiceWorkerGlobalScope
 
Components: Blink>Workers
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd0f180962882117b13fd369372bdb92f4b5ecc7

commit cd0f180962882117b13fd369372bdb92f4b5ecc7
Author: nhiroki <nhiroki@chromium.org>
Date: Tue May 17 07:30:27 2016

Worker: Move close() from WorkerGlobalScope to derived interfaces

close() was originally defined in WorkerGlobalScope, but it was moved to derived
interfaces by the recent spec change (https://github.com/whatwg/html/pull/1119).

This CL moves close() from WorkerGlobalScope to the derived interfaces, namely,
DedicatedWorkerGlobalScope and SharedWorkerGlobalScope, and also removes close()
from ServiceWorkerGlobalScope.

These changes should not break applications in the wild. For DedicatedWorker and
SharedWorker, close() is still valid after this change. For ServiceWorker,
close() is not accessible after this change, but it raised an exception and was
not usable in the first place.

Specs:
WorkerGlobalScope: https://html.spec.whatwg.org/multipage/workers.html#workerglobalscope
DedicatedWorkerGlobalScope: https://html.spec.whatwg.org/multipage/workers.html#dedicated-workers-and-the-dedicatedworkerglobalscope-interface
SharedWorkerGlobalScope: https://html.spec.whatwg.org/multipage/workers.html#shared-workers-and-the-sharedworkerglobalscope-interface
ServiceWorkerGlobalScope: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-global-scope

BUG= 611640 

Review-Url: https://codereview.chromium.org/1970003004
Cr-Commit-Position: refs/heads/master@{#394077}

[delete] https://crrev.com/7e43c8dae9203ccc418452fafdea69a0f3a7eaef/third_party/WebKit/LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/close.html
[delete] https://crrev.com/7e43c8dae9203ccc418452fafdea69a0f3a7eaef/third_party/WebKit/LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/resources/close-worker.js
[modify] https://crrev.com/cd0f180962882117b13fd369372bdb92f4b5ecc7/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/interfaces-worker.js
[modify] https://crrev.com/cd0f180962882117b13fd369372bdb92f4b5ecc7/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/cd0f180962882117b13fd369372bdb92f4b5ecc7/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/cd0f180962882117b13fd369372bdb92f4b5ecc7/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/cd0f180962882117b13fd369372bdb92f4b5ecc7/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/cd0f180962882117b13fd369372bdb92f4b5ecc7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/cd0f180962882117b13fd369372bdb92f4b5ecc7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/cd0f180962882117b13fd369372bdb92f4b5ecc7/third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.idl
[modify] https://crrev.com/cd0f180962882117b13fd369372bdb92f4b5ecc7/third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.idl
[modify] https://crrev.com/cd0f180962882117b13fd369372bdb92f4b5ecc7/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
[modify] https://crrev.com/cd0f180962882117b13fd369372bdb92f4b5ecc7/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h
[modify] https://crrev.com/cd0f180962882117b13fd369372bdb92f4b5ecc7/third_party/WebKit/Source/core/workers/WorkerGlobalScope.idl
[modify] https://crrev.com/cd0f180962882117b13fd369372bdb92f4b5ecc7/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp
[modify] https://crrev.com/cd0f180962882117b13fd369372bdb92f4b5ecc7/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h
[modify] https://crrev.com/cd0f180962882117b13fd369372bdb92f4b5ecc7/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.idl
[modify] https://crrev.com/cd0f180962882117b13fd369372bdb92f4b5ecc7/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

Status: Fixed (was: Started)

Sign in to add a comment