There is no good way to disable the skip_gpu_process test on Android |
||||
Issue descriptionThe skip_gpu_process test was failing on Android. We tried to skip that test, but found that the browser had to be started up (with the arguments specifying it should disable the GPU) before the test was actually skipped. For now, we are disabling the test. It added little value and prevented the Android bots on the Chromium recipe from turning green. We should come back and provide a way to only skip this on Android (so we can run the test again).
,
May 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e00ce63d29e2197bcd35b5419add1a7a06f0eda commit 4e00ce63d29e2197bcd35b5419add1a7a06f0eda Author: cblume <cblume@chromium.org> Date: Fri May 13 01:58:41 2016 Disabling skip_gpu_process test. There was no good way to skip this test on Android (where it is failing) so we decided to simply disable the test. It provides little value and is keeping the Android bots from being green on the Chromium recipe. We should come back and provide a way to only skip this on Android (so we can run the test again). BUG= 490984 , 611629 R=kbr@chromium.org NOTRY=true CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/1974203002 Cr-Commit-Position: refs/heads/master@{#393429} [modify] https://crrev.com/4e00ce63d29e2197bcd35b5419add1a7a06f0eda/content/test/gpu/page_sets/gpu_process_tests.py
,
May 13 2016
,
May 13 2016
You should be able to skip the test without evert starting the browser using @Disabled('android') decorator.
,
May 13 2016
Ned, can you help me out with that tomorrow?
We tried but found @benchmark.Disabled('android') to no avail.
,
May 13 2016
The problem is that we need to skip one page in the page set. The @Disabled('android') decorator seems to work only for the entire benchmark.
,
May 13 2016
We talked offline & found a way to do this.
,
May 13 2016
Yup. Thank you, Ned. Your suggested change is awaiting review at https://codereview.chromium.org/1977953002 Once it lands I'll close out this bug.
,
May 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42b62c5291d9f31138a294d8a22965d02bb498f4 commit 42b62c5291d9f31138a294d8a22965d02bb498f4 Author: cblume <cblume@chromium.org> Date: Sat May 14 00:21:03 2016 Prevent skip_gpu_process from running on Android We had previously tried to identify a way to tell if the test was being run on Android. But when we did that, I did not explicitly set the browser. So the browser_type passed down was 'reference'. By simply specifying --browser android-content-shell we were able to better detect that the platform is Android. BUG= 611629 , 490984 R=kbr@chromium.org,nednguyen@google.com CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/1977953002 Cr-Commit-Position: refs/heads/master@{#393701} [modify] https://crrev.com/42b62c5291d9f31138a294d8a22965d02bb498f4/content/test/gpu/gpu_tests/gpu_process.py [modify] https://crrev.com/42b62c5291d9f31138a294d8a22965d02bb498f4/content/test/gpu/page_sets/gpu_process_tests.py
,
May 14 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by kbr@chromium.org
, May 13 2016