New issue
Advanced search Search tips

Issue 611625 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[Remoting Android] Refactor OAuth Token Fetching Code

Project Member Reported by yuweih@chromium.org, May 13 2016

Issue description

Currently all the token fetching works are done in Chromoting.java and the code is tightly coupled with host list refreshing. We should refactor these code so that we can reuse it for deleting host or sending telemetry logs.
 

Comment 1 by yuweih@chromium.org, May 13 2016

Components: Services>Chromoting
Project Member

Comment 2 by bugdroid1@chromium.org, May 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5b7e6ed12f4ebccd4e35b21a03330d635a7bda4

commit a5b7e6ed12f4ebccd4e35b21a03330d635a7bda4
Author: yuweih <yuweih@chromium.org>
Date: Fri May 13 18:44:59 2016

[Remoting Android] Refactor OAuth Token Fetching Code

* OAuthTokenConsumer for each auth token consuming task. The consumer class guarantees that no same tasks can be run at the same time.
* Make connectToHost independent to mToken.
* Remove retry fetching token logic.
* Method for deleting host.

BUG= 611625 

Review-Url: https://codereview.chromium.org/1976853002
Cr-Commit-Position: refs/heads/master@{#393592}

[modify] https://crrev.com/a5b7e6ed12f4ebccd4e35b21a03330d635a7bda4/remoting/android/client_java_tmpl.gni
[modify] https://crrev.com/a5b7e6ed12f4ebccd4e35b21a03330d635a7bda4/remoting/android/java/src/org/chromium/chromoting/Chromoting.java
[modify] https://crrev.com/a5b7e6ed12f4ebccd4e35b21a03330d635a7bda4/remoting/android/java/src/org/chromium/chromoting/HostListManager.java
[add] https://crrev.com/a5b7e6ed12f4ebccd4e35b21a03330d635a7bda4/remoting/android/java/src/org/chromium/chromoting/OAuthTokenConsumer.java

Comment 3 by yuweih@chromium.org, May 14 2016

Status: Fixed (was: Started)

Sign in to add a comment