Investigate building Cronet with use_platform_icu_alternatives=false |
||||
Issue descriptionBuilding Cronet with use_platform_icu_alternatives=false seems to give a runtime error. 05-12 09:18:55.668 17216 17216 W System.err: java.lang.ExceptionInInitializerError 05-12 09:18:55.668 17216 17216 W System.err: at org.chromium.base.PathUtils.getDirectoryPath(PathUtils.java:147) 05-12 09:18:55.668 17216 17216 W System.err: at org.chromium.base.PathUtils.getDataDirectory(PathUtils.java:156) 05-12 09:18:55.669 17216 17216 W System.err: at org.chromium.net.CronetLibraryLoader.nativeCronetInitOnMainThread(Native Method) 05-12 09:18:55.669 17216 17216 W System.err: at org.chromium.net.CronetLibraryLoader.ensureInitializedOnMainThread(CronetLibraryLoader.java:90) I think what happens is that base::i18n::InitializeICU() calls into PathUtils to find data directory, but Cronet does not set it. This does not affect official binaries since we always build Cronet with use_platform_icu_alternatives=true.
,
Jul 26 2016
It's probably okay to delay this until we can run tests with icu. Right now, we don't have any test bots with use_platform_icu_alternatives=false. Infra is adding support for swarming. Once we have that, it will be easier to test use_platform_icu_alternatives=false continuously.
,
Jul 29 2016
Issue 632506 has been merged into this issue.
,
Aug 30 2016
Talked about this during triage meeting, it's better to add a compile-time assert to not allow building with ICU.
,
Dec 6 2016
Assigning this to myself since this is getting pretty old!
,
Dec 14 2016
,
Dec 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86aa1ab301820780c3eef9fb179e0e016777d47c commit 86aa1ab301820780c3eef9fb179e0e016777d47c Author: xunjieli <xunjieli@chromium.org> Date: Thu Dec 15 20:46:07 2016 [Cronet] Enforce building Cronet with use_platform_icu_alternatives == true This CL adds an condition on "cronet_package" target to enforce that Cronet is built with use_platform_icu_alternatives == true. BUG= 611621 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2573253002 Cr-Commit-Position: refs/heads/master@{#438917} [modify] https://crrev.com/86aa1ab301820780c3eef9fb179e0e016777d47c/components/cronet/android/BUILD.gn
,
Dec 15 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mge...@chromium.org
, Jun 7 2016Status: Available (was: Untriaged)