"ProfileWindowWebUIBrowserTest.UserManagerFocusMultipleProfiles" is flaky |
||||||||
Issue description"ProfileWindowWebUIBrowserTest.UserManagerFocusMultipleProfiles" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySQsSBUZsYWtlIj5Qcm9maWxlV2luZG93V2ViVUlCcm93c2VyVGVzdC5Vc2VyTWFuYWdlckZvY3VzTXVsdGlwbGVQcm9maWxlcww. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
May 13 2016
CCing some relevant people. I'll send through a disable for this test shortly.
,
May 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d56e25a986dc4bd6aa46f6628622a5cbe5ad3dcf commit d56e25a986dc4bd6aa46f6628622a5cbe5ad3dcf Author: tsergeant <tsergeant@chromium.org> Date: Fri May 13 02:34:52 2016 Disable ProfileWindowWebUIBrowserTest.UserManagerFocusMultipleProfiles This test is flaky, see: https://chromium-try-flakes.appspot.com/search?q=ProfileWindowWebUIBrowserTest.UserManagerFocusMultipleProfiles BUG= 611619 TBR=mlerman@chromium.org Review-Url: https://codereview.chromium.org/1972123003 Cr-Commit-Position: refs/heads/master@{#393434} [modify] https://crrev.com/d56e25a986dc4bd6aa46f6628622a5cbe5ad3dcf/chrome/browser/profiles/profile_window_browsertest.cc
,
May 13 2016
,
May 14 2016
+mahmadi@ Appears that some recent changes in the user_pod code is causing failures. Moe: IIRC some of your code has triggered the same kind of error before. How did you fix it?
,
May 15 2016
I normally see these Pod offsetWidth/offsetHeight console errors in the new material design user manager (chrome://flags/#enable-material-design-user-manager) which is still under development. The reason for the errors is that the new user manager is paged and when an attempt is made to arrange the pods on the screen, the pods page may not be visible. But I don't expect see these errors in the existing user manager since my changes to the user_pod_row.js shouldn't affect the existing behavior. Could this be related to recent changes to user_pod_template.js and how we load Polymer? +jdufault@
,
May 16 2016
I have a feeling that [1] introduced this - but I do not think this will cause any user-facing bugs (outside of the failing test that was disabled). offsetWidth and offsetHeight are not being computed because the injected script ends up blocking their computation, but right now I'm not sure why injecting a script blocks the computation. I've taken ownership of the bug. I don't have time to fix it right now, but I will try to get to it soon. lwchkg@, if you want to take a look feel free to take ownership back. 1: https://codereview.chromium.org/1925453005/
,
May 16 2016
Confirmed that [1] introduced the flakiness. The flaky rate is close to 50%, so you're so lucky to have your CL landed. Unfortunately I'm super busy in my daytime job this week, so I need to wait till weekend before continue to work on the issue.
,
May 25 2016
,
May 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e47e3654fd44ec6848cc3bc2123ec5ea08afd111 commit e47e3654fd44ec6848cc3bc2123ec5ea08afd111 Author: mahmadi <mahmadi@chromium.org> Date: Tue May 31 23:21:08 2016 Use svg icon to avoid lazy loading of Polymer elements for user pods 1) Lazy loading of Polymer was causing flakiness in a set of tests. 2) It also fixes the bug where the overflow menu icon was not appearing on hover. BUG= 610362 , 611619 , 615085 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2007133006 Cr-Commit-Position: refs/heads/master@{#396970} [modify] https://crrev.com/e47e3654fd44ec6848cc3bc2123ec5ea08afd111/chrome/browser/resources/chromeos/login/login_shared.js [modify] https://crrev.com/e47e3654fd44ec6848cc3bc2123ec5ea08afd111/chrome/browser/resources/md_user_manager/user_manager.html [modify] https://crrev.com/e47e3654fd44ec6848cc3bc2123ec5ea08afd111/chrome/browser/resources/md_user_manager/user_manager.js [modify] https://crrev.com/e47e3654fd44ec6848cc3bc2123ec5ea08afd111/chrome/browser/resources/md_user_manager/user_manager_styles.html [modify] https://crrev.com/e47e3654fd44ec6848cc3bc2123ec5ea08afd111/chrome/browser/resources/user_manager/user_manager.html [modify] https://crrev.com/e47e3654fd44ec6848cc3bc2123ec5ea08afd111/chrome/browser/resources/user_manager/user_manager.js [modify] https://crrev.com/e47e3654fd44ec6848cc3bc2123ec5ea08afd111/chrome/test/data/webui/md_user_manager/create_profile_tests.js [modify] https://crrev.com/e47e3654fd44ec6848cc3bc2123ec5ea08afd111/chrome/test/data/webui/md_user_manager/test_profile_browser_proxy.js [modify] https://crrev.com/e47e3654fd44ec6848cc3bc2123ec5ea08afd111/chrome/test/data/webui/md_user_manager/user_manager_browsertest.js [modify] https://crrev.com/e47e3654fd44ec6848cc3bc2123ec5ea08afd111/ui/login/account_picker/user_pod_row.css [modify] https://crrev.com/e47e3654fd44ec6848cc3bc2123ec5ea08afd111/ui/login/account_picker/user_pod_template.html [delete] https://crrev.com/a8e5d2e3274a104d4a2c54391fc124daaaaae7a7/ui/login/account_picker/user_pod_template.js
,
Jun 1 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by tsergeant@chromium.org
, May 13 2016