Evan, do you remember the context here?

In the past, Sebastien said all the grey icons should be the same color (the navigation buttons, the location bar icons, bookmark folders, app menu, etc.) regardless of the background. Since the background is different for the toolbar and the location bar, we intentionally blend with a solid color.

It seems that now the spec may have changed, although it's hard to verify when he's in Tokyo.

Sebastien, perhaps you could clarify the current expectations here.

I'm personally OK with these groups of icons winding up as different colors, but we definitely should know what the overall plan is.

Sebastien says 80% opaque white for incognito, 100% opaque #5a5a5a for normal. Thus the icons will have the same color in normal and different colors in incognito.

I don't think spec changed since quite a while. Icons in normal were always #5a5a5a and at the time we were finishing incognito on Windows, Peter made the remark that the 100% #FFF icon where a bit too strong compared to their normal counter part. we then applied the 80% alpha on them to dim them a bit. Sorry if this wasn't conveyed the proper way.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b216164c4d208a54f3469fc4b6fb5c3f845d38c6

commit b216164c4d208a54f3469fc4b6fb5c3f845d38c6
Author: estade <estade@chromium.org>
Date: Mon May 16 19:14:40 2016

[MD] Adjust algorithm for colorizing icons in incognito contexts.

BUG= 611617 

Review-Url: https://codereview.chromium.org/1977693004
Cr-Commit-Position: refs/heads/master@{#393892}

[modify] https://crrev.com/b216164c4d208a54f3469fc4b6fb5c3f845d38c6/ui/gfx/color_utils.cc

So, do Mac and Views now agree?  If so, can this bug be closed?

they should yes. There's still some special casing for OSX that could probably be removed, but I'll leave that to the mac folks.