New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 611616 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

network (wifi?) icons are distorted.

Project Member Reported by osh...@chromium.org, May 13 2016

Issue description

ToT: (52.0.2735.0)

 
Screenshot 2016-05-12 at 5.06.58 PM.png
168 KB View Download
Cc: vmp...@chromium.org osh...@chromium.org danakj@chromium.org
I've seen this too. As of yesterday I am now seeing wifi with cellular on top of it. It seems to be specific to the status area (i.e. not affecting Settings). I see a recent change related to cc in ui/chromeos/network, and one about GL that may be related?
+vmpstr@, +danakj@, +oshima@


Comment 2 by danakj@chromium.org, May 13 2016

Labels: Needs-Bisect
Can you bisect?
Cc: tdander...@chromium.org marc...@chromium.org
Note that we haven't made any changes to the system menu or icons for material design yet, so this regression is unrelated to MD.

Comment 5 by osh...@chromium.org, May 24 2016

Owner: warx@chromium.org
Status: Assigned (was: Untriaged)
warx@, can you run bisect?

Comment 6 by warx@chromium.org, May 24 2016

I cannot see it on desktop build during bisect and device build on link (52.0.2739.0).
I don't see there is a version 52.0.2735.0 on goldeneye. Any more information I should know to find the bad version?

Comment 7 by osh...@chromium.org, May 25 2016

can you run bisect on device using simple chrome?

Comment 8 by warx@chromium.org, May 25 2016

cannot see the bad version on 53.0.2746.0
Platform 8370.0.0 dev-channel link test, device dependent?

Comment 9 by warx@chromium.org, May 26 2016

Owner: osh...@chromium.org
Labels: Merge-Request-52 M-52
Status: Started (was: Assigned)
So the issue was that network_icon.cc was using uninitialized canvas to generated icons. It was working, probably because skia used to initialize the canvas buffer with 0, but that probably has changed recently.

Comment 12 by tin...@google.com, May 27 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 13 by bugdroid1@chromium.org, May 27 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64bf7b0d391ee2670c5239dfb9ac867d180fed05

commit 64bf7b0d391ee2670c5239dfb9ac867d180fed05
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Fri May 27 23:25:07 2016

Use initialized canvas to create network icons.

Remove rarely used ctor.

BUG= 611616 

Review-Url: https://codereview.chromium.org/2016833002
Cr-Commit-Position: refs/heads/master@{#396326}
(cherry picked from commit 07b5fad29dd278dee342363c7562bcec1fd729de)

Review URL: https://codereview.chromium.org/2015083004 .

Cr-Commit-Position: refs/branch-heads/2743@{#113}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/64bf7b0d391ee2670c5239dfb9ac867d180fed05/ui/chromeos/network/network_icon.cc
[modify] https://crrev.com/64bf7b0d391ee2670c5239dfb9ac867d180fed05/ui/gfx/canvas.cc
[modify] https://crrev.com/64bf7b0d391ee2670c5239dfb9ac867d180fed05/ui/gfx/canvas.h

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Samus 8350.21.0

Sign in to add a comment