New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 611590 link

Starred by 1 user
Status: Fixed
Owner:
█ haibinlu@chromium.org
Last visit > 30 days ago
Closed: May 2016
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Engine crash: render_widget_host_impl.cc(1029)] Check failed: *is_in_gesture_scroll ...

Project Member Reported by haibinlu@chromium.org, May 12 2016 
When trying to repo  crbug.com/598876 , I got engine crash once due to

touchscreen_tap_suppression_controller.cc(55)] WebInputEvent::GestureTap 
[26765:26765:0512/155641:INFO:CONSOLE(17)] "%cclearing viewable timeout: slug_t", source: http://static.cdnslate.com/etc/designs/slate/js/main.min.2cb832d4.js (17)
[26765:26765:0512/155642:INFO:CONSOLE(17)] "%cslug_t considered viewable: setting 120sec timeout", source: http://static.cdnslate.com/etc/designs/slate/js/main.min.2cb832d4.js (17)
[26765:26765:0512/155648:FATAL:render_widget_host_impl.cc(1029)] Check failed: *is_in_gesture_scroll || (gesture_event.type == blink::WebInputEvent::GestureFlingStart && gesture_event.sourceDevice == blink::WebGestureDevice::WebGestureDeviceTouchpad). 
#0 0x7fe96a067c6e base::debug::StackTrace::StackTrace()
#1 0x7fe96a08834b logging::LogMessage::~LogMessage()
#2 0x7fe96919f95b content::RenderWidgetHostImpl::ForwardGestureEventWithLatencyInfo()
#3 0x7fe96919f7c8 content::RenderWidgetHostImpl::ForwardGestureEvent()
#4 0x0000004c29df blimp::engine::BlimpEngineSession::OnWebGestureEvent()
#5 0x0000004c62b6 blimp::engine::EngineRenderWidgetFeature::ProcessMessage()
#6 0x7fe969f73faa blimp::(anonymous namespace)::DispatchProcessMessage()
#7 0x7fe969f74235 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1ELm2EEEENS0_9BindStateINS0_15RunnableAdapterIPFvNS_7WeakPtrIN5blimp22BlimpMessageThreadPipeEEESt10unique_ptrINS7_12BlimpMessageESt14default_deleteISB_EERKNS_8CallbackIFviELNS0_8CopyModeE1EEEEEESL_JRS9_NS0_13PassedWrapperISE_EERSI_EEENS0_12InvokeHelperILb0EvSN_EEFvvEE3RunEPNS0_13BindStateBaseE
#8 0x7fe96a068e79 base::debug::TaskAnnotator::RunTask()
#9 0x7fe96a092aa5 base::MessageLoop::RunTask()
#10 0x7fe96a092dd8 base::MessageLoop::DeferOrRunPendingTask()
#11 0x7fe96a09316b base::MessageLoop::DoWork()
#12 0x7fe96a095a89 base::MessagePumpLibevent::Run()
#13 0x7fe96a0925d1 base::MessageLoop::RunHandler()
#14 0x7fe96a0c0aa0 base::RunLoop::Run()
#15 0x7fe968ee6708 content::BrowserMainLoop::MainMessageLoopRun()
#16 0x7fe968ee64e5 content::BrowserMainLoop::RunMainMessageLoopParts()
#17 0x7fe968ee9068 content::BrowserMainRunnerImpl::Run()
#18 0x7fe968ee1d8c content::BrowserMain()
#19 0x7fe969884d9b content::RunNamedProcessTypeMain()
#20 0x7fe969885813 content::ContentMainRunnerImpl::Run()
#21 0x7fe9698840f0 content::ContentMain()
#22 0x00000041a60b main
#23 0x7fe966615ec5 __libc_start_main
#24 0x00000041a4f5 <unknown>

Comment 1 by haibinlu@chromium.org, May 13 2016

Owner: haibinlu@chromium.org
Status: Started (was: Untriaged)
gesture events lead to the crash

[18458:18458:0513/110652:ERROR:blimp_engine_session.cc(412)] GestureTap 17
[18458:18458:0513/110652:ERROR:touchscreen_tap_suppression_controller.cc(55)] WebInputEvent::GestureTap 
[18458:18458:0513/110700:ERROR:blimp_engine_session.cc(418)] GestureScrollUpdate 13
[18458:18458:0513/110700:ERROR:blimp_engine_session.cc(418)] GestureScrollUpdate 13
[18458:18458:0513/110700:ERROR:blimp_engine_session.cc(409)] GestureFlingStart 14
[18458:18458:0513/110700:FATAL:render_widget_host_impl.cc(1029)] Check failed: *is_in_gesture_scroll || (gesture_event.type == blink::WebInputEvent::GestureFlingStart && gesture_event.sourceDevice == blink::WebGestureDevice::WebGestureDeviceTouchpad). 
#0 0x7f567b454c6e base::debug::StackTrace::StackTrace()
#1 0x7f567b47534b logging::LogMessage::~LogMessage()
#2 0x7f567a58c95b content::RenderWidgetHostImpl::ForwardGestureEventWithLatencyInfo()
#3 0x7f567a58c7c8 content::RenderWidgetHostImpl::ForwardGestureEvent()
#4 0x0000004c2c33 blimp::engine::BlimpEngineSession::OnWebGestureEvent()
#5 0x0000004c6536 blimp::engine::EngineRenderWidgetFeature::ProcessMessage()
#6 0x7f567b360faa blimp::(anonymous namespace)::DispatchProcessMessage()
#7 0x7f567b361235 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1ELm2EEEENS0_9BindStateINS0_15RunnableAdapterIPFvNS_7WeakPtrIN5blimp22BlimpMessageThreadPipeEEESt10unique_ptrINS7_12BlimpMessageESt14default_deleteISB_EERKNS_8CallbackIFviELNS0_8CopyModeE1EEEEEESL_JRS9_NS0_13PassedWrapperISE_EERSI_EEENS0_12InvokeHelperILb0EvSN_EEFvvEE3RunEPNS0_13BindStateBaseE
#8 0x7f567b455e79 base::debug::TaskAnnotator::RunTask()
#9 0x7f567b47faa5 base::MessageLoop::RunTask()
#10 0x7f567b47fdd8 base::MessageLoop::DeferOrRunPendingTask()
#11 0x7f567b48016b base::MessageLoop::DoWork()
#12 0x7f567b482a89 base::MessagePumpLibevent::Run()
#13 0x7f567b47f5d1 base::MessageLoop::RunHandler()
#14 0x7f567b4adaa0 base::RunLoop::Run()
#15 0x7f567a2d3708 content::BrowserMainLoop::MainMessageLoopRun()
#16 0x7f567a2d34e5 content::BrowserMainLoop::RunMainMessageLoopParts()
#17 0x7f567a2d6068 content::BrowserMainRunnerImpl::Run()
#18 0x7f567a2ced8c content::BrowserMain()
#19 0x7f567ac71d9b content::RunNamedProcessTypeMain()
#20 0x7f567ac72813 content::ContentMainRunnerImpl::Run()
#21 0x7f567ac710f0 content::ContentMain()
#22 0x00000041a60b main

Comment 2 by haibinlu@chromium.org, May 13 2016 

Engine did not receive GestureScrollBegin event

Comment 3 by haibinlu@chromium.org, May 13 2016 

Blimp client does not send consumed gesture event.

05-13 11:18:52.930 31834 31834 E chromium: [ERROR:blimp_input_manager.cc(142)] Sending gesture event: 19
05-13 11:18:52.930 31834 31834 E chromium: [ERROR:input_message_generator.cc(174)] Not implemented reached in std::unique_ptr<BlimpMessage> blimp::InputMessageGenerator::GenerateMessage(const blink::WebGestureEvent &)
05-13 11:18:52.958 31834 31834 E chromium: [ERROR:blimp_input_manager.cc(142)] Sending gesture event: 20
05-13 11:18:52.958 31834 31834 E chromium: [ERROR:input_message_generator.cc(174)] Not implemented reached in std::unique_ptr<BlimpMessage> blimp::InputMessageGenerator::GenerateMessage(const blink::WebGestureEvent &)
05-13 11:18:52.958 31834 31834 E chromium: [ERROR:blimp_input_manager.cc(145)] Gesture event consumed: 11
05-13 11:18:52.959 31834 31834 E chromium: [ERROR:blimp_input_manager.cc(145)] Gesture event consumed: 13
05-13 11:18:52.980 31834 31834 E chromium: [ERROR:blimp_input_manager.cc(145)] Gesture event consumed: 13
05-13 11:18:52.998 31834 31834 E chromium: [ERROR:blimp_input_manager.cc(145)] Gesture event consumed: 13
05-13 11:18:53.012 31834 31834 E chromium: [ERROR:blimp_input_manager.cc(145)] Gesture event consumed: 13
05-13 11:18:53.031 31834 31834 E chromium: [ERROR:blimp_input_manager.cc(145)] Gesture event consumed: 13
05-13 11:18:53.050 31834 31834 E chromium: [ERROR:blimp_input_manager.cc(145)] Gesture event consumed: 13
05-13 11:18:53.060 31834 31834 E chromium: [ERROR:blimp_input_manager.cc(145)] Gesture event consumed: 13
05-13 11:18:53.060 31834 31834 E chromium: [ERROR:blimp_input_manager.cc(145)] Gesture event consumed: 14
05-13 11:18:53.802 31834 31834 E chromium: [ERROR:blimp_input_manager.cc(145)] Gesture event consumed: 15
05-13 11:18:53.803 31834 31834 E chromium: [ERROR:blimp_input_manager.cc(142)] Sending gesture event: 19
05-13 11:18:53.803 31834 31834 E chromium: [ERROR:input_message_generator.cc(174)] Not implemented reached in std::unique_ptr<BlimpMessage> blimp::InputMessageGenerator::GenerateMessage(const blink::WebGestureEvent &)
05-13 11:18:53.855 31834 31834 E chromium: [ERROR:blimp_input_manager.cc(142)] Sending gesture event: 20
05-13 11:18:53.855 31834 31834 E chromium: [ERROR:input_message_generator.cc(174)] Not implemented reached in std::unique_ptr<BlimpMessage> blimp::InputMessageGenerator::GenerateMessage(const blink::WebGestureEvent &)
05-13 11:18:53.855 31834 31834 E chromium: [ERROR:blimp_input_manager.cc(145)] Gesture event consumed: 11
05-13 11:18:53.855 31834 31834 E chromium: [ERROR:blimp_input_manager.cc(145)] Gesture event consumed: 13
05-13 11:18:53.876 31834 31834 E chromium: [ERROR:blimp_input_manager.cc(145)] Gesture event consumed: 13
05-13 11:18:53.893 31834 31834 E chromium: [ERROR:blimp_input_manager.cc(145)] Gesture event consumed: 13
05-13 11:18:53.899 31834 31834 E chromium: [ERROR:blimp_input_manager.cc(145)] Gesture event consumed: 13
05-13 11:18:53.899 31834 31834 E chromium: [ERROR:blimp_input_manager.cc(145)] Gesture event consumed: 14
05-13 11:18:54.337 31834 31834 E chromium: [ERROR:blimp_input_manager.cc(145)] Gesture event consumed: 15
05-13 11:18:54.337 31834 31834 E chromium: [ERROR:blimp_input_manager.cc(142)] Sending gesture event: 19
05-13 11:18:54.337 31834 31834 E chromium: [ERROR:input_message_generator.cc(174)] Not implemented reached in std::unique_ptr<BlimpMessage> blimp::InputMessageGenerator::GenerateMessage(const blink::WebGestureEvent &)
05-13 11:18:54.395 31834 31834 E chromium: [ERROR:blimp_input_manager.cc(142)] Sending gesture event: 18
Project Member

Comment 4 by bugdroid1@chromium.org, May 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d101e6286d62003088249577e5f931c335f6d060

commit d101e6286d62003088249577e5f931c335f6d060
Author: haibinlu <haibinlu@chromium.org>
Date: Mon May 16 21:30:23 2016

Client sends tapDown TapCancel TapUnconfirmed and showPress gesture events.

These events are used in content browser side gesture handling logic to update internal state or state machine, such as in render_widget_host_impl and tap_suppression_controller.

BUG= 598876 , 611590 

Review-Url: https://codereview.chromium.org/1975213003
Cr-Commit-Position: refs/heads/master@{#393933}

[modify] https://crrev.com/d101e6286d62003088249577e5f931c335f6d060/blimp/common/proto/input.proto
[modify] https://crrev.com/d101e6286d62003088249577e5f931c335f6d060/blimp/engine/session/blimp_engine_session.cc
[modify] https://crrev.com/d101e6286d62003088249577e5f931c335f6d060/blimp/net/input_message_converter.cc
[modify] https://crrev.com/d101e6286d62003088249577e5f931c335f6d060/blimp/net/input_message_generator.cc
[modify] https://crrev.com/d101e6286d62003088249577e5f931c335f6d060/blimp/net/input_message_unittest.cc

Comment 5 by haibinlu@chromium.org, May 16 2016

Status: Fixed (was: Started)

Comment 6 by amineer@chromium.org, Dec 9 2016

Labels: Archive-Blimp
►

Sign in to add a comment