New issue
Advanced search Search tips

Issue 611580 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS , Chrome
Pri: 1
Type: Bug

Blocking:
issue 585504



Sign in to add a comment

Not implemented ERROR message in LoginDisplayHostImpl::ShutdownDisplayHost

Project Member Reported by steve...@chromium.org, May 12 2016

Issue description

From the VMTest logs of a recent successful pfq builder:

login_display_host_impl.cc(1023)] Not implemented reached in void chromeos::LoginDisplayHostImpl::ShutdownDisplayHost(bool)

Code:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/chromeos/login/ui/login_display_host_impl.cc&q=login_display_host_impl.cc&sq=package:chromium&type=cs&l=1023

CL:
https://codereview.chromium.org/1929733002

This is causing confusing ERROR log spam on release builds.

 
1122334455
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, May 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c4480dca0af49887343705b1776ee01bb3cab19

commit 7c4480dca0af49887343705b1776ee01bb3cab19
Author: jonross <jonross@chromium.org>
Date: Mon May 16 21:10:22 2016

Reduce Error Message in LoginDisplayHostImpl::ShutdownDisplayHost
The NOTIMPLEMENTED for Mus in LoginDisplayHostImpl::ShutdownDisplayHost was too aggressive, and triggering in vm_tests for non-Mus builds. Restricting the NOTIMPLEMENTED to just the Mus scenario

BUG= 611580 

Review-Url: https://codereview.chromium.org/1980833002
Cr-Commit-Position: refs/heads/master@{#393919}

[modify] https://crrev.com/7c4480dca0af49887343705b1776ee01bb3cab19/chrome/browser/chromeos/login/ui/login_display_host_impl.cc

Labels: OS-iOS
Status: Fixed (was: Started)

Sign in to add a comment