New issue
Advanced search Search tips

Issue 611578 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Most MediaSourcePlayerTests fail on MediaTek devices

Reported by kra...@amazon.com, May 12 2016

Issue description

Version: Tip of master
OS: Android

What steps will reproduce the problem?
(1) Run MediaSourcePlayerTest* on a MediaTek device (e.g. mt8135)

What is the expected output?
All tests pass

What do you see instead?
All tests that use vp8 (which is a lot of them) fail

Please use labels and text to provide additional information.

 

Comment 1 by kra...@amazon.com, May 12 2016

Proposed solution as discussed via email with qinmin@
https://codereview.chromium.org/1975013002/
Project Member

Comment 2 by bugdroid1@chromium.org, May 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a541deee22a02150efc1014167520c835be7e5c

commit 8a541deee22a02150efc1014167520c835be7e5c
Author: kraush <kraush@amazon.com>
Date: Fri May 13 01:40:44 2016

Disable various MediaSourcePlayerTests on unsupported devices

Most MediaSourcePlayerTests require vp8 support to work.
Since VP8 was recently disabled on all MediaTek chipsets,
this change disables them on unsupported devices.

It also fixes media_codec_util's IsVp8/9DecoderAvailable
by using the accurate name for the respective mimes.

BUG= 611578 

Review-Url: https://codereview.chromium.org/1975013002
Cr-Commit-Position: refs/heads/master@{#393422}

[modify] https://crrev.com/8a541deee22a02150efc1014167520c835be7e5c/media/base/android/media_codec_util.h
[modify] https://crrev.com/8a541deee22a02150efc1014167520c835be7e5c/media/base/android/media_source_player_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b602d01299d28da09ba960ad0a4292e2bbe97f48

commit b602d01299d28da09ba960ad0a4292e2bbe97f48
Author: kraush <kraush@amazon.com>
Date: Tue May 17 17:01:07 2016

Disable MediaCodecBrdigeTest on unsupported devices

SdkMediaCodecBridgeTest.PresentationTimestampsDoNotDecrease
uses VP8 and will thus currently crash on devices where VP8
is not supported.
This change disables the test on those devices.

BUG= 611578 

Review-Url: https://codereview.chromium.org/1982683002
Cr-Commit-Position: refs/heads/master@{#394150}

[modify] https://crrev.com/b602d01299d28da09ba960ad0a4292e2bbe97f48/media/base/android/sdk_media_codec_bridge_unittest.cc

Components: Internals>Media
Status: Fixed (was: Untriaged)

Sign in to add a comment