New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 611574 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Remove extension only limitation for H264

Project Member Reported by niklase@chromium.org, May 12 2016

Issue description

Version: 52
OS: CrOS

For various reasons H264 support for WebRTC was added for extensions and apps on CrOS devices that have H264 HW encode capability. Now with H264 support being enabled for all platforms and all web pages there should be no limitation on enabling the HW encode support to extensions.
 
Cc: jansson@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, May 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6468142875bd0d0b1064965e82c4b04747cac2fd

commit 6468142875bd0d0b1064965e82c4b04747cac2fd
Author: emircan <emircan@chromium.org>
Date: Fri May 13 18:52:38 2016

Use kEnableWebRtcHWH264Encoding flag when SW fallback is available

HW H264 encoding was only enabled on extensions so far through
the use of kEnableWebRtcHWH264Encoding flag. This CL attaches
kEnableWebRtcHWH264Encoding when kWebRtcH264WithOpenH264FFmpeg
is available. As a result, HW H264 encoding would be enabled on
every supported platform where SW H264 fallback is also available.

BUG= 611574 

Review-Url: https://codereview.chromium.org/1972333002
Cr-Commit-Position: refs/heads/master@{#393593}

[modify] https://crrev.com/6468142875bd0d0b1064965e82c4b04747cac2fd/content/renderer/media/rtc_video_encoder_factory.cc

Status: Fixed (was: Assigned)
Status: Started (was: Fixed)
Opening this again as the above CL got reverted.
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 29 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffaecc8ff3be5cdd883e5a51b19acc04cb40a4b4

commit ffaecc8ff3be5cdd883e5a51b19acc04cb40a4b4
Author: emircan <emircan@chromium.org>
Date: Thu Jul 07 18:27:03 2016

Reland "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available"

This CL relands the below patch to enable HW H264 encoding on
every supported platform.
It was originally reverted while fixing ChromeOS issues listed
below. Kernel fixes for these have landed.

https://bugs.chromium.org/p/chromium/issues/detail?id=615272
https://bugs.chromium.org/p/chromium/issues/detail?id=625073#c3

BUG= 611574 ,625073
TEST=Test AppRTC loopback on
https://apprtc.appspot.com/?debug=loopback&vsc=h264
with flag enable-webrtc-h264-with-openh264-ffmpeg enabled.

Original CL description:
https://codereview.chromium.org/1972333002

Use kEnableWebRtcHWH264Encoding flag when SW fallback is available

HW H264 encoding was only enabled on extensions so far through
the use of kEnableWebRtcHWH264Encoding flag. This CL attaches
kEnableWebRtcHWH264Encoding when kWebRtcH264WithOpenH264FFmpeg
is available. As a result, HW H264 encoding would be enabled on
every supported platform where SW H264 fallback is also available.

Review-Url: https://codereview.chromium.org/2125163003
Cr-Commit-Position: refs/heads/master@{#404184}

[modify] https://crrev.com/ffaecc8ff3be5cdd883e5a51b19acc04cb40a4b4/content/renderer/media/gpu/rtc_video_encoder_factory.cc

Project Member

Comment 7 by sheriffbot@chromium.org, Jul 10 2016

Labels: -M-53 -Pri-1 M-54 MovedFrom-53 Pri-2
This issue is Pri-1 but has already been moved once. Lowering the priority and moving to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
emircan@ can you confirm that this is fixed and is landed in M53? If so, please update the milestone label.
Cc: wuchengli@chromium.org
Labels: OS-Chrome
Status: Fixed (was: Started)
This feature for Chromium on CrOS landed for 54(See comment 6), so I will mark it as fixed. We came across to some issues regarding CrOS kernel on testing with 53, for which a fix landed https://bugs.chromium.org/p/chromium/issues/detail?id=625073#c3.

wuchengli@, would the kernel fix you mentioned above make it to CrOS when Chromium M53 rolls. I am not clear on how CrOS and Chromium branch timelines work. If the kernel fix makes it to M53, I can merge the CL on comment 6 back to M-53. 
M53 has the fix for nyan. So you can merge the CL to M53 if you want. I'm not sure the risk of merging. Almost all CrOS have H264 HW encode so it will affect all CrOS. What is the use case of enabling H264 HW encode from end user's perspective? It only affects the extensions and apps that use pepper VideoEncodeAccelerator API?
Ping.
I don't think we should re-enable WebRTC HW H264 for 53, it's too risky at this point. Still this is issue fixed by disabling HW encode for 53.
As it stands, WebRTC CrOS will have SW H264 for M53 and HW H264 for M54+. 

Re 310, extensions have HW H264 enabled already. The difference would be only for WebRTC using HW encoders. Currently it is disabled for M53.

Comment 14 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 15 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 16 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 18 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment