CRD: Incorrect error message when the account is not on whitelist domain |
|||||||||||||
Issue descriptionChromeOS 51.0.2704.37 What steps will reproduce the problem? (1)In CPanel,navigate Device management>chrome>public session settings (2)set remote access clients policy crosprqa1.com (3)In device1, sign-in test@crosprqa1.com and launch CRD (4)Click on share button (5)Sign in device2 with different domain account test@crosprqa2.com and launch CRD (6) click on Access button and get the valid code from device1 What is the expected output? No able connect due to the policy set What do you see instead? See attachment
,
May 12 2016
I don't see any attachment. Did you forget to include it?
,
May 12 2016
,
May 12 2016
This is WAI, although I agree we should improve it. The problem is that adding new error messages is non-trivial right now, so I re-used an existing one.
,
May 13 2016
,
May 13 2016
We will discuss this at triage.
,
May 13 2016
,
May 13 2016
,
May 17 2016
Please prioritize and assign.
,
May 17 2016
We will discuss this at triage.
,
May 17 2016
Zijie, can you take a look? I think the offending line in the host code is https://code.google.com/p/chromium/codesearch#chromium/src/remoting/protocol/me2me_host_authenticator_factory.cc&sq=package:chromium&type=cs&l=116&rcl=1463498288, but you'll need to plumb the new error code through to the client and telemetry as well. If possible, it would be good to get the Chromium changes landed for M52.
,
May 18 2016
Working on it.
,
May 19 2016
I believe this bug is talking about it2me scenario instead of me2me scenario. It looks like the logic in me2me_host_authenticator_factory.cc line 116 should not be triggered. But no matter, I have updated both it2me_host_authenticator_factory and me2me_host_authenticator_factory.
,
May 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49b8bb897e86d171f9a5379086d9dec6812549a2 commit 49b8bb897e86d171f9a5379086d9dec6812549a2 Author: zijiehe <zijiehe@chromium.org> Date: Sat May 21 00:24:12 2016 This change is to add DOMAIN_MISMATCH message end to end. Currently if host client domain policy has been enabled, and client with a different domain tries to access a host in it2me scenario, invalid access code will be shown, but indeed the error message should be domain mismatch. BUG= 611544 Review-Url: https://codereview.chromium.org/1987163002 Cr-Commit-Position: refs/heads/master@{#395215} [modify] https://crrev.com/49b8bb897e86d171f9a5379086d9dec6812549a2/remoting/android/java/src/org/chromium/chromoting/jni/ConnectionListener.java [modify] https://crrev.com/49b8bb897e86d171f9a5379086d9dec6812549a2/remoting/base/chromoting_event.h [modify] https://crrev.com/49b8bb897e86d171f9a5379086d9dec6812549a2/remoting/client/client_telemetry_logger.cc [modify] https://crrev.com/49b8bb897e86d171f9a5379086d9dec6812549a2/remoting/client/ios/build/localizable_string_id_list.txt [modify] https://crrev.com/49b8bb897e86d171f9a5379086d9dec6812549a2/remoting/client/plugin/chromoting_instance.cc [modify] https://crrev.com/49b8bb897e86d171f9a5379086d9dec6812549a2/remoting/client/server_log_entry_client.cc [modify] https://crrev.com/49b8bb897e86d171f9a5379086d9dec6812549a2/remoting/protocol/authenticator.h [modify] https://crrev.com/49b8bb897e86d171f9a5379086d9dec6812549a2/remoting/protocol/errors.cc [modify] https://crrev.com/49b8bb897e86d171f9a5379086d9dec6812549a2/remoting/protocol/errors.h [modify] https://crrev.com/49b8bb897e86d171f9a5379086d9dec6812549a2/remoting/protocol/it2me_host_authenticator_factory.cc [modify] https://crrev.com/49b8bb897e86d171f9a5379086d9dec6812549a2/remoting/protocol/jingle_messages.cc [modify] https://crrev.com/49b8bb897e86d171f9a5379086d9dec6812549a2/remoting/protocol/jingle_messages.h [modify] https://crrev.com/49b8bb897e86d171f9a5379086d9dec6812549a2/remoting/protocol/jingle_session.cc [modify] https://crrev.com/49b8bb897e86d171f9a5379086d9dec6812549a2/remoting/protocol/me2me_host_authenticator_factory.cc [modify] https://crrev.com/49b8bb897e86d171f9a5379086d9dec6812549a2/remoting/resources/remoting_strings.grd [modify] https://crrev.com/49b8bb897e86d171f9a5379086d9dec6812549a2/remoting/webapp/base/js/chromoting_event.js [modify] https://crrev.com/49b8bb897e86d171f9a5379086d9dec6812549a2/remoting/webapp/base/js/client_session.js [modify] https://crrev.com/49b8bb897e86d171f9a5379086d9dec6812549a2/remoting/webapp/base/js/error.js
,
May 23 2016
,
Jun 1 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 24 2016
,
Jun 27 2016
,
Jul 25 2016
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by ajnolley@chromium.org
, May 12 2016