Downloads: Runtime error thrown from non-vulcanized version. |
|||
Issue descriptionRepro 1) Compile Chrome with use_vulcanize = false (or GYP equivalent). 2) Navigate to chrome://downloads The following exception is thrown to the console downloads.js:5 Uncaught TypeError: Cannot read property 'onLoad' of undefined Seems to be caused by the wrong order of loading files. Somehow this particular line is executed twice, and the 2nd time works, and therefore the first exception does not really have a user-visible impact.
,
May 12 2016
,
Jun 17 2016
Issue 621196 has been merged into this issue.
,
Jul 23 2016
icons.html is missing from the GRD. this means the error icon isn't shown for dangerous file types https://codereview.chromium.org/2178813002
,
Jul 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2edcb8d51c07ba717343849fd943cb197dc53f80 commit 2edcb8d51c07ba717343849fd943cb197dc53f80 Author: michaelpg <michaelpg@chromium.org> Date: Tue Jul 26 09:20:08 2016 Add missing resource to non-vulcanized Downloads BUG= 611542 R=dbeam@chromium.org Review-Url: https://codereview.chromium.org/2178813002 Cr-Commit-Position: refs/heads/master@{#407747} [modify] https://crrev.com/2edcb8d51c07ba717343849fd943cb197dc53f80/chrome/browser/browser_resources.grd [modify] https://crrev.com/2edcb8d51c07ba717343849fd943cb197dc53f80/chrome/browser/ui/webui/md_downloads/md_downloads_ui.cc
,
Jul 27 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dpa...@chromium.org
, May 12 2016