New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 611538 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

test_runner.py's --screenshot option is broken

Project Member Reported by jbudorick@chromium.org, May 12 2016

Issue description

--screenshot used to take screenshots of a device on instrumentation test failure. I broke it on switching instrumentation tests to the new implementation. We should make it work again.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09891bc02742f34a11a6d8ffd8993066f6c1b62c

commit 09891bc02742f34a11a6d8ffd8993066f6c1b62c
Author: hzl <hzl@google.com>
Date: Thu May 19 19:58:53 2016

Added the --screenshot option.

--screenshot option was broken for instrumentation tests. In this cl,
the option is enabled. With argument --screenshot, the device will take
a screenshot whenever an instrumentation test fails.

BUG= 611538 

Review-Url: https://codereview.chromium.org/1981043004
Cr-Commit-Position: refs/heads/master@{#394843}

[modify] https://crrev.com/09891bc02742f34a11a6d8ffd8993066f6c1b62c/build/android/pylib/instrumentation/instrumentation_test_instance.py
[modify] https://crrev.com/09891bc02742f34a11a6d8ffd8993066f6c1b62c/build/android/pylib/local/device/local_device_instrumentation_test_run.py
[modify] https://crrev.com/09891bc02742f34a11a6d8ffd8993066f6c1b62c/build/android/test_runner.py

Project Member

Comment 2 by bugdroid1@chromium.org, May 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a6fa1e0d268e6ef3f15aff3bb63fae8b94396cd

commit 5a6fa1e0d268e6ef3f15aff3bb63fae8b94396cd
Author: jbudorick <jbudorick@chromium.org>
Date: Fri May 20 01:40:41 2016

Revert of Added the --screenshot option. (patchset #7 id:120001 of https://codereview.chromium.org/1981043004/ )

Reason for revert:
breaks downstream

Original issue's description:
> Added the --screenshot option.
>
> --screenshot option was broken for instrumentation tests. In this cl,
> the option is enabled. With argument --screenshot, the device will take
> a screenshot whenever an instrumentation test fails.
>
> BUG= 611538 
>
> Committed: https://crrev.com/09891bc02742f34a11a6d8ffd8993066f6c1b62c
> Cr-Commit-Position: refs/heads/master@{#394843}

TBR=mikecase@chromium.org,hzl@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 611538 

Review-Url: https://codereview.chromium.org/1998903002
Cr-Commit-Position: refs/heads/master@{#394956}

[modify] https://crrev.com/5a6fa1e0d268e6ef3f15aff3bb63fae8b94396cd/build/android/pylib/instrumentation/instrumentation_test_instance.py
[modify] https://crrev.com/5a6fa1e0d268e6ef3f15aff3bb63fae8b94396cd/build/android/pylib/local/device/local_device_instrumentation_test_run.py
[modify] https://crrev.com/5a6fa1e0d268e6ef3f15aff3bb63fae8b94396cd/build/android/test_runner.py

Comment 3 by hzl@chromium.org, Jun 1 2016

Status: Fixed (was: Assigned)

Sign in to add a comment