New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 611492 link

Starred by 1 user
Status: Verified
Owner:
█ ejcaruso@chromium.org
Last visit 15 days ago
Closed: Jun 2016
Cc:
█ pstew@chromium.org
█ quiche@chromium.org
█ samueltan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Remove ScanType from shill

Project Member Reported by ejcaruso@chromium.org, May 12 2016 
Progressive scan was removed from shill, and now there is only one scan type. We can remove the ScanType enum and simplify the scanning code further.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/1244728e0dd5fdc8a58881e571aa5a2f3e24b2a0

commit 1244728e0dd5fdc8a58881e571aa5a2f3e24b2a0
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Thu Jun 16 19:07:58 2016

device: remove ScanType enum

This only has one value and has been useless since the
removal of progressive scan, so we can get rid of it.

BUG= chromium:611492 
TEST=make, unit tests

Change-Id: I287adcbdfe323848630686b3957f9faad550fbe9
Reviewed-on: https://chromium-review.googlesource.com/353188
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/1244728e0dd5fdc8a58881e571aa5a2f3e24b2a0/manager_unittest.cc
[modify] https://crrev.com/1244728e0dd5fdc8a58881e571aa5a2f3e24b2a0/wifi/mock_wifi.h
[modify] https://crrev.com/1244728e0dd5fdc8a58881e571aa5a2f3e24b2a0/wifi/wifi_unittest.cc
[modify] https://crrev.com/1244728e0dd5fdc8a58881e571aa5a2f3e24b2a0/dbus/chromeos_manager_dbus_adaptor.cc
[modify] https://crrev.com/1244728e0dd5fdc8a58881e571aa5a2f3e24b2a0/wimax/wimax.h
[modify] https://crrev.com/1244728e0dd5fdc8a58881e571aa5a2f3e24b2a0/binder/manager_binder_adaptor.cc
[modify] https://crrev.com/1244728e0dd5fdc8a58881e571aa5a2f3e24b2a0/dbus/chromeos_device_dbus_adaptor.cc
[modify] https://crrev.com/1244728e0dd5fdc8a58881e571aa5a2f3e24b2a0/wifi/wifi_provider.cc
[modify] https://crrev.com/1244728e0dd5fdc8a58881e571aa5a2f3e24b2a0/mock_manager.h
[modify] https://crrev.com/1244728e0dd5fdc8a58881e571aa5a2f3e24b2a0/cellular/cellular.h
[modify] https://crrev.com/1244728e0dd5fdc8a58881e571aa5a2f3e24b2a0/mock_device.h
[modify] https://crrev.com/1244728e0dd5fdc8a58881e571aa5a2f3e24b2a0/manager.h
[modify] https://crrev.com/1244728e0dd5fdc8a58881e571aa5a2f3e24b2a0/wifi/wifi.cc
[modify] https://crrev.com/1244728e0dd5fdc8a58881e571aa5a2f3e24b2a0/wifi/wifi.h
[modify] https://crrev.com/1244728e0dd5fdc8a58881e571aa5a2f3e24b2a0/cellular/cellular_unittest.cc
[modify] https://crrev.com/1244728e0dd5fdc8a58881e571aa5a2f3e24b2a0/device.cc
[modify] https://crrev.com/1244728e0dd5fdc8a58881e571aa5a2f3e24b2a0/wimax/wimax.cc
[modify] https://crrev.com/1244728e0dd5fdc8a58881e571aa5a2f3e24b2a0/manager.cc
[modify] https://crrev.com/1244728e0dd5fdc8a58881e571aa5a2f3e24b2a0/device.h
[modify] https://crrev.com/1244728e0dd5fdc8a58881e571aa5a2f3e24b2a0/wifi/wifi_provider_unittest.cc
[modify] https://crrev.com/1244728e0dd5fdc8a58881e571aa5a2f3e24b2a0/cellular/cellular.cc

Comment 2 by ejcaruso@chromium.org, Jun 23 2016

Status: Fixed (was: Assigned)
Fixed both here and in aosp.

Comment 3 by aashuto...@chromium.org, Jun 30 2016

Status: Verified (was: Fixed)
closing this as verified.

Comment 4 by cavalcantii@chromium.org, Sep 11 2017

Blocking: 764085

Comment 5 by cavalcantii@chromium.org, Sep 11 2017

Blocking: -764085
►

Sign in to add a comment