Hidpi custom cursors causing out-of-memory in CEF |
||
Issue descriptionAs reported by chris.araman@gmail.com: " 1) device_scale_factor_ is initialized in the default ctor, but not in the copy ctor. 2) device_scale_factor_ is not initialized in the webcursor_aurawin.cc implementation of InitPlatformData. 3) device_scale_factor_ is not copied in the webcursor_aurawin.cc implementation of CopyPlatformData. These defects cause an out of memory exception in CEF, tracked here: http://magpcss.org/ceforum/viewtopic.php?f=6&t=14130 "
,
May 12 2016
Some related defects, not directly from commit 027fb1e2: 4) external_cursor_ is not initialized in WebCursor's copy ctor 5) external_cursor_ is not copied in WebCursor::Copy 6) external_cursor_ is not cleared in WebCursor::Clear
,
May 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7429aa21a2591d18ee9a45cbb9a2d3976090335 commit d7429aa21a2591d18ee9a45cbb9a2d3976090335 Author: bsep <bsep@chromium.org> Date: Fri May 13 19:09:44 2016 Minor cleanup to webcursors: * Deleted unused field external_handle_. * Initialized some fields that weren't in the copy constructor. * Copied device_scale_factor_ in the copy constructor. * Added myself to OWNERS for this package. * Removed unnecessary FRIEND_TEST macro. BUG= 611487 Review-Url: https://codereview.chromium.org/1975033002 Cr-Commit-Position: refs/heads/master@{#393598} [modify] https://crrev.com/d7429aa21a2591d18ee9a45cbb9a2d3976090335/content/browser/devtools/protocol/color_picker.cc [modify] https://crrev.com/d7429aa21a2591d18ee9a45cbb9a2d3976090335/content/browser/renderer_host/input/touch_emulator.cc [modify] https://crrev.com/d7429aa21a2591d18ee9a45cbb9a2d3976090335/content/common/cursors/OWNERS [modify] https://crrev.com/d7429aa21a2591d18ee9a45cbb9a2d3976090335/content/common/cursors/webcursor.cc [modify] https://crrev.com/d7429aa21a2591d18ee9a45cbb9a2d3976090335/content/common/cursors/webcursor.h [modify] https://crrev.com/d7429aa21a2591d18ee9a45cbb9a2d3976090335/content/common/cursors/webcursor_aurawin.cc [modify] https://crrev.com/d7429aa21a2591d18ee9a45cbb9a2d3976090335/content/common/cursors/webcursor_unittest.cc [modify] https://crrev.com/d7429aa21a2591d18ee9a45cbb9a2d3976090335/content/renderer/cursor_utils.cc
,
May 13 2016
device_scale_factor_ is copied correctly now, which I believe will resolve the problem in CEF. |
||
►
Sign in to add a comment |
||
Comment 1 by chris.ar...@gmail.com
, May 12 2016