New issue
Advanced search Search tips

Issue 611473 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 594674



Sign in to add a comment

Add test that mus_demo runs.

Project Member Reported by kylec...@chromium.org, May 12 2016

Issue description

There should be some test that runs mus_demo to make sure that (a) mus isn't broken and (b) that the demo app still works. We don't have an easy way to verify graphical output right now so what the test should verify needs to be figured out.
 
Blockedon: 611504
Aside: I think that I broke it.
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4f4e191d33ee769ea258ca885938fa9ee3bf278

commit e4f4e191d33ee769ea258ca885938fa9ee3bf278
Author: kylechar <kylechar@chromium.org>
Date: Thu Jul 14 14:45:19 2016

Add unit test for mus_demo.

The unit test starts mus demo and checks that it successfully draws
compositor frames. Test is not setup to run on bots yet.

There is a problem where the WindowTree name isn't set to the client
name when the WindowTree is created for a WindowManager. Once this is
fixed EnsureClientHasDrawnWindow() should be using "mojo:mus_demo" as
the name it's looking for.

Also use this chance to fix some namespace stuff for MusDemo.

BUG= 611473 

Review-Url: https://codereview.chromium.org/2138433002
Cr-Commit-Position: refs/heads/master@{#405493}

[modify] https://crrev.com/e4f4e191d33ee769ea258ca885938fa9ee3bf278/services/ui/demo/BUILD.gn
[modify] https://crrev.com/e4f4e191d33ee769ea258ca885938fa9ee3bf278/services/ui/demo/main.cc
[modify] https://crrev.com/e4f4e191d33ee769ea258ca885938fa9ee3bf278/services/ui/demo/mus_demo.cc
[modify] https://crrev.com/e4f4e191d33ee769ea258ca885938fa9ee3bf278/services/ui/demo/mus_demo.h
[add] https://crrev.com/e4f4e191d33ee769ea258ca885938fa9ee3bf278/services/ui/demo/mus_demo_unittests.cc
[add] https://crrev.com/e4f4e191d33ee769ea258ca885938fa9ee3bf278/services/ui/demo/test_manifest.json

I tried enabling the test on a trybot. The mus_demo.mojo file doesn't get copied to the trybots so it fails. I'll have to investigate further to see how to get that file copied.
Blockedon: -611504 594674
This is blocked on tcmalloc errors when the test runs in a static build.
Labels: -mus Proj-Mustash-Mus Proj-Mustash-Testing
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22c22eb7ec4280b8310a5b2404fe7a86a6e01e65

commit 22c22eb7ec4280b8310a5b2404fe7a86a6e01e65
Author: kylechar <kylechar@chromium.org>
Date: Fri Sep 16 18:34:29 2016

Run mus_demo_unittests on X11 Chrome OS trybot.

Run mus_demo_unittests on the X11 Chrome OS trybot. This test just
checks that mojo:mus_demo starts and draws a frame. When tcmalloc
problems are fixed this should run on Ozone Chrome OS trybot (ideally
with Ozone X11).

BUG= 611473 

Review-Url: https://codereview.chromium.org/2151093003
Cr-Commit-Position: refs/heads/master@{#419226}

[modify] https://crrev.com/22c22eb7ec4280b8310a5b2404fe7a86a6e01e65/services/ui/demo/BUILD.gn
[modify] https://crrev.com/22c22eb7ec4280b8310a5b2404fe7a86a6e01e65/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/22c22eb7ec4280b8310a5b2404fe7a86a6e01e65/testing/buildbot/gn_isolate_map.pyl

Components: Internals>MUS
Labels: Proj-Mustash
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ff0ca0258695fad627c4cd7942e4f946ff9f910

commit 6ff0ca0258695fad627c4cd7942e4f946ff9f910
Author: kylechar <kylechar@chromium.org>
Date: Mon Nov 07 16:39:34 2016

Add mustash tests to Ozone CrOS trybot.

Run the following tests on linux_chromium_chromeos_ozone_rel_ng:
1. mus_demo_unittests
2. views_mus_interactive_ui_tests
3. views_mus_unittests

BUG= 642433 , 611473 

Review-Url: https://codereview.chromium.org/2478633003
Cr-Commit-Position: refs/heads/master@{#430294}

[modify] https://crrev.com/6ff0ca0258695fad627c4cd7942e4f946ff9f910/testing/buildbot/chromium.chromiumos.json

Status: Fixed (was: Started)
The test is now running on the CrOS Ozone bot.
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS

Sign in to add a comment