Simple Cache: Implement multi platform perftest for tracking open performance |
||
Issue descriptionTrying to launch Simple Cache everywhere, it's clear that there's some performance issues opening entries and reading headers on Mac and Windows. Let's get a perf test to close the cycle and do these fixes locally with instrumentation.
,
May 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72043600e68cca36ab875e7275932d7355f79042 commit 72043600e68cca36ab875e7275932d7355f79042 Author: gavinp <gavinp@chromium.org> Date: Fri May 13 18:00:22 2016 Use DiskCacheTestWithCache for DiskCachePerfTests. All that manual cache initialization was noise and took away some important convenience methods. This formulation significantly simplifies the code. R=juliatuttle@chromium.org BUG=611464 Review-Url: https://codereview.chromium.org/1976513004 Cr-Commit-Position: refs/heads/master@{#393576} [modify] https://crrev.com/72043600e68cca36ab875e7275932d7355f79042/net/disk_cache/disk_cache_perftest.cc
,
May 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfe07b41c2a19e02c9d8e5e5101c12babe4ca5fe commit dfe07b41c2a19e02c9d8e5e5101c12babe4ca5fe Author: gavinp <gavinp@chromium.org> Date: Fri May 13 19:03:32 2016 Add headers-only component to DiskCachePerfTest. Reading only the headers is a significant gap between SimpleCache and the blockfile backend. Let's test that independently of reading the whole bodies. R=juliatuttle@chromium.org BUG=611464 Review-Url: https://codereview.chromium.org/1976453003 Cr-Commit-Position: refs/heads/master@{#393595} [modify] https://crrev.com/dfe07b41c2a19e02c9d8e5e5101c12babe4ca5fe/net/disk_cache/disk_cache_perftest.cc
,
May 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c77d596b47fc4ece347e94c53db0d4daa16d75fd commit c77d596b47fc4ece347e94c53db0d4daa16d75fd Author: gavinp <gavinp@chromium.org> Date: Sun May 15 17:18:42 2016 Disk cache perf test: guard linux only flushes, add fd limit control. The system cache flush utilities can't flush directories except on Linux, so don't try. As well, it's only a convenience (since you can set the ulimit yourself in shell before running the test), but it's nice if the test just automatically gives itself an appropriate open file descriptor test limit. R=juliatuttle@chromium.org BUG=611464 TEST=None Review-Url: https://codereview.chromium.org/1978483004 Cr-Commit-Position: refs/heads/master@{#393773} [modify] https://crrev.com/c77d596b47fc4ece347e94c53db0d4daa16d75fd/net/disk_cache/disk_cache_perftest.cc
,
May 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e5bc2ec4c1c00e54cf966045def180f0e31ec18 commit 4e5bc2ec4c1c00e54cf966045def180f0e31ec18 Author: gavinp <gavinp@chromium.org> Date: Mon May 23 15:28:17 2016 Better defaults for the disk cache perftest. The defaults included were too small to meaningfully test os behaviour on file IO; these larger defaults are much more representative, but still create lots of smaller entries. The IO patterns of the test are still a bit unrealistic (reads and writes of entire entries), so that's likely a good idea for an improvement going forward. R=juliatuttle@chromium.org,rdsmith@chromium.org BUG=611464 Review-Url: https://codereview.chromium.org/1988833004 Cr-Commit-Position: refs/heads/master@{#395330} [modify] https://crrev.com/4e5bc2ec4c1c00e54cf966045def180f0e31ec18/net/disk_cache/disk_cache_perftest.cc
,
May 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a121fdb06ebe1ccb9bf2233404a25c8559587ec commit 6a121fdb06ebe1ccb9bf2233404a25c8559587ec Author: gavinp <gavinp@chromium.org> Date: Thu May 26 20:34:28 2016 Simple Cache: sync disk cache perftests carefully. The simple cache in particular requires very cautious sync to ensure prior operations are completed. Existing tests are more stable, particularly on windows if we do this. R=rdsmith@chromium.org BUG=611464 Review-Url: https://codereview.chromium.org/2018583002 Cr-Commit-Position: refs/heads/master@{#396272} [modify] https://crrev.com/6a121fdb06ebe1ccb9bf2233404a25c8559587ec/net/disk_cache/disk_cache_perftest.cc
,
Nov 20 2017
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3860655759a60ce589514e8c22e04abb79f171b commit f3860655759a60ce589514e8c22e04abb79f171b Author: Maks Orlovich <morlovich@chromium.org> Date: Wed Dec 13 18:03:16 2017 disk_cache_perf_test: Actually be parallel This is 99.9% work by Gavin Peters, at https://codereview.chromium.org/2501353002, with me just tweaking some parameters and applying the tiny things I suggested on that review. Bug: 611464, 722885 Change-Id: I5bdc7d60ec4bc54e1099f408ea09e0573c176fca Reviewed-on: https://chromium-review.googlesource.com/800972 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by: Julia Tuttle <juliatuttle@chromium.org> Cr-Commit-Position: refs/heads/master@{#523814} [modify] https://crrev.com/f3860655759a60ce589514e8c22e04abb79f171b/net/disk_cache/backend_unittest.cc [modify] https://crrev.com/f3860655759a60ce589514e8c22e04abb79f171b/net/disk_cache/disk_cache_perftest.cc [modify] https://crrev.com/f3860655759a60ce589514e8c22e04abb79f171b/net/disk_cache/disk_cache_test_base.cc [modify] https://crrev.com/f3860655759a60ce589514e8c22e04abb79f171b/net/disk_cache/disk_cache_test_base.h [modify] https://crrev.com/f3860655759a60ce589514e8c22e04abb79f171b/net/disk_cache/disk_cache_test_util.cc [modify] https://crrev.com/f3860655759a60ce589514e8c22e04abb79f171b/net/disk_cache/disk_cache_test_util.h |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, May 13 2016