Issue metadata
Sign in to add a comment
|
4.1% regression in thread_times.tough_scrolling_cases at 393081:393111 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
May 12 2016
=== Auto-CCing suspected CL author wangxianzhu@chromium.org === Hi wangxianzhu@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Fix paint invalidation rect of LayoutView Author : wangxianzhu Commit description: The bug was caused by http://crrev.com/1929413002 which uses selfVisualOverflowRect() instead of visualOverflowRect() to calculate paint invalidation rect. It caused wrong paint invalidation rect for LayoutView. Before rootLayerScrolls is launched, LayoutView's overflow model is special. We should calculate its paint invalidation rect based on its special visualOverflowRect() for now. BUG= 611046 Review-Url: https://codereview.chromium.org/1971843002 Cr-Commit-Position: refs/heads/master@{#393099} Commit : c053f70ee05c2dd91bf8b9da324e2a631e356bdc Date : Wed May 11 23:13:44 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@393080 11.302 0.0830964 5 good chromium@393096 11.2872 0.0844763 5 good chromium@393098 11.3231 0.119579 5 good chromium@393099 11.9063 0.112223 5 bad <-- chromium@393100 11.9365 0.187388 5 bad chromium@393104 11.9843 0.22349 5 bad chromium@393111 11.7494 0.110016 5 bad Bisect job ran on: linux_perf_bisect Bug ID: 611449 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests thread_times.tough_scrolling_cases Test Metric: thread_total_all_cpu_time_per_frame/thread_total_all_cpu_time_per_frame Relative Change: 3.96% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6492 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9012850172560055216 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5815788078891008 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
May 12 2016
The performance just returned to the original level before the bug that the CL fixed. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by pras...@chromium.org
, May 12 2016