We should really have zero FAILs for this test.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08ced96eadd5a34cdd251a02e68d686d556f8a12 commit 08ced96eadd5a34cdd251a02e68d686d556f8a12 Author: rob.buis <rob.buis@samsung.com> Date: Fri May 13 11:53:41 2016 Implement stricter hashless hex color parsing According to the spec[1] for both <number> and <dimension> we need to check that the component values are non-negative and integers. Implement that and add some subtests for it. With this change we are passing the official test[2] linked from the spec. BUG= 611442 [1] https://quirks.spec.whatwg.org/#the-hashless-hex-color-quirk [2] http://w3c-test.org/quirks-mode/hashless-hex-color.html Review-Url: https://codereview.chromium.org/1963843002 Cr-Commit-Position: refs/heads/master@{#393502} [modify] https://crrev.com/08ced96eadd5a34cdd251a02e68d686d556f8a12/third_party/WebKit/LayoutTests/fast/css/parsing-color-quirk.html [modify] https://crrev.com/08ced96eadd5a34cdd251a02e68d686d556f8a12/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6291c3ea84f371d10c0d10e66ee6d11458c9d42 commit a6291c3ea84f371d10c0d10e66ee6d11458c9d42 Author: rob.buis <rob.buis@samsung.com> Date: Mon May 23 15:02:23 2016 Import quirks-mode tests Import quirks-mode tests and mark the failing tests in TestExpectations for now. BUG= 611442 Review-Url: https://codereview.chromium.org/1974833002 Cr-Commit-Position: refs/heads/master@{#395325} [modify] https://crrev.com/a6291c3ea84f371d10c0d10e66ee6d11458c9d42/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/a6291c3ea84f371d10c0d10e66ee6d11458c9d42/third_party/WebKit/LayoutTests/W3CImportExpectations [add] https://crrev.com/a6291c3ea84f371d10c0d10e66ee6d11458c9d42/third_party/WebKit/LayoutTests/imported/wpt/quirks-mode/blocks-ignore-line-height.html [add] https://crrev.com/a6291c3ea84f371d10c0d10e66ee6d11458c9d42/third_party/WebKit/LayoutTests/imported/wpt/quirks-mode/hashless-hex-color.html [add] https://crrev.com/a6291c3ea84f371d10c0d10e66ee6d11458c9d42/third_party/WebKit/LayoutTests/imported/wpt/quirks-mode/line-height-calculation.html [add] https://crrev.com/a6291c3ea84f371d10c0d10e66ee6d11458c9d42/third_party/WebKit/LayoutTests/imported/wpt/quirks-mode/percentage-height-calculation.html [add] https://crrev.com/a6291c3ea84f371d10c0d10e66ee6d11458c9d42/third_party/WebKit/LayoutTests/imported/wpt/quirks-mode/supports.html [add] https://crrev.com/a6291c3ea84f371d10c0d10e66ee6d11458c9d42/third_party/WebKit/LayoutTests/imported/wpt/quirks-mode/table-cell-nowrap-minimum-width-calculation.html [add] https://crrev.com/a6291c3ea84f371d10c0d10e66ee6d11458c9d42/third_party/WebKit/LayoutTests/imported/wpt/quirks-mode/table-cell-width-calculation.html [add] https://crrev.com/a6291c3ea84f371d10c0d10e66ee6d11458c9d42/third_party/WebKit/LayoutTests/imported/wpt/quirks-mode/unitless-length.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9333d231ceae728f850edf4e3c0241642467c1d0 commit 9333d231ceae728f850edf4e3c0241642467c1d0 Author: mek <mek@chromium.org> Date: Mon May 23 20:16:06 2016 Revert of Import quirks-mode tests (patchset #6 id:120001 of https://codereview.chromium.org/1974833002/ ) Reason for revert: Not sure why the TestExpectations aren't working, but this is causing failures on the WebKit Win7 dbg bot: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/5742 11:01:42.789 4692 worker/1 imported/wpt/quirks-mode/hashless-hex-color.html output stderr lines: 11:01:42.789 4692 [5292:4872:0523/110125:6137438:ERROR:service_registry_impl.cc(95)] blink::mojom::VRService not found 11:01:42.789 4916 [2/2] imported/wpt/quirks-mode/hashless-hex-color.html failed unexpectedly (test timed out) Original issue's description: > Import quirks-mode tests > > Import quirks-mode tests and mark the failing tests in > TestExpectations for now. > > BUG= 611442 > > Committed: https://crrev.com/a6291c3ea84f371d10c0d10e66ee6d11458c9d42 > Cr-Commit-Position: refs/heads/master@{#395325} TBR=tkent@chromium.org,kojii@chromium.org,rune@opera.com,timloh@chromium.org,rob.buis@samsung.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 611442 Review-Url: https://codereview.chromium.org/2007683002 Cr-Commit-Position: refs/heads/master@{#395399} [modify] https://crrev.com/9333d231ceae728f850edf4e3c0241642467c1d0/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/9333d231ceae728f850edf4e3c0241642467c1d0/third_party/WebKit/LayoutTests/W3CImportExpectations [delete] https://crrev.com/2c82e33281c61d660697a56bb337c598e487ef0a/third_party/WebKit/LayoutTests/imported/wpt/quirks-mode/blocks-ignore-line-height.html [delete] https://crrev.com/2c82e33281c61d660697a56bb337c598e487ef0a/third_party/WebKit/LayoutTests/imported/wpt/quirks-mode/hashless-hex-color.html [delete] https://crrev.com/2c82e33281c61d660697a56bb337c598e487ef0a/third_party/WebKit/LayoutTests/imported/wpt/quirks-mode/line-height-calculation.html [delete] https://crrev.com/2c82e33281c61d660697a56bb337c598e487ef0a/third_party/WebKit/LayoutTests/imported/wpt/quirks-mode/percentage-height-calculation.html [delete] https://crrev.com/2c82e33281c61d660697a56bb337c598e487ef0a/third_party/WebKit/LayoutTests/imported/wpt/quirks-mode/supports.html [delete] https://crrev.com/2c82e33281c61d660697a56bb337c598e487ef0a/third_party/WebKit/LayoutTests/imported/wpt/quirks-mode/table-cell-nowrap-minimum-width-calculation.html [delete] https://crrev.com/2c82e33281c61d660697a56bb337c598e487ef0a/third_party/WebKit/LayoutTests/imported/wpt/quirks-mode/table-cell-width-calculation.html [delete] https://crrev.com/2c82e33281c61d660697a56bb337c598e487ef0a/third_party/WebKit/LayoutTests/imported/wpt/quirks-mode/unitless-length.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d74e226e0bc4ea9b4914af953d15f61ab5f4e5bb commit d74e226e0bc4ea9b4914af953d15f61ab5f4e5bb Author: rob.buis <rob.buis@samsung.com> Date: Tue May 24 12:27:16 2016 Import quirks-mode tests Import quirks-mode tests and mark the failing tests in TestExpectations for now. BUG= 611442 Committed: https://crrev.com/a6291c3ea84f371d10c0d10e66ee6d11458c9d42 Cr-Commit-Position: refs/heads/master@{#395325} Review-Url: https://codereview.chromium.org/1974833002 Cr-Commit-Position: refs/heads/master@{#395577} [modify] https://crrev.com/d74e226e0bc4ea9b4914af953d15f61ab5f4e5bb/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/d74e226e0bc4ea9b4914af953d15f61ab5f4e5bb/third_party/WebKit/LayoutTests/W3CImportExpectations [add] https://crrev.com/d74e226e0bc4ea9b4914af953d15f61ab5f4e5bb/third_party/WebKit/LayoutTests/imported/wpt/quirks-mode/blocks-ignore-line-height.html [add] https://crrev.com/d74e226e0bc4ea9b4914af953d15f61ab5f4e5bb/third_party/WebKit/LayoutTests/imported/wpt/quirks-mode/hashless-hex-color.html [add] https://crrev.com/d74e226e0bc4ea9b4914af953d15f61ab5f4e5bb/third_party/WebKit/LayoutTests/imported/wpt/quirks-mode/line-height-calculation.html [add] https://crrev.com/d74e226e0bc4ea9b4914af953d15f61ab5f4e5bb/third_party/WebKit/LayoutTests/imported/wpt/quirks-mode/percentage-height-calculation.html [add] https://crrev.com/d74e226e0bc4ea9b4914af953d15f61ab5f4e5bb/third_party/WebKit/LayoutTests/imported/wpt/quirks-mode/supports.html [add] https://crrev.com/d74e226e0bc4ea9b4914af953d15f61ab5f4e5bb/third_party/WebKit/LayoutTests/imported/wpt/quirks-mode/table-cell-nowrap-minimum-width-calculation.html [add] https://crrev.com/d74e226e0bc4ea9b4914af953d15f61ab5f4e5bb/third_party/WebKit/LayoutTests/imported/wpt/quirks-mode/table-cell-width-calculation.html [add] https://crrev.com/d74e226e0bc4ea9b4914af953d15f61ab5f4e5bb/third_party/WebKit/LayoutTests/imported/wpt/quirks-mode/unitless-length.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f08cd81c9e45446510cd29862f81480d4df5173 commit 2f08cd81c9e45446510cd29862f81480d4df5173 Author: rob.buis <rob.buis@samsung.com> Date: Tue May 24 18:56:56 2016 Fix hashless-hex-color.html quirks-mode test Fix the newly imported hashless-hex-color.html quirks-mode test, I thought this was fixed earlier, but my mistake was assuming hex colors of length 8 were allowed, however upon closer inspection of the spec [1] I missed step 4 initially, so implement that step. BUG= 611442 [1] https://quirks.spec.whatwg.org/#the-hashless-hex-color-quirk Review-Url: https://codereview.chromium.org/1992793002 Cr-Commit-Position: refs/heads/master@{#395656} [modify] https://crrev.com/2f08cd81c9e45446510cd29862f81480d4df5173/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/2f08cd81c9e45446510cd29862f81480d4df5173/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
Should be fixed by r395656.
Comment 1 by bugdroid1@chromium.org
, May 13 2016