Issue metadata
Sign in to add a comment
|
20%-38% regression in power.gpu_rasterization.top_25 at 392893:392915 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
May 12 2016
=== Auto-CCing suspected CL author sigbjornf@opera.com === Hi sigbjornf@opera.com, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Revert of Eagerly remove disposed DOMTimers as observers. (patchset #1 id:1 of https://codereview.chromium.org/1959013002/ ) Author : sigbjornf Commit description: Reason for revert: Caused issue 610606 , reverting to locally investigate how/why. Original issue's description: > Eagerly remove disposed DOMTimers as observers. > > Once the coordinator lets go of a timer, no need to keep it > around as an observer of the ExecutionContext. > > R= > BUG= > > Committed: https://crrev.com/0a297738301705d02f57968334bd6f7c7dc95f4c > Cr-Commit-Position: refs/heads/master@{#392309} TBR=oilpan-reviews@chromium.org,keishi@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Review-Url: https://codereview.chromium.org/1968963002 Cr-Commit-Position: refs/heads/master@{#392901} Commit : b0438b3ba5de4aa326db9197e86ed408edf710a2 Date : Wed May 11 12:33:19 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@392899 32.8604 1.10973 5 good chromium@392900 33.1251 1.27137 5 good chromium@392901 39.299 1.04238 5 bad <-- chromium@392902 38.7771 0.768879 5 bad chromium@392904 39.0058 1.20532 5 bad chromium@392909 39.1425 1.10481 5 bad Bisect job ran on: mac_retina_perf_bisect Bug ID: 611435 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests power.gpu_rasterization.top_25 Test Metric: energy_consumption_mwh/energy_consumption_mwh Relative Change: 19.12% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1297 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9012851858524966208 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5788340016644096 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
May 13 2016
That revert took out a CL that mistakenly reduced the frequency of nested timers being fired, i.e., it was broken and didn't belong. In that view, I would expect it to increase power usage by being reverted. But not a regression per se. Moving to WontFix. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by pras...@chromium.org
, May 12 2016